perf tools: Add a place to put kernel config fragments for test runs
cover perf tools: Add a place to put kernel config fragments for test runs
Changes since RFC:
* Changed arch filename convention to use the ARCH= build time values instead of uname
It seems like there were no objections on the RFC, apart from maybe changing the perf tests to run as a kself test. But that's probably not going to happen for a while, if ever, and these fragments can always be moved in that case.
James Clark (1):
perf tools: Add a place to put kernel config fragments for test runs
tools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/config
base-commit: ad5f604e186ac08d12c401e34ea96c09c38ddbc5
Signature · 1 line
2.34.1
PATCH 1/1 perf tools: Add a place to put kernel config fragments for test runs
Defconfig doesn't give full coverage for a perf test run, so these can be merged with defconfig to do so. It's not complete yet, but is a starting point as a place to add to when a specific test needs something extra to run.
--- tools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/config
tools/perf/tests/config-fragments/README new file +7 -0
@@ -0,0 +1,7 @@ +This folder is for kernel config fragments that can be merged with +defconfig to give full test coverage of a perf test run. This is only +an optimistic set as some features require hardware support in order to +pass and not skip. + +'config' is shared across all platforms, and for arch specific files, +the file name should match that used in the ARCH=... make option.
tools/perf/tests/config-fragments/arm64 new file +1 -0
@@ -0,0 +1 @@ +CONFIG_CORESIGHT_SOURCE_ETM4X=y
tools/perf/tests/config-fragments/config new file +11 -0
@@ -0,0 +1,11 @@ +CONFIG_TRACEPOINTS=y +CONFIG_STACKTRACE=y +CONFIG_NOP_TRACER=y +CONFIG_RING_BUFFER=y +CONFIG_EVENT_TRACING=y +CONFIG_CONTEXT_SWITCH_TRACER=y +CONFIG_TRACING=y +CONFIG_GENERIC_TRACER=y +CONFIG_FTRACE=y +CONFIG_FTRACE_SYSCALLS=y +CONFIG_BRANCH_PROFILE_NONE=y
Signature · 1 line
2.34.1
Namhyung Kim
maintainerHi James,
Quoted 10 lines · James Clark
Changes since RFC:
* Changed arch filename convention to use the ARCH= build time values instead of uname
It seems like there were no objections on the RFC, apart from maybe changing the perf tests to run as a kself test. But that's probably not going to happen for a while, if ever, and these fragments can always be moved in that case.
I missed the RFC, sorry. Could you please add a link for that?
Thanks,
Namhyung
Quoted 17 lines
James Clark (1):
perf tools: Add a place to put kernel config fragments for test runstools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/configbase-commit:
ad5f604e186ac08d12c401e34ea96c09c38ddbc5--
2.34.1
Quoted 14 lines · Namhyung Kim
Hi James,
Quoted 10 lines · James Clark
Changes since RFC:
* Changed arch filename convention to use the ARCH= build time values instead of uname
It seems like there were no objections on the RFC, apart from maybe changing the perf tests to run as a kself test. But that's probably not going to happen for a while, if ever, and these fragments can always be moved in that case.
Quoted 4 lines
I missed the RFC, sorry. Could you please add a link for that?
Thanks,
Namhyung
Yep, it's here:
https://lore.kernel.org/lkml/[email protected]/T/
Quoted 19 lines
Quoted 19 lines
James Clark (1):
perf tools: Add a place to put kernel config fragments for test runstools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/configbase-commit:
ad5f604e186ac08d12c401e34ea96c09c38ddbc5--
2.34.1
Quoted 17 lines · James Clark
Quoted 14 lines · Namhyung Kim
Hi James,
Quoted 10 lines · James Clark
Changes since RFC:
* Changed arch filename convention to use the ARCH= build time values instead of uname
It seems like there were no objections on the RFC, apart from maybe changing the perf tests to run as a kself test. But that's probably not going to happen for a while, if ever, and these fragments can always be moved in that case.
Quoted 8 lines
Quoted 4 lines
I missed the RFC, sorry. Could you please add a link for that?
Thanks,
NamhyungYep, it's here:
https://lore.kernel.org/lkml/[email protected]/T/
Hi Arnaldo,
Any interest in taking this one?
Thanks
James
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
James Clark (1):
perf tools: Add a place to put kernel config fragments for test runstools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/configbase-commit:
ad5f604e186ac08d12c401e34ea96c09c38ddbc5--
2.34.1
Em Fri, Jul 28, 2023 at 11:48:34AM +0100, James Clark escreveu:
Quoted 25 lines · James Clark
Quoted 22 lines · Namhyung Kim
Quoted 18 lines
Hi James,
Quoted 10 lines · James Clark
Changes since RFC:
* Changed arch filename convention to use the ARCH= build time values instead of uname
It seems like there were no objections on the RFC, apart from maybe changing the perf tests to run as a kself test. But that's probably not going to happen for a while, if ever, and these fragments can always be moved in that case.
I missed the RFC, sorry. Could you please add a link for that?
Thanks,
Namhyung
Quoted 7 lines
Quoted 3 lines
Yep, it's here:
https://lore.kernel.org/lkml/[email protected]/T/Hi Arnaldo,
Any interest in taking this one?
Yeah, looks useful, we can go on from this starting point and improve it.
I merged it into perf-tools-next.
Thanks,
- Arnaldo
Quoted 22 lines
Thanks
JamesQuoted 19 lines
Quoted 19 lines
Quoted 19 lines
James Clark (1):
perf tools: Add a place to put kernel config fragments for test runstools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/configbase-commit:
ad5f604e186ac08d12c401e34ea96c09c38ddbc5--
2.34.1
Signature · 1 line
- Arnaldo
Quoted 34 lines · Arnaldo Carvalho de Melo
Em Fri, Jul 28, 2023 at 11:48:34AM +0100, James Clark escreveu:
Quoted 25 lines · James Clark
Quoted 22 lines · Namhyung Kim
Quoted 18 lines
Hi James,
Quoted 10 lines · James Clark
Changes since RFC:
* Changed arch filename convention to use the ARCH= build time values instead of uname
It seems like there were no objections on the RFC, apart from maybe changing the perf tests to run as a kself test. But that's probably not going to happen for a while, if ever, and these fragments can always be moved in that case.
I missed the RFC, sorry. Could you please add a link for that?
Thanks,
NamhyungQuoted 7 lines
Quoted 3 lines
Yep, it's here:
https://lore.kernel.org/lkml/[email protected]/T/Hi Arnaldo,
Any interest in taking this one?
Quoted 9 lines
Yeah, looks useful, we can go on from this starting point and improve it.
I merged it into perf-tools-next.
Thanks,
- Arnaldo
Thanks Arnaldo!
Quoted 23 lines
Quoted 22 lines
Thanks
JamesQuoted 19 lines
Quoted 19 lines
Quoted 19 lines
James Clark (1):
perf tools: Add a place to put kernel config fragments for test runstools/perf/tests/config-fragments/README | 7 +++++++ tools/perf/tests/config-fragments/arm64 | 1 + tools/perf/tests/config-fragments/config | 11 +++++++++++ 3 files changed, 19 insertions(+) create mode 100644 tools/perf/tests/config-fragments/README create mode 100644 tools/perf/tests/config-fragments/arm64 create mode 100644 tools/perf/tests/config-fragments/configbase-commit:
ad5f604e186ac08d12c401e34ea96c09c38ddbc5--
2.34.1