Skip to contentSkip to conversation

minor build warning fixes

PATCH Applied Kent Gibson 3 participants 6 messages Jun 29, 2023 – Jun 30, 2023 GPIO

lore
Share & tools
lore
#0 lore raw

cover minor build warning fixes

Fixes for a couple of minor warnings reported when building with a fresh OS install.
The first fixes another typo in the examples makefile.
The second fixes another warning that is emitted by recent rust.

I note that with a fresh/minimal OS install the rust bindings still fail to build due to a missing dependency on libclang and clang headers, but that isn't tested for by configure - it fails during the build.

Kent Gibson (2):
examples: fix typo in Makefile.am
bindings: rust: fix unclear resolver warning

 bindings/rust/Cargo.toml | 2 ++
 examples/Makefile.am     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.41.0
#1 lore raw

PATCH 1/2 examples: fix typo in Makefile.am

The trailing "s" is missing from "toggle_multiple_line_values" in several places, so add it.

---
 examples/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/Makefile.am +1 -1
index daf902b..e92f303 100644
@@ -37,7 +37,7 @@ reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c
 
 toggle_line_value_SOURCES = toggle_line_value.c
 
-toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c
+toggle_multiple_line_values_SOURCES = toggle_multiple_line_values.c
 
 watch_line_info_SOURCES = watch_line_info.c
 
Signature · 1 line
2.41.0
#2 lore raw

Re: [libgpiod][PATCH 1/2] examples: fix typo in Makefile.am

Quoted 23 lines · Kent Gibson

The trailing "s" is missing from "toggle_multiple_line_values" in several places, so add it.

---
 examples/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/Makefile.am +1 -2
index daf902b..e92f303 100644
@@ -37,7 +37,7 @@ reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c
 
 toggle_line_value_SOURCES = toggle_line_value.c
 
-toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c
+toggle_multiple_line_values_SOURCES = toggle_multiple_line_values.c
 
 watch_line_info_SOURCES = watch_line_info.c
 
--
Quoted 2 lines

2.41.0

I'm wondering if we should just drop these as autotools will default to using a single source file named after the target executable if foobar_SOURCES is not defined. (iow: if the target is foobar and no foobar_SOURCES is defined, then it will try foobar.c).

Bart

#3 lore raw

PATCH 2/2 bindings: rust: fix unclear resolver warning

In reply to Kent Gibson

Fix the following warning:

"some crates are on edition 2021 which defaults to resolver = "2",
but virtual workspaces default to resolver = "1""

Clarify the resolver selection as the 2021 edition by setting the workspace.resolver to "2".

---
 bindings/rust/Cargo.toml | 2 ++
 1 file changed, 2 insertions(+)
bindings/rust/Cargo.toml +2 -0
index 2e026b4..e385027 100644
@@ -9,3 +9,5 @@ members = [
     "libgpiod",
     "libgpiod-sys"
 ]
+
+resolver = "2"
Signature · 1 line
2.41.0
Reviewed-by on v1 2/2
#4 lore raw

Re: [libgpiod][PATCH 2/2] bindings: rust: fix unclear resolver warning

Quoted 7 lines · Kent Gibson

Fix the following warning:

"some crates are on edition 2021 which defaults to resolver = "2",
but virtual workspaces default to resolver = "1""

Clarify the resolver selection as the 2021 edition by setting the workspace.resolver to "2".

#5 lore raw

Re: [libgpiod][PATCH 2/2] bindings: rust: fix unclear resolver warning

In reply to Kent Gibson
Quoted 25 lines · Kent Gibson

Fix the following warning:

"some crates are on edition 2021 which defaults to resolver = "2",
but virtual workspaces default to resolver = "1""

Clarify the resolver selection as the 2021 edition by setting the workspace.resolver to "2".

---
 bindings/rust/Cargo.toml | 2 ++
 1 file changed, 2 insertions(+)
bindings/rust/Cargo.toml +2 -1
index 2e026b4..e385027 100644
@@ -9,3 +9,5 @@ members = [
     "libgpiod",
     "libgpiod-sys"
 ]
+
+resolver = "2"
--
Quoted 2 lines

2.41.0

Applied, thanks!

Bart