Skip to contentSkip to conversation

docs: remove the tips on how to submit patches from MAINTAINERS

PATCH Applied Jakub Kicinski 5 participants 6 messages Jun 30, 2023 – Jul 3, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: remove the tips on how to submit patches from MAINTAINERS

Having "how to submit patches" in MAINTAINTERS seems out of place. We have a whole section of documentation about it, duplication is harmful and a lot of the text looks really out of date.

Sections 1, 2 and 4 look really, really old and not applicable to the modern process.

Section 3 is obvious but also we have build bots now.

Section 5 is a bit outdated (diff -u?!). But I like the part about factoring out shared code, so add that to process docs.

Section 6 is unnecessary?

Section 7 is covered by more appropriate docs.

---
 Documentation/process/6.Followthrough.rst |  7 ++
 MAINTAINERS                               | 80 +----------------------
 2 files changed, 9 insertions(+), 78 deletions(-)
Documentation/process/6.Followthrough.rst +7 -0
index a173cd5f93d2..66fa400c6d94 100644
@@ -51,6 +51,13 @@ process.  Life can be made much easier, though, if you keep a few things in
    working toward the creation of the best kernel they can; they are not
    trying to create discomfort for their employers' competitors.
 
+ - Be prepared for seemingly silly requests for coding style changes
+   and requests to factor out some of your code to shared parts of
+   the kernel. One job the maintainers do is to keep things looking
+   the same. Sometimes this means that the clever hack in your driver
+   to get around a problem actually needs to become a generalized
+   kernel feature ready for next time.
+
 What all of this comes down to is that, when reviewers send you comments,
 you need to pay attention to the technical observations that they are
 making.  Do not let their form of expression or your own pride keep that
MAINTAINERS +2 -78

83 lines not on this page · raw message

Signature · 1 line
2.41.0
maintainer
#1 lore raw
Quoted 14 lines · Jakub Kicinski

Having "how to submit patches" in MAINTAINTERS seems out of place. We have a whole section of documentation about it, duplication is harmful and a lot of the text looks really out of date.

Sections 1, 2 and 4 look really, really old and not applicable to the modern process.

Section 3 is obvious but also we have build bots now.

Section 5 is a bit outdated (diff -u?!). But I like the part about factoring out shared code, so add that to process docs.

Section 6 is unnecessary?

Quoted 7 lines

Section 7 is covered by more appropriate docs.

---
 Documentation/process/6.Followthrough.rst |  7 ++
 MAINTAINERS                               | 80 +----------------------
 2 files changed, 9 insertions(+), 78 deletions(-)

This has been discussed in the past, I'm not sure why we've never done it. I totally agree, and will happily apply this unless somebody objects or beats me to it.

Thanks,

jon

Reviewed-by on v1 1/1
#3 lore raw
In reply to Jakub Kicinski
Quoted 9 lines · Jakub Kicinski

Having "how to submit patches" in MAINTAINTERS seems out of place. We have a whole section of documentation about it, duplication is harmful and a lot of the text looks really out of date.

Sections 1, 2 and 4 look really, really old and not applicable to the modern process.

Section 3 is obvious but also we have build bots now.

Quoted 8 lines

Section 5 is a bit outdated (diff -u?!). But I like the part about factoring out shared code, so add that to process docs.

Section 6 is unnecessary?

Section 7 is covered by more appropriate docs.

Yes please. :)

Signature · 1 line
Kees Cook
Reviewed-by
#2 lore raw
In reply to Jonathan Corbet
Quoted 24 lines · Jonathan Corbet
Quoted 14 lines · Jakub Kicinski

Having "how to submit patches" in MAINTAINTERS seems out of place. We have a whole section of documentation about it, duplication is harmful and a lot of the text looks really out of date.

Sections 1, 2 and 4 look really, really old and not applicable to the modern process.

Section 3 is obvious but also we have build bots now.

Section 5 is a bit outdated (diff -u?!). But I like the part about factoring out shared code, so add that to process docs.

Section 6 is unnecessary?

Quoted 7 lines

Section 7 is covered by more appropriate docs.

---
 Documentation/process/6.Followthrough.rst |  7 ++
 MAINTAINERS                               | 80 +----------------------
 2 files changed, 9 insertions(+), 78 deletions(-)
Quoted 3 lines

This has been discussed in the past, I'm not sure why we've never done it. I totally agree, and will happily apply this unless somebody objects or beats me to it.

It looks good to me,

reviewer Reviewed-by on v1 1/1
#4 lore raw
In reply to Jakub Kicinski
Quoted 14 lines · Jakub Kicinski

Having "how to submit patches" in MAINTAINTERS seems out of place. We have a whole section of documentation about it, duplication is harmful and a lot of the text looks really out of date.

Sections 1, 2 and 4 look really, really old and not applicable to the modern process.

Section 3 is obvious but also we have build bots now.

Section 5 is a bit outdated (diff -u?!). But I like the part about factoring out shared code, so add that to process docs.

Section 6 is unnecessary?

Quoted 7 lines

Section 7 is covered by more appropriate docs.

---
 Documentation/process/6.Followthrough.rst |  7 ++
 MAINTAINERS                               | 80 +----------------------
 2 files changed, 9 insertions(+), 78 deletions(-)

Thanks.

Signature · 1 line
~Randy
maintainer Applied
#5 lore raw
In reply to Jakub Kicinski
Quoted 14 lines · Jakub Kicinski

Having "how to submit patches" in MAINTAINTERS seems out of place. We have a whole section of documentation about it, duplication is harmful and a lot of the text looks really out of date.

Sections 1, 2 and 4 look really, really old and not applicable to the modern process.

Section 3 is obvious but also we have build bots now.

Section 5 is a bit outdated (diff -u?!). But I like the part about factoring out shared code, so add that to process docs.

Section 6 is unnecessary?

Quoted 7 lines

Section 7 is covered by more appropriate docs.

---
 Documentation/process/6.Followthrough.rst |  7 ++
 MAINTAINERS                               | 80 +----------------------
 2 files changed, 9 insertions(+), 78 deletions(-)

Applied, thanks.

jon