Skip to contentSkip to conversation

regulator: set variables clkin_name and xin_name storage-class-specifier to static

PATCH New Tom Rix 1 participant 1 message Jul 2, 2023 Voltage and current regulator framework

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 regulator: set variables clkin_name and xin_name storage-class-specifier to static

smatch reports drivers/regulator/raa215300.c:41:12: warning: symbol
'clkin_name' was not declared. Should it be static?
drivers/regulator/raa215300.c:42:12: warning: symbol
'xin_name' was not declared. Should it be static?

These variables are only used in their defining file, so it should be static.

---
 drivers/regulator/raa215300.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/raa215300.c +2 -2
index 24a1c89f5dbc..d21c6c207226 100644
@@ -38,8 +38,8 @@
 #define RAA215300_REG_BLOCK_EN_RTC_EN	BIT(6)
 #define RAA215300_RTC_DEFAULT_ADDR	0x6f
 
-const char *clkin_name = "clkin";
-const char *xin_name = "xin";
+static const char *clkin_name = "clkin";
+static const char *xin_name = "xin";
 static struct clk *clk;
 
 static const struct regmap_config raa215300_regmap_config = {
Signature · 1 line
2.27.0