clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static
Subsystems (3)
PATCH 1/1 clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static
smatch reports drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
'ls1x_timer_lock' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
--- drivers/clocksource/timer-loongson1-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/timer-loongson1-pwm.c +1 -1
@@ -28,7 +28,7 @@#define CNTR_WIDTH 24 -DEFINE_RAW_SPINLOCK (ls1x_timer_lock); +static DEFINE_RAW_SPINLOCK (ls1x_timer_lock);struct ls1x_clocksource {void __iomem *reg_base;
Signature · 1 line
2.27.0
Quoted 7 lines
smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
'ls1x_timer_lock' was not declared. Should it be static?This variable is only used in its defining file, so it should be static.
Signed-off-by Tom Rix <[email protected]>
Quoted 18 lines
--- drivers/clocksource/timer-loongson1-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clocksource/timer-loongson1-pwm.c +1
-2@@ -28,7 +28,7 @@#define CNTR_WIDTH 24 -DEFINE_RAW_SPINLOCK (ls1x_timer_lock); +static DEFINE_RAW_SPINLOCK (ls1x_timer_lock);struct ls1x_clocksource {void __iomem *reg_base; --
Quoted 2 lines
2.27.0
--
Best regards,
Keguang Zhang
[tip: timers/core] clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static
In reply to Tom RixThe following commit has been merged into the timers/core branch of tip:
The following commit has been merged into the timers/core branch of tip:
Commit-ID: bd0f3aac47e8f618ceae0120d7b989378a7c45f0 Gitweb: https://git.kernel.org/tip/bd0f3aac47e8f618ceae0120d7b989378a7c45f0 Author: Tom Rix <[email protected]> AuthorDate: Sun, 02 Jul 2023 09:31:13 -04:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Fri, 18 Aug 2023 12:13:03 +02:00
clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static
smatch reports drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
'ls1x_timer_lock' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
--- drivers/clocksource/timer-loongson1-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/timer-loongson1-pwm.c +1 -1
@@ -28,7 +28,7 @@#define CNTR_WIDTH 24 -DEFINE_RAW_SPINLOCK (ls1x_timer_lock); +static DEFINE_RAW_SPINLOCK (ls1x_timer_lock);struct ls1x_clocksource {void __iomem *reg_base;