Skip to contentSkip to conversation

selftests/input: add tests for the EVIOCSCLOCKID ioctl

PATCH Superseded Dana Elfassy 2 participants 2 messages Jul 3, 2023 Kselftest

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/input: add tests for the EVIOCSCLOCKID ioctl

This patch introduces tests for the EVIOCSCLOCKID ioctl, for full coverage of the different clkids

---
This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/[email protected]/

 tools/testing/selftests/input/evioc-test.c | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
tools/testing/selftests/input/evioc-test.c +32 -0
index ad7b93fe39cf..81d5336d93ac 100644
@@ -234,4 +234,36 @@ TEST(eviocsrep_set_repeat_settings)
 	selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsclockid_set_clockid)
+{
+	struct selftest_uinput *uidev;
+	int clkid = 0;
+	int rc;
+
+	rc = selftest_uinput_create_device(&uidev, -1);
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+
+	// case CLOCK_REALTIME
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	// case CLOCK_MONOTONIC
+	clkid = 1;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	// case CLOCK_BOOTTIME
+	clkid = 7;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	// case default
+	clkid = -1;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(-1, rc);
+
+	selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
Signature · 1 line
2.41.0
#1 lore raw

Hi Dana,

Many thanks for the patch. Only a minor comment, see below.

Missatge de Dana Elfassy <[email protected]> del dia dl., 3 de jul. 2023 a les 10:18:

Quoted 17 lines

This patch introduces tests for the EVIOCSCLOCKID ioctl, for full coverage of the different clkids

---
This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/[email protected]/

 tools/testing/selftests/input/evioc-test.c | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
tools/testing/selftests/input/evioc-test.c +0 -0
index ad7b93fe39cf..81d5336d93ac 100644

tools/testing/selftests/input/evioc-test.c TEST(eviocsrep_set_repeat_settings) · line 240

Quoted 7 lines
tools/testing/selftests/input/evioc-test.c +4 -0
@@ -234,4 +234,36 @@ TEST(eviocsrep_set_repeat_settings)
        selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsclockid_set_clockid)
+{
+       struct selftest_uinput *uidev;
+       int clkid = 0;

instead of using "magic numbers" for all the CLOCK_* types I'd recommend to use the defined ones in include/uapi/linux/time.h, so you can use CLOCK_REALTIME,
CLOCK_MONOTONIC and CLOCK_BOOTTIME in the code.

Quoted 30 lines
tools/testing/selftests/input/evioc-test.c +28 -1
+       int rc;
+
+       rc = selftest_uinput_create_device(&uidev, -1);
+       ASSERT_EQ(0, rc);
+       ASSERT_NE(NULL, uidev);
+
+       // case CLOCK_REALTIME
+       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+       ASSERT_EQ(0, rc);
+
+       // case CLOCK_MONOTONIC
+       clkid = 1;
+       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+       ASSERT_EQ(0, rc);
+
+       // case CLOCK_BOOTTIME
+       clkid = 7;
+       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+       ASSERT_EQ(0, rc);
+
+       // case default
+       clkid = -1;
+       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+       ASSERT_EQ(-1, rc);
+
+       selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
--
Quoted 2 lines

2.41.0

Cheers,
Enric