perf: Replace strlcpy with strscpy
PATCH 1/1 perf: Replace strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
--- kernel/events/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/events/core.c +3 -3
@@ -8249,7 +8249,7 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event)unsigned int size;memset (comm,0 ,sizeof (comm)); -strlcpy (comm, comm_event->task->comm,sizeof (comm)); +strscpy (comm, comm_event->task->comm,sizeof (comm)); size =ALIGN (strlen (comm)+1 ,sizeof (u64)); comm_event->comm = comm;
@@ -8704,7 +8704,7 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) } cpy_name: -strlcpy (tmp, name,sizeof (tmp)); +strscpy (tmp, name,sizeof (tmp)); name = tmp; got_name:/*
@@ -9128,7 +9128,7 @@ void perf_event_ksymbol(u16 ksym_type, u64 addr, u32 len, bool unregister, ksym_type == PERF_RECORD_KSYMBOL_TYPE_UNKNOWN) goto err; -strlcpy (name, sym,KSYM_NAME_LEN ); +strscpy (name, sym,KSYM_NAME_LEN ); name_len =strlen (name) +1 ;while (!IS_ALIGNED (name_len,sizeof (u64))) name[name_len++] ='\0' ;
Signature · 1 line
2.41.0.255.g8b1d071c50-goog
Quoted 8 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.
Quoted 4 lines
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89Signed-off-by Azeem Shaikh <[email protected]>
Signature · 1 line
Kees Cook
Kees Cook
AppliedQuoted 9 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.[...]
Applied, thanks!
[1/1] perf: Replace strlcpy with strscpy
https://git.kernel.org/kees/c/c9732f1461f9
Best regards,
Signature · 1 line
Kees Cook