Skip to contentSkip to conversation

dt-bindings: clock: convert BCM53573 ILP clock to the json-schema

PATCH In review Rafał Miłecki 2 participants 2 messages Jul 7, 2023

Subsystems (2)
Device tree bindings Common clk
lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/1 dt-bindings: clock: convert BCM53573 ILP clock to the json-schema

From: Rafał Miłecki <[email protected]>

This helps validating DTS files.

Signed-off-by Rafał Miłecki <[email protected]>
---
 .../bindings/clock/brcm,bcm53573-ilp.txt      | 36 -------------
 .../bindings/clock/brcm,bcm53573-ilp.yaml     | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 36 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt
 create mode 100644 Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt deleted +0 -36
deleted file mode 100644
index 2ebb107331dd..000000000000
@@ -1,36 +0,0 @@
-Broadcom BCM53573 ILP clock
-===========================
-
-This binding uses the common clock binding:
-    Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-This binding is used for ILP clock (sometimes referred as "slow clock")
-on Broadcom BCM53573 devices using Cortex-A7 CPU.
-
-ILP's rate has to be calculated on runtime and it depends on ALP clock
-which has to be referenced.
-
-This clock is part of PMU (Power Management Unit), a Broadcom's device
-handing power-related aspects. Its node must be sub-node of the PMU
-device.
-
-Required properties:
-- compatible: "brcm,bcm53573-ilp"
-- clocks: has to reference an ALP clock
-- #clock-cells: should be <0>
-- clock-output-names: from common clock bindings, should contain clock
-		      name
-
-Example:
-
-pmu@18012000 {
-	compatible = "simple-mfd", "syscon";
-	reg = <0x18012000 0x00001000>;
-
-	ilp {
-		compatible = "brcm,bcm53573-ilp";
-		clocks = <&alp>;
-		#clock-cells = <0>;
-		clock-output-names = "ilp";
-	};
-};
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml new file +51 -0

51 lines not on this page · raw message

Signature · 1 line
2.35.3
maintainer
#1 lore raw
Quoted 35 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This helps validating DTS files.

Signed-off-by Rafał Miłecki <[email protected]>
---
 .../bindings/clock/brcm,bcm53573-ilp.txt      | 36 -------------
 .../bindings/clock/brcm,bcm53573-ilp.yaml     | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 36 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt
 create mode 100644 Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt deleted +0 -17
deleted file mode 100644
index 2ebb107331dd..000000000000
@@ -1,36 +0,0 @@
-Broadcom BCM53573 ILP clock
-===========================
-
-This binding uses the common clock binding:
-    Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-This binding is used for ILP clock (sometimes referred as "slow clock")
-on Broadcom BCM53573 devices using Cortex-A7 CPU.
-
-ILP's rate has to be calculated on runtime and it depends on ALP clock
-which has to be referenced.
-
-This clock is part of PMU (Power Management Unit), a Broadcom's device
-handing power-related aspects. Its node must be sub-node of the PMU
-device.
-
-Required properties:

Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt line 27

Quoted 10 lines
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt deleted +0 -10
-- compatible: "brcm,bcm53573-ilp"
-- clocks: has to reference an ALP clock
-- #clock-cells: should be <0>
-- clock-output-names: from common clock bindings, should contain clock
-		      name
-
-Example:
-
-pmu@18012000 {
-	compatible = "simple-mfd", "syscon";

Really, the binding for this block needs to be converted or added first. That means adding a specific compatible for the "pmu".

Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt line 34

Quoted 7 lines
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt deleted +0 -7
-	reg = <0x18012000 0x00001000>;
-
-	ilp {
-		compatible = "brcm,bcm53573-ilp";
-		clocks = <&alp>;
-		#clock-cells = <0>;
-		clock-output-names = "ilp";

And this binding is simple enough it could be part of the parent binding, but either way is fine.

Quoted 44 lines
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.txt deleted +0 -2
-	};
-};
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml new file +36 -0
new file mode 100644
index 000000000000..648f68a53119
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/brcm,bcm53573-ilp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM53573 ILP clock
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+description: |
+  This binding is used for ILP clock (sometimes referred as "slow clock")
+  on Broadcom BCM53573 devices using Cortex-A7 CPU.
+
+  ILP's rate has to be calculated on runtime and it depends on ALP clock
+  which has to be referenced.
+
+  This clock is part of PMU (Power Management Unit), a Broadcom's device
+  handing power-related aspects. Its node must be sub-node of the PMU
+  device.
+
+properties:
+  compatible:
+    const: brcm,bcm53573-ilp
+
+  clocks:
+    description: ALP clock
+    maxItems: 1
+
+  "#clock-cells":
+    const: 0
+
+  clock-output-names:
+    const: ilp
+

Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml line 46

Quoted 10 lines
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml new file +10 -0
+required:
+  - clocks
+  - "#clock-cells"
+  - clock-output-names
+
+additionalProperties: false
+
+examples:
+  - |
+    ilp {

clock-controller {

Quoted 8 lines
Documentation/devicetree/bindings/clock/brcm,bcm53573-ilp.yaml new file +5 -0
+      compatible = "brcm,bcm53573-ilp";
+      clocks = <&alp>;
+      #clock-cells = <0>;
+      clock-output-names = "ilp";
+    };
Signature · 1 line
2.35.3