Skip to contentSkip to conversation

dt-bindings: leds: Convert Panasonic AN30259A to DT schema

PATCH Superseded Rob Herring 3 participants 4 messages Jul 7, 2023 – Jul 10, 2023

Subsystems (2)
Device tree bindings LED

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: leds: Convert Panasonic AN30259A to DT schema

Convert the Panasonic AN30259A 3-channel LED controller binding to DT schema format.

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/leds/leds-an30259a.txt           | 55 ------------
 .../bindings/leds/panasonic,an30259a.yaml     | 84 +++++++++++++++++++
 2 files changed, 84 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-an30259a.txt
 create mode 100644 Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml
Documentation/devicetree/bindings/leds/leds-an30259a.txt deleted +0 -55
deleted file mode 100644
index cbd833906b2b..000000000000
@@ -1,55 +0,0 @@
-* Panasonic AN30259A 3-channel LED driver
-
-The AN30259A is a LED controller capable of driving three LEDs independently. It supports
-constant current output and sloping current output modes. The chip is connected over I2C.
-
-Required properties:
-	- compatible: Must be "panasonic,an30259a".
-	- reg: I2C slave address.
-	- #address-cells: Must be 1.
-	- #size-cells: Must be 0.
-
-Each LED is represented as a sub-node of the panasonic,an30259a node.
-
-Required sub-node properties:
-	- reg: Pin that the LED is connected to. Must be 1, 2, or 3.
-
-Optional sub-node properties:
-	- function :
-		see Documentation/devicetree/bindings/leds/common.txt
-	- color :
-		see Documentation/devicetree/bindings/leds/common.txt
-	- label :
-		see Documentation/devicetree/bindings/leds/common.txt (deprecated)
-	- linux,default-trigger :
-		see Documentation/devicetree/bindings/leds/common.txt
-
-Example:
-
-#include <dt-bindings/leds/common.h>
-
-led-controller@30 {
-	compatible = "panasonic,an30259a";
-	reg = <0x30>;
-	#address-cells = <1>;
-	#size-cells = <0>;
-
-	led@1 {
-		reg = <1>;
-		linux,default-trigger = "heartbeat";
-		function = LED_FUNCTION_INDICATOR;
-		color = <LED_COLOR_ID_RED>;
-	};
-
-	led@2 {
-		reg = <2>;
-		function = LED_FUNCTION_INDICATOR;
-		color = <LED_COLOR_ID_GREEN>;
-	};
-
-	led@3 {
-		reg = <3>;
-		function = LED_FUNCTION_INDICATOR;
-		color = <LED_COLOR_ID_BLUE>;
-	};
-};
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +84 -0

84 lines not on this page · raw message

Signature · 1 line
2.40.1
author maintainer
#1 lore raw
Quoted 6 lines · Rob Herring

Convert the Panasonic AN30259A 3-channel LED controller binding to DT schema format.

Signed-off-by Rob Herring <[email protected]>

---

[...]

Quoted 6 lines
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +0 -0
new file mode 100644
index 000000000000..f55f8c232bc6

Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml line 10

Quoted 10 lines
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +10 -0
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/panasonic,an30259a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Panasonic AN30259A 3-channel LED controller
+
+maintainers:
+  - Simon Shields <[email protected]>

Bounces. Will need someone else.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

Convert the Panasonic AN30259A 3-channel LED controller binding to DT schema format.

Signed-off-by Rob Herring <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>
Quoted 2 lines
 .../bindings/leds/leds-an30259a.txt           | 55 ------------
 .../bindings/leds/panasonic,an30259a.yaml     | 84 +++++++++++++++++++

...

Quoted 6 lines
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +0 -0
new file mode 100644
index 000000000000..f55f8c232bc6

Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml line 10

Quoted 10 lines
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +10 -0
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/panasonic,an30259a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Panasonic AN30259A 3-channel LED controller
+
+maintainers:
+  - Simon Shields <[email protected]>

Device is used in qcom-msm8974pro-samsung-klte.dts, so maybe its main authors would maintain this binding?

Iskren Chernev <[email protected]>
Daniele Debernardi <[email protected]>

Best regards,
Krzysztof

#3 lore raw
Quoted 35 lines · Krzysztof Kozlowski
Quoted 5 lines · Rob Herring

Convert the Panasonic AN30259A 3-channel LED controller binding to DT schema format.

Signed-off-by Rob Herring <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>
Quoted 2 lines
 .../bindings/leds/leds-an30259a.txt           | 55 ------------
 .../bindings/leds/panasonic,an30259a.yaml     | 84 +++++++++++++++++++

...

Quoted 6 lines
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +0 -0
new file mode 100644
index 000000000000..f55f8c232bc6

Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml line 10

Quoted 10 lines
Documentation/devicetree/bindings/leds/panasonic,an30259a.yaml new file +10 -0
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/panasonic,an30259a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Panasonic AN30259A 3-channel LED controller
+
+maintainers:
+  - Simon Shields <[email protected]>

Device is used in qcom-msm8974pro-samsung-klte.dts, so maybe its main authors would maintain this binding?

Quoted 1 line

Iskren Chernev <[email protected]>

I'll be happy to be listed as a maintainer of that binding.

Quoted 6 lines

Daniele Debernardi <[email protected]>

Best regards,
Krzysztof