Skip to contentSkip to conversation

drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM

PATCH Applied Marek Vasut 2 participants 2 messages Jul 9, 2023 – Aug 11, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM

The ULPS EXIT is initialized to 0xaf in downstream BSP as well as older revisions of this patchset, in newer revisions of the DSIM patchset it was left out and set to 0. Fix it.

Fixes 4d562c70c4dc ("drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support")

---
Cc: Andrzej Hajda <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Inki Dae <[email protected]>
Cc: Jagan Teki <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Marek Szyprowski <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/bridge/samsung-dsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/samsung-dsim.c +1 -1
index 9b7a00bafeaaa..7d8afbcf56ca4 100644
@@ -384,7 +384,7 @@ static const unsigned int imx8mm_dsim_reg_values[] = {
 	[RESET_TYPE] = DSIM_SWRST,
 	[PLL_TIMER] = 500,
 	[STOP_STATE_CNT] = 0xf,
-	[PHYCTRL_ULPS_EXIT] = 0,
+	[PHYCTRL_ULPS_EXIT] = DSIM_PHYCTRL_ULPS_EXIT(0xaf),
 	[PHYCTRL_VREG_LP] = 0,
 	[PHYCTRL_SLEW_UP] = 0,
 	[PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06),
Signature · 1 line
2.40.1
maintainer Applied
#1 lore raw
Quoted 5 lines · Marek Vasut

The ULPS EXIT is initialized to 0xaf in downstream BSP as well as older revisions of this patchset, in newer revisions of the DSIM patchset it was left out and set to 0. Fix it.

Applied, thanks!

[1/1] drm: bridge: samsung-dsim: Initialize ULPS EXIT for i.MX8M DSIM

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=192948f6a923

Rob