TIOCSTI: always enable for CAP_SYS_ADMIN
PATCH 1/1 TIOCSTI: always enable for CAP_SYS_ADMIN
83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled") broke BRLTTY's ability to simulate keypresses on the console, thus effectively breaking braille keyboards of blind users.
This restores the TIOCSTI feature for CAP_SYS_ADMIN processes, which BRLTTY is, thus fixing braille keyboards without re-opening the security issue.
Signed-off-by Samuel Thibault <[email protected]>
Acked-by Kees Cook <[email protected]>
Fixes 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")
drivers/tty/tty_io.c +1 -1
@@ -2276,7 +2276,7 @@ static int tiocsti(struct tty_struct *ttchar ch, mbz =0 ;struct tty_ldisc *ld; -if (!tty_legacy_tiocsti) +if (!tty_legacy_tiocsti && !capable (CAP_SYS_ADMIN ))return -EIO ;if ((current->signal->tty != tty) && !capable (CAP_SYS_ADMIN ))
Quoted 4 lines · Samuel Thibault
83efeeeb3d04("tty: Allow TIOCSTI to be disabled") broke BRLTTY's ability to simulate keypresses on the console, thus effectively breaking braille keyboards of blind users.
Quoted 8 lines
This restores the TIOCSTI feature for
CAP_SYS_ADMINprocesses, which BRLTTY is, thus fixing braille keyboards without re-opening the security issue.Signed-off-by Samuel Thibault <[email protected]>Acked-by Kees Cook <[email protected]>Fixes 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")
Acked-by Jiri Slaby <[email protected]>
thanks,
Signature · 2 lines
js suse labs