f2fs: don't handle error case of f2fs_compress_alloc_page()
Chao Yu
maintainerPATCH 1/1 f2fs: don't handle error case of f2fs_compress_alloc_page()
f2fs_compress_alloc_page() uses mempool to allocate memory, it never fail, don't handle error case in its callers.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/compress.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)
fs/f2fs/compress.c +1 -13
@@ -649,13 +649,8 @@ static int f2fs_compress_pages(struct compress_ctx *cc) goto destroy_compress_ctx; } -for (i =0 ; i < cc->nr_cpages; i++) { +for (i =0 ; i < cc->nr_cpages; i++) cc->cpages[i] =f2fs_compress_alloc_page (); -if (!cc->cpages[i]) { - ret = -ENOMEM ; - goto out_free_cpages; - } - } cc->rbuf =f2fs_vmap (cc->rpages, cc->cluster_size);if (!cc->rbuf) {
@@ -1574,8 +1569,6 @@ static int f2fs_prepare_decomp_mem(struct decompress_io_ctx *dic, } dic->tpages[i] =f2fs_compress_alloc_page (); -if (!dic->tpages[i]) -return -ENOMEM ; } dic->rbuf =f2fs_vmap (dic->tpages, dic->cluster_size);
@@ -1656,11 +1649,6 @@ struct decompress_io_ctx *f2fs_alloc_dic(struct compress_ctx *cc)struct page *page; page =f2fs_compress_alloc_page (); -if (!page) { - ret = -ENOMEM ; - goto out_free; - } -f2fs_set_compressed_page (page, cc->inode, start_idx + i +1 , dic); dic->cpages[i] = page;
Signature · 8 lines
2.40.1 _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 7 lines · On Mon, 10 Jul 2023 14:10:58 +0800 you wrote:
f2fs_compress_alloc_page()uses mempool to allocate memory, it never fail, don't handle error case in its callers.Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/compress.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)
Here is the summary with links:
- [f2fs-dev] f2fs: don't handle error case of f2fs_compress_alloc_page()
https://git.kernel.org/jaegeuk/f2fs/c/df19023418cd
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html