Skip to contentSkip to conversation

signal: remove duplicate include header in signal.c

PATCH In review [email protected] 2 participants 2 messages Jul 10, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 signal: remove duplicate include header in signal.c

From: Ye Xingchen <[email protected]>

linux/file.h is included more than once.

---
 kernel/signal.c | 1 -
 1 file changed, 1 deletion(-)
kernel/signal.c +0 -1
index 9a3ff8157ceb..b1da4e81bde6 100644
@@ -25,7 +25,6 @@
 #include <linux/mm.h>
 #include <linux/proc_fs.h>
 #include <linux/tty.h>
-#include <linux/file.h>
 #include <linux/binfmts.h>
 #include <linux/coredump.h>
 #include <linux/security.h>
Signature · 1 line
2.25.1
#1 lore raw
Quoted 3 lines · On 2023/7/10 15:23, [email protected] wrote:

From: Ye Xingchen <[email protected]>

linux/file.h is included more than once.

Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition. So what’s your concern about this?

Thanks, Haifeng.

Quoted 18 lines
---
 kernel/signal.c | 1 -
 1 file changed, 1 deletion(-)
kernel/signal.c +0 -1
index 9a3ff8157ceb..b1da4e81bde6 100644
@@ -25,7 +25,6 @@
 #include <linux/mm.h>
 #include <linux/proc_fs.h>
 #include <linux/tty.h>
-#include <linux/file.h>
 #include <linux/binfmts.h>
 #include <linux/coredump.h>
 #include <linux/security.h>