Skip to contentSkip to conversation

drm/i915: Allow panel drrs modes to have differing sync polarities

PATCH In review Vidya Srinivas 3 participants 9 messages Jul 11, 2023 – Jul 13, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Allow panel drrs modes to have differing sync polarities

v2: Add Jani Nikula's change for quirk for sync polarity

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +1 -1
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 			      DRM_MODE_FLAG_INTERLACE);
 
-	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS) && !fastset) {
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 				      DRM_MODE_FLAG_PHSYNC);
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
drivers/gpu/drm/i915/display/intel_panel.c +6 -4
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct intel_connector *connector,
 static bool is_alt_drrs_mode(const struct drm_display_mode *mode,
 			     const struct drm_display_mode *preferred_mode)
 {
-	return drm_mode_match(mode, preferred_mode,
-			      DRM_MODE_MATCH_TIMINGS |
-			      DRM_MODE_MATCH_FLAGS |
-			      DRM_MODE_MATCH_3D_FLAGS) &&
+	u32 sync_flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC |
+		DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+	return (mode->flags & ~sync_flags) == (preferred_mode->flags & ~sync_flags) &&
+		mode->hdisplay == preferred_mode->hdisplay &&
+		mode->vdisplay == preferred_mode->vdisplay &&
 		mode->clock != preferred_mode->clock;
 }
 
Signature · 1 line
2.33.0
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow panel drrs modes to have differing sync polarities

== Series Details ==

== Series Details ==

Series: drm/i915: Allow panel drrs modes to have differing sync polarities
URL : https://patchwork.freedesktop.org/series/120484/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13366 -> Patchwork_120484v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/index.html

Participating hosts (41 -> 39)
------------------------------

Missing (2): fi-snb-2520m fi-pnv-d510

Known issues
------------

Here are the changes found in Patchwork_120484v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-1115g4: [PASS][1] -> [FAIL][2] ([i915#7940])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/fi-tgl-1115g4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/fi-tgl-1115g4/igt@[email protected]
- bat-dg1-7: [PASS][3] -> [FAIL][4] ([i915#7691])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-dg1-7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-dg1-7/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8700k: [PASS][5] -> [FAIL][6] ([i915#7940])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/fi-cfl-8700k/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/fi-cfl-8700k/igt@[email protected]

* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][7] -> [DMESG-WARN][8] ([i915#7699])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-dg2-11/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-dg2-11/igt@i915_selftest@[email protected]
- bat-atsm-1: [PASS][9] -> [DMESG-FAIL][10] ([i915#7699] / [i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-atsm-1/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-atsm-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-mtlp-8: [PASS][11] -> [DMESG-WARN][12] ([i915#6367])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-mtlp-8/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-mtlp-8/igt@i915_selftest@[email protected]
- bat-rpls-1: NOTRUN -> [DMESG-WARN][13] ([i915#6367])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][14] ([i915#6687] / [i915#7978] / [i915#8668])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-rpls-1/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-cfl-8700k: [FAIL][15] ([i915#7940]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/fi-cfl-8700k/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/fi-cfl-8700k/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [FAIL][17] ([i915#7940]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/fi-cfl-8109u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/fi-cfl-8109u/igt@[email protected]
- fi-tgl-1115g4: [FAIL][19] ([i915#7940]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/fi-tgl-1115g4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [FAIL][21] ([i915#7940]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/fi-skl-guc/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/fi-skl-guc/igt@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][23] ([i915#7920] / [i915#7982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-rpls-1/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][25] ([i915#6367]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-mtlp-6/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-mtlp-6/igt@i915_selftest@[email protected]
- bat-rpls-2: [DMESG-WARN][27] ([i915#6367]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-rpls-2/igt@i915_selftest@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-rpls-2/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@core_auth@basic-auth:
- bat-adlp-11: [ABORT][29] ([i915#8011]) -> [ABORT][30] ([i915#4423] / [i915#8011])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-adlp-11/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-adlp-11/igt@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [SKIP][31] ([i915#1072]) -> [ABORT][32] ([i915#8434] / [i915#8442] / [i915#8668])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html

[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668

Build changes
-------------

* Linux: CI_DRM_13366 -> Patchwork_120484v1

CI-20190529: 20190529
CI_DRM_13366: e547f03913976a1adcb823ed64d803284fdfa6a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7378: e78963553e05a2413cf735824517547b2bb19936 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120484v1: e547f03913976a1adcb823ed64d803284fdfa6a2 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

5b9b75a69a11 drm/i915: Allow panel drrs modes to have differing sync polarities

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/index.html

#2 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Allow panel drrs modes to have differing sync polarities

In reply to Vidya Srinivas
== Series Details ==

== Series Details ==

Series: drm/i915: Allow panel drrs modes to have differing sync polarities
URL : https://patchwork.freedesktop.org/series/120484/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13366_full -> Patchwork_120484v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_120484v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_120484v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_120484v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-1:
- shard-glk: [PASS][1] -> [ABORT][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-glk1/igt@kms_atomic_transition@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk7/igt@kms_atomic_transition@[email protected]
- shard-rkl: NOTRUN -> [ABORT][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-7/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [ABORT][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-6/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-vga-1:
- shard-snb: [PASS][5] -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-snb4/igt@kms_atomic_transition@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb4/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [DMESG-WARN][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-7/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [DMESG-WARN][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-6/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-b-vga-1:
- shard-snb: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-snb4/igt@kms_atomic_transition@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb4/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-dp-1:
- shard-apl: [PASS][11] -> [ABORT][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-apl4/igt@kms_atomic_transition@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-apl3/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1:
- shard-tglu: [PASS][13] -> [ABORT][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-tglu-9/igt@kms_atomic_transition@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-7/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-2:
- shard-rkl: [PASS][15] -> [ABORT][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-6/igt@kms_atomic_transition@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-4/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-3:
- shard-dg2: [PASS][17] -> [ABORT][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-8/igt@kms_atomic_transition@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-8/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-vga-1:
- shard-snb: NOTRUN -> [ABORT][19]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb7/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-b-hdmi-a-1:
- shard-tglu: [PASS][20] -> [DMESG-WARN][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-tglu-9/igt@kms_atomic_transition@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-7/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-b-hdmi-a-2:
- shard-rkl: [PASS][22] -> [DMESG-WARN][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-6/igt@kms_atomic_transition@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-4/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-b-hdmi-a-3:
- shard-dg2: [PASS][24] -> [DMESG-WARN][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-8/igt@kms_atomic_transition@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-8/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-b-vga-1:
- shard-snb: NOTRUN -> [DMESG-WARN][26]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb7/igt@kms_atomic_transition@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-3:
- {shard-dg1}: NOTRUN -> [ABORT][27] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg1-13/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-b-hdmi-a-3:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][28] +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg1-13/igt@kms_atomic_transition@[email protected]

Known issues
------------

Here are the changes found in Patchwork_120484v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [PASS][29] -> [FAIL][30] ([i915#7742])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-1/igt@drm_fdinfo@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-1/igt@drm_fdinfo@[email protected]

* igt@gem_exec_balancer@hang:
- shard-mtlp: [PASS][31] -> [ABORT][32] ([i915#8104])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][33] -> [FAIL][34] ([i915#2846])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-glk3/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk8/igt@[email protected]

* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][35] -> [FAIL][36] ([i915#2842]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-4/igt@gem_exec_fair@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-wc-cpu:
- shard-mtlp: NOTRUN -> [SKIP][37] ([i915#3281]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-1/igt@[email protected]

* igt@gem_exec_schedule@deep@vcs1:
- shard-mtlp: [PASS][38] -> [FAIL][39] ([i915#8606])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-5/igt@gem_exec_schedule@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-8/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_whisper@basic-normal:
- shard-mtlp: [PASS][40] -> [FAIL][41] ([i915#6363]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-1/igt@[email protected]

* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-tglu: NOTRUN -> [SKIP][42] ([i915#4270])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@[email protected]

* igt@gen7_exec_parse@basic-offset:
- shard-tglu: NOTRUN -> [SKIP][43] ([fdo#109289]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271]) +125 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb7/igt@[email protected]

* igt@gen9_exec_parse@batch-zero-length:
- shard-mtlp: NOTRUN -> [SKIP][45] ([i915#2856])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@[email protected]

* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-mtlp: [PASS][46] -> [FAIL][47] ([i915#8691])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-4/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-8/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-rkl: [PASS][48] -> [SKIP][49] ([i915#1937])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-7/igt@i915_pm_lpsp@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-2/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [PASS][50] -> [SKIP][51] ([i915#1397]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-1/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-12/igt@[email protected]

* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [PASS][52] -> [SKIP][53] ([i915#1397]) +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-4/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-7/igt@[email protected]

* igt@i915_query@test-query-geometry-subslices:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#5723])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-tglu: NOTRUN -> [SKIP][55] ([fdo#111615] / [i915#5286])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-mtlp: [PASS][56] -> [FAIL][57] ([i915#3743])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#3886]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk8/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_mtl_rc_ccs_cc:
- shard-tglu: NOTRUN -> [SKIP][59] ([i915#5354] / [i915#6095]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_mtl_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs_cc:
- shard-tglu: NOTRUN -> [SKIP][60] ([i915#3689] / [i915#5354] / [i915#6095])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][61] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs.html

* igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#6095])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-3/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_cdclk@mode-transition@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#4087] / [i915#7213]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-12/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode:
- shard-mtlp: NOTRUN -> [SKIP][64] ([i915#7828])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@[email protected]

* igt@kms_color@deep-color:
- shard-dg2: NOTRUN -> [SKIP][65] ([i915#3555])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-5/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#7118]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-5/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-tglu: NOTRUN -> [SKIP][67] ([i915#6944] / [i915#7116] / [i915#7118])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#2346])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-glk8/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk1/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][70] ([i915#3804])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-2/igt@kms_dither@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-mtlp: [PASS][71] -> [FAIL][72] ([i915#4767])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-8/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-apl6/igt@[email protected]

* igt@kms_flip@dpms-vs-vblank-race@a-edp1:
- shard-mtlp: [PASS][74] -> [DMESG-WARN][75] ([i915#1982]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-2/igt@kms_flip@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-hdmi-a3:
- shard-dg2: [PASS][76] -> [FAIL][77] ([fdo#103375] / [i915#6121]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-8/igt@kms_flip@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-8/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@b-vga1:
- shard-snb: NOTRUN -> [DMESG-WARN][78] ([i915#8841])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-tglu: NOTRUN -> [SKIP][79] ([fdo#109280]) +5 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-tglu: NOTRUN -> [SKIP][80] ([fdo#110189]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#8708])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move:
- shard-mtlp: NOTRUN -> [SKIP][82] ([i915#1825])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271]) +53 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_plane_lowres@tiling-yf:
- shard-tglu: NOTRUN -> [SKIP][84] ([i915#3555])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#5176]) +7 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][86] ([i915#5176]) +9 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][87] ([i915#5235]) +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-2/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#5235]) +7 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-glk: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk8/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2437])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk8/igt@[email protected]

* igt@sysfs_heartbeat_interval@nopreempt@vcs1:
- shard-mtlp: [PASS][91] -> [FAIL][92] ([i915#6015])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-4/igt@sysfs_heartbeat_interval@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-8/igt@sysfs_heartbeat_interval@[email protected]

* igt@v3d/v3d_submit_csd@bad-perfmon:
- shard-tglu: NOTRUN -> [SKIP][93] ([fdo#109315] / [i915#2575]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@v3d/[email protected]

* igt@v3d/v3d_submit_csd@multi-and-single-sync:
- shard-mtlp: NOTRUN -> [SKIP][94] ([i915#2575])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@v3d/[email protected]

* igt@vc4/vc4_perfmon@create-single-perfmon:
- shard-tglu: NOTRUN -> [SKIP][95] ([i915#2575])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@vc4/[email protected]

#### Possible fixes ####

* igt@gem_barrier_race@remote-request@rcs0:
- shard-tglu: [ABORT][96] ([i915#8211] / [i915#8234]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-tglu-8/igt@gem_barrier_race@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@gem_barrier_race@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][98] ([i915#6268]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-tglu-9/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-8/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- shard-apl: [ABORT][100] ([i915#180]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-apl2/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-apl6/igt@[email protected]

* igt@gem_exec_balancer@full-pulse:
- shard-dg2: [FAIL][102] ([i915#6032]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-6/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-7/igt@[email protected]

* igt@gem_exec_endless@dispatch@vcs0:
- shard-tglu: [TIMEOUT][104] ([i915#3778] / [i915#7941]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-tglu-8/igt@gem_exec_endless@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-5/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][106] ([i915#2842]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-apl7/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-apl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [FAIL][108] ([i915#2842]) -> [PASS][109] +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-7/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-contexts:
- shard-mtlp: [FAIL][110] ([i915#6363]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-8/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-6/igt@[email protected]

* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-mtlp: [TIMEOUT][112] ([i915#7392]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-4/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-8/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-dg2: [FAIL][114] ([fdo#103375] / [i915#6121]) -> [PASS][115] +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-5/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-12/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [DMESG-WARN][116] ([i915#7061]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-11/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-11/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-dg1}: [FAIL][118] ([i915#3591]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg1-17/igt@i915_pm_rc6_residency@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg1-17/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_pm_rpm@basic-rte:
- shard-tglu: [FAIL][120] ([i915#7940]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-tglu-7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-tglu-6/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-rkl: [SKIP][122] ([i915#1397]) -> [PASS][123] +3 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-7/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-2/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- {shard-dg1}: [FAIL][124] ([i915#7940]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg1-16/igt@i915_pm_rpm@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg1-19/igt@i915_pm_rpm@[email protected]

* igt@i915_pm_rpm@i2c:
- shard-dg2: [FAIL][126] ([i915#8717]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-5/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][128] ([i915#1397]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg1-19/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg1-17/igt@[email protected]

* igt@i915_selftest@live@gt_mocs:
- shard-mtlp: [DMESG-FAIL][130] ([i915#7059]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-3/igt@i915_selftest@live@gt_mocs.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@slpc:
- shard-mtlp: [DMESG-WARN][132] ([i915#6367]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-3/igt@i915_selftest@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@i915_selftest@[email protected]

* igt@i915_selftest@mock@fence:
- shard-snb: [ABORT][134] -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-snb7/igt@i915_selftest@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-snb6/igt@i915_selftest@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-mtlp: [FAIL][136] ([i915#5138]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-6/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-mtlp: [FAIL][138] ([i915#3743]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][140] ([i915#2346]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- shard-dg2: [FAIL][142] ([i915#6880]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-6/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-8/igt@[email protected]

* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][144] ([i915#7484]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-7/igt@perf@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-8/igt@perf@[email protected]

* igt@perf@stress-open-close@0-rcs0:
- shard-glk: [ABORT][146] ([i915#5213] / [i915#7941]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-glk3/igt@perf@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-glk8/igt@perf@[email protected]

#### Warnings ####

* igt@kms_content_protection@mei_interface:
- shard-dg2: [SKIP][148] ([i915#7118]) -> [SKIP][149] ([i915#7118] / [i915#7162])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-1/igt@kms_content_protection@mei_interface.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-12/igt@kms_content_protection@mei_interface.html

* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][150] ([i915#3955]) -> [SKIP][151] ([fdo#110189] / [i915#3955])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-7/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-1/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][152] ([fdo#109285] / [i915#4098]) -> [SKIP][153] ([fdo#109285])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-rkl-1/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-rkl-7/igt@[email protected]

* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [INCOMPLETE][154] ([i915#5493]) -> [CRASH][155] ([i915#7331])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-dg2-5/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-dg2-6/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html

* igt@sysfs_preempt_timeout@timeout@vecs0:
- shard-mtlp: [TIMEOUT][156] ([i915#7947]) -> [ABORT][157] ([i915#8521])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13366/shard-mtlp-5/igt@sysfs_preempt_timeout@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/shard-mtlp-2/igt@sysfs_preempt_timeout@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6015]: https://gitlab.freedesktop.org/drm/intel/issues/6015
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6363]: https://gitlab.freedesktop.org/drm/intel/issues/6363
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7947]: https://gitlab.freedesktop.org/drm/intel/issues/7947
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8104]: https://gitlab.freedesktop.org/drm/intel/issues/8104
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8521]: https://gitlab.freedesktop.org/drm/intel/issues/8521
[i915#8606]: https://gitlab.freedesktop.org/drm/intel/issues/8606
[i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8717]: https://gitlab.freedesktop.org/drm/intel/issues/8717
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841

Build changes
-------------

* Linux: CI_DRM_13366 -> Patchwork_120484v1

CI-20190529: 20190529
CI_DRM_13366: e547f03913976a1adcb823ed64d803284fdfa6a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7378: e78963553e05a2413cf735824517547b2bb19936 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120484v1: e547f03913976a1adcb823ed64d803284fdfa6a2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120484v1/index.html

#3 lore raw
In reply to Vidya Srinivas
Quoted 1 line · Vidya Srinivas

v2: Add Jani Nikula's change for quirk for sync polarity

This was a quick hack suggestion to try. If it works, I think it works by concidence, because a fastset won't update the sync flags in TRANS_DDI_FUNC_CTL register. Did not check whether they can even be updated while the transcoder is enabled.

Quoted 3 lines

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

It would be useful to have a bug report at fdo gitlab with the EDID attached.

BR,
Jani.

Quoted 38 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +1 -1
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 			      DRM_MODE_FLAG_INTERLACE);
 
-	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS) && !fastset) {
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 				      DRM_MODE_FLAG_PHSYNC);
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
drivers/gpu/drm/i915/display/intel_panel.c +6 -4
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct intel_connector *connector,
 static bool is_alt_drrs_mode(const struct drm_display_mode *mode,
 			     const struct drm_display_mode *preferred_mode)
 {
-	return drm_mode_match(mode, preferred_mode,
-			      DRM_MODE_MATCH_TIMINGS |
-			      DRM_MODE_MATCH_FLAGS |
-			      DRM_MODE_MATCH_3D_FLAGS) &&
+	u32 sync_flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC |
+		DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+	return (mode->flags & ~sync_flags) == (preferred_mode->flags & ~sync_flags) &&
+		mode->hdisplay == preferred_mode->hdisplay &&
+		mode->vdisplay == preferred_mode->vdisplay &&
 		mode->clock != preferred_mode->clock;
 }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#4 lore raw
Quoted 19 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Tuesday, July 11, 2023 9:34 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Cc: [email protected]; Srinivas, Vidya <[email protected]>
Subject: Re: [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

Quoted 1 line · Vidya Srinivas

v2: Add Jani Nikula's change for quirk for sync polarity

This was a quick hack suggestion to try. If it works, I think it works by concidence, because a fastset won't update the sync flags in TRANS_DDI_FUNC_CTL register. Did not check whether they can even be updated while the transcoder is enabled.

Quoted 5 lines
Quoted 3 lines

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

It would be useful to have a bug report at fdo gitlab with the EDID attached.

Hello Jani,
I have requested gitlab with EDID attached https://gitlab.freedesktop.org/drm/intel/-/issues/8851
Kindly have a check please. Thank you very much.

Regards
Vidya

Quoted 53 lines

BR,
Jani.

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct

Quoted 11 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct

intel_crtc_state *current_config,

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct intel_crtc_state *current_config,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -1
 	PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 			      DRM_MODE_FLAG_INTERLACE);
 
-	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)

&& !fastset)

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector · line 112

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
+{
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 				      DRM_MODE_FLAG_PHSYNC);
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct intel_connector
 *connector,  static bool is_alt_drrs_mode(const struct drm_display_mode

*mode,

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector, · line 113

Quoted 1 line
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
 			     const struct drm_display_mode *preferred_mode)

{

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_panel.c +1 -4
-	return drm_mode_match(mode, preferred_mode,
-			      DRM_MODE_MATCH_TIMINGS |
-			      DRM_MODE_MATCH_FLAGS |
-			      DRM_MODE_MATCH_3D_FLAGS) &&
+	u32 sync_flags = DRM_MODE_FLAG_PHSYNC |

DRM_MODE_FLAG_NHSYNC |

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +3 -0
+		DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+	return (mode->flags & ~sync_flags) == (preferred_mode->flags &

~sync_flags) &&

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +2 -0
+		mode->hdisplay == preferred_mode->hdisplay &&
+		mode->vdisplay == preferred_mode->vdisplay &&
 		mode->clock != preferred_mode->clock;  }

--
Jani Nikula, Intel Open Source Graphics Center

#5 lore raw
In reply to Jani Nikula
Quoted 7 lines · Jani Nikula
Quoted 1 line · Vidya Srinivas

v2: Add Jani Nikula's change for quirk for sync polarity

This was a quick hack suggestion to try. If it works, I think it works by concidence, because a fastset won't update the sync flags in TRANS_DDI_FUNC_CTL register. Did not check whether they can even be updated while the transcoder is enabled.

Bspec 49198 seems to indicate TRANS_DDI_FUNC_CTL can be changed without a full mode set.

The sync polarity still needs to be modified in the ->update_pipe() hooks.

BR,
Jani.

Quoted 50 lines
Quoted 4 lines

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

It would be useful to have a bug report at fdo gitlab with the EDID attached.

BR,
Jani.

Quoted 38 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +1 -1
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 			      DRM_MODE_FLAG_INTERLACE);
 
-	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS) && !fastset) {
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 				      DRM_MODE_FLAG_PHSYNC);
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
drivers/gpu/drm/i915/display/intel_panel.c +6 -4
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct intel_connector *connector,
 static bool is_alt_drrs_mode(const struct drm_display_mode *mode,
 			     const struct drm_display_mode *preferred_mode)
 {
-	return drm_mode_match(mode, preferred_mode,
-			      DRM_MODE_MATCH_TIMINGS |
-			      DRM_MODE_MATCH_FLAGS |
-			      DRM_MODE_MATCH_3D_FLAGS) &&
+	u32 sync_flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC |
+		DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+	return (mode->flags & ~sync_flags) == (preferred_mode->flags & ~sync_flags) &&
+		mode->hdisplay == preferred_mode->hdisplay &&
+		mode->vdisplay == preferred_mode->vdisplay &&
 		mode->clock != preferred_mode->clock;
 }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#6 lore raw
Quoted 19 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Wednesday, July 12, 2023 1:44 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

Quoted 7 lines · Jani Nikula
Quoted 1 line · Vidya Srinivas

v2: Add Jani Nikula's change for quirk for sync polarity

This was a quick hack suggestion to try. If it works, I think it works by concidence, because a fastset won't update the sync flags in TRANS_DDI_FUNC_CTL register. Did not check whether they can even be updated while the transcoder is enabled.

Quoted 4 lines

Bspec 49198 seems to indicate TRANS_DDI_FUNC_CTL can be changed without a full mode set.

The sync polarity still needs to be modified in the ->update_pipe() hooks.

Hello Jani,

Thank you very much. Apart from sync polarity, VRR panel is doing full modeset between refresh rates 165 to 60Hz due to vrr.vmin, vrr.vmax, vrr.flipline and vrr.guardband mismatch. Can VRR panel do seamless fastset between 165Hz and 60Hz? Kindly let me know. Thank you.

Regards
Vidya

Quoted 66 lines

BR,
Jani.

Quoted 17 lines
Quoted 4 lines

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

It would be useful to have a bug report at fdo gitlab with the EDID attached.

BR,
Jani.

Quoted 5 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
Quoted 6 lines

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct

intel_crtc_state *current_config,

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct intel_crtc_state *current_config,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -1
 	PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 			      DRM_MODE_FLAG_INTERLACE);
 
-	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)

&&

Quoted 11 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector · line 112

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
+!fastset) {
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
 				      DRM_MODE_FLAG_PHSYNC);
 		PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct intel_connector
 *connector,  static bool is_alt_drrs_mode(const struct drm_display_mode

*mode,

Quoted 1 line

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector, · line 113

Quoted 1 line
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
 			     const struct drm_display_mode *preferred_mode)

{

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_panel.c +1 -4
-	return drm_mode_match(mode, preferred_mode,
-			      DRM_MODE_MATCH_TIMINGS |
-			      DRM_MODE_MATCH_FLAGS |
-			      DRM_MODE_MATCH_3D_FLAGS) &&
+	u32 sync_flags = DRM_MODE_FLAG_PHSYNC |

DRM_MODE_FLAG_NHSYNC |

Quoted 3 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +3 -0
+		DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+	return (mode->flags & ~sync_flags) == (preferred_mode->flags &

~sync_flags) &&

Quoted 3 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +2 -0
+		mode->hdisplay == preferred_mode->hdisplay &&
+		mode->vdisplay == preferred_mode->vdisplay &&
 		mode->clock != preferred_mode->clock;  }

--
Jani Nikula, Intel Open Source Graphics Center

#7 lore raw
Quoted 20 lines · Vidya
Quoted 20 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Wednesday, July 12, 2023 1:44 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

Quoted 7 lines · Jani Nikula
Quoted 1 line · Vidya Srinivas

v2: Add Jani Nikula's change for quirk for sync polarity

This was a quick hack suggestion to try. If it works, I think it works by concidence, because a fastset won't update the sync flags in TRANS_DDI_FUNC_CTL register. Did not check whether they can even be updated while the transcoder is enabled.

Bspec 49198 seems to indicate TRANS_DDI_FUNC_CTL can be changed without a full mode set.

Quoted 8 lines
Quoted 1 line

The sync polarity still needs to be modified in the ->update_pipe() hooks.

Hello Jani,

Thank you very much. Apart from sync polarity, VRR panel is doing full modeset between refresh rates 165 to 60Hz due to vrr.vmin, vrr.vmax, vrr.flipline and vrr.guardband mismatch. Can VRR panel do seamless fastset between 165Hz and 60Hz? Kindly let me know. Thank you.

I think it should be possible, even if the driver does not handle it properly atm.

Not sure if it can be combined with VRR itself. I guess typically you'd change the refresh rate instead of fastset when you're using VRR, but if you're not using VRR, would be great to be able to have DRRS and fastsets between the modes.

BR,
Jani.

Quoted 69 lines

Regards
Vidya

Quoted 66 lines

BR,
Jani.

Quoted 17 lines
Quoted 4 lines

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

It would be useful to have a bug report at fdo gitlab with the EDID attached.

BR,
Jani.

Quoted 5 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
Quoted 6 lines

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct

intel_crtc_state *current_config,

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct intel_crtc_state *current_config,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -1
   PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
                         DRM_MODE_FLAG_INTERLACE);
 
-  if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+  if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)

&&

Quoted 11 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector · line 112

Quoted 11 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
+!fastset) {
           PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
                                 DRM_MODE_FLAG_PHSYNC);
           PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct intel_connector
 *connector,  static bool is_alt_drrs_mode(const struct drm_display_mode

*mode,

Quoted 1 line

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector, · line 113

Quoted 1 line
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
                        const struct drm_display_mode *preferred_mode)

{

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_panel.c +1 -4
-  return drm_mode_match(mode, preferred_mode,
-                        DRM_MODE_MATCH_TIMINGS |
-                        DRM_MODE_MATCH_FLAGS |
-                        DRM_MODE_MATCH_3D_FLAGS) &&
+  u32 sync_flags = DRM_MODE_FLAG_PHSYNC |

DRM_MODE_FLAG_NHSYNC |

Quoted 3 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +3 -0
+          DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+  return (mode->flags & ~sync_flags) == (preferred_mode->flags &

~sync_flags) &&

Quoted 3 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +2 -0
+          mode->hdisplay == preferred_mode->hdisplay &&
+          mode->vdisplay == preferred_mode->vdisplay &&
           mode->clock != preferred_mode->clock;  }

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#8 lore raw
Quoted 42 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Thursday, July 13, 2023 6:39 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: RE: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

Quoted 20 lines · Vidya
Quoted 20 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Wednesday, July 12, 2023 1:44 PM
To: Srinivas, Vidya <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

Quoted 7 lines · Jani Nikula
Quoted 1 line · Vidya Srinivas

v2: Add Jani Nikula's change for quirk for sync polarity

This was a quick hack suggestion to try. If it works, I think it works by concidence, because a fastset won't update the sync flags in TRANS_DDI_FUNC_CTL register. Did not check whether they can even be updated while the transcoder is enabled.

Bspec 49198 seems to indicate TRANS_DDI_FUNC_CTL can be changed without a full mode set.

Quoted 6 lines
Quoted 1 line

The sync polarity still needs to be modified in the ->update_pipe() hooks.

Hello Jani,

Thank you very much. Apart from sync polarity, VRR panel is doing full modeset between refresh rates 165 to 60Hz due to vrr.vmin, vrr.vmax,

vrr.flipline and vrr.guardband mismatch.

Quoted 1 line

Can VRR panel do seamless fastset between 165Hz and 60Hz? Kindly let me

know.

Quoted 1 line

Thank you.

Quoted 7 lines

I think it should be possible, even if the driver does not handle it properly atm.

Not sure if it can be combined with VRR itself. I guess typically you'd change the refresh rate instead of fastset when you're using VRR, but if you're not using VRR, would be great to be able to have DRRS and fastsets between the modes.

Hello Jani,

Thank you very much for the inputs.

Regards
Vidya

Quoted 78 lines

BR,
Jani.

Quoted 71 lines

Regards
Vidya

Quoted 68 lines

BR,
Jani.

Quoted 17 lines
Quoted 4 lines

CC: Jani Nikula <[email protected]>
Credits-to: Jani Nikula <[email protected]>

It would be useful to have a bug report at fdo gitlab with the EDID attached.

BR,
Jani.

Quoted 5 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/i915/display/intel_panel.c   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)
Quoted 6 lines

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 43cba98f7753..088b45e032aa 100644
@@ -5234,7 +5234,7 @@ intel_pipe_config_compare(const struct

intel_crtc_state *current_config,

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_display.c intel_pipe_config_compare(const struct intel_crtc_state *current_config,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -1
   PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
                         DRM_MODE_FLAG_INTERLACE);
 
-  if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)) {
+  if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS)

&&

Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +1 -0
+!fastset) {
           PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
                                 DRM_MODE_FLAG_PHSYNC);
           PIPE_CONF_CHECK_FLAGS(hw.adjusted_mode.flags,
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_panel.c +0 -0
index 9232a305b1e6..b9eeaedabd22 100644
@@ -112,10 +112,12 @@ intel_panel_fixed_mode(struct

intel_connector *connector, static bool is_alt_drrs_mode(const struct drm_display_mode

*mode,

Quoted 2 lines
Quoted 2 lines

const struct drm_display_mode
*preferred_mode)

{

Quoted 5 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_panel.c +1 -4
-  return drm_mode_match(mode, preferred_mode,
-                        DRM_MODE_MATCH_TIMINGS |
-                        DRM_MODE_MATCH_FLAGS |
-                        DRM_MODE_MATCH_3D_FLAGS) &&
+  u32 sync_flags = DRM_MODE_FLAG_PHSYNC |

DRM_MODE_FLAG_NHSYNC |

Quoted 3 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +3 -0
+          DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC;
+
+  return (mode->flags & ~sync_flags) == (preferred_mode->flags &

~sync_flags) &&

Quoted 3 lines

drivers/gpu/drm/i915/display/intel_panel.c intel_panel_fixed_mode(struct intel_connector *connector,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_panel.c +2 -0
+          mode->hdisplay == preferred_mode->hdisplay &&
+          mode->vdisplay == preferred_mode->vdisplay &&
           mode->clock != preferred_mode->clock;  }

--
Jani Nikula, Intel Open Source Graphics Center

--
Jani Nikula, Intel Open Source Graphics Center