sched/topology: Align group flags when removing degenerate domain
PATCH 1/1 sched/topology: Align group flags when removing degenerate domain
The flags of the child of a given scheduling domain are used to initialize the flags of its scheduling groups. When the child of a scheduling domain is degenerated, the flags of its local scheduling group need to be updated to align with the flags of its new child domain.
The flag SD_SHARE_CPUCAPACITY was aligned in
Commit bf2dc42d6beb ("sched/topology: Propagate SMT flags when removing degenerate domain"). Further generalize this alignment so other flags can be used later, such as in cluster-based task wakeup. [1]
--- kernel/sched/topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/sched/topology.c +1 -2
@@ -722,8 +722,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)if (parent->parent) { parent->parent->child = tmp; -if (tmp->flags &SD_SHARE_CPUCAPACITY ) - parent->parent->groups->flags |=SD_SHARE_CPUCAPACITY ; + parent->parent->groups->flags = tmp->flags; }/*
Signature · 1 line
2.25.1
Quoted 24 lines · Chen Yu
The flags of the child of a given scheduling domain are used to initialize the flags of its scheduling groups. When the child of a scheduling domain is degenerated, the flags of its local scheduling group need to be updated to align with the flags of its new child domain.
The flag
SD_SHARE_CPUCAPACITYwas aligned in
Commitbf2dc42d6beb("sched/topology: Propagate SMT flags when removing degenerate domain"). Further generalize this alignment so other flags can be used later, such as in cluster-based task wakeup. [1]Suggested-by Ricardo Neri <[email protected]>Reported-by Yicong Yang <[email protected]>Signed-off-by Chen Yu <[email protected]>--- kernel/sched/topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)kernel/sched/topology.c +0
-0
kernel/sched/topology.c cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu) · line 728
Quoted 9 lines
kernel/sched/topology.c +1
-2@@ -722,8 +722,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)if (parent->parent) { parent->parent->child = tmp; -if (tmp->flags &SD_SHARE_CPUCAPACITY ) - parent->parent->groups->flags |=SD_SHARE_CPUCAPACITY ; + parent->parent->groups->flags = tmp->flags; }/*
Quoted 9 lines · Chen Yu
The flags of the child of a given scheduling domain are used to initialize the flags of its scheduling groups. When the child of a scheduling domain is degenerated, the flags of its local scheduling group need to be updated to align with the flags of its new child domain.
The flag
SD_SHARE_CPUCAPACITYwas aligned in
Commitbf2dc42d6beb("sched/topology: Propagate SMT flags when removing degenerate domain"). Further generalize this alignment so other flags can be used later, such as in cluster-based task wakeup. [1]
Currently I only update the cluster flags on my current testing branch. It'll be even better to align all flags for possible usage. Will rebase on this one.
Quoted 6 lines
Suggested-by Ricardo Neri <[email protected]>Reported-by Yicong Yang <[email protected]>Signed-off-by Chen Yu <[email protected]>
Quoted 19 lines
--- kernel/sched/topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)kernel/sched/topology.c +1
-2@@ -722,8 +722,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)if (parent->parent) { parent->parent->child = tmp; -if (tmp->flags &SD_SHARE_CPUCAPACITY ) - parent->parent->groups->flags |=SD_SHARE_CPUCAPACITY ; + parent->parent->groups->flags = tmp->flags; }/*
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 4efcc8bc7e08c09c58a2f5cbc2096fbda5b7cf5e Gitweb: https://git.kernel.org/tip/4efcc8bc7e08c09c58a2f5cbc2096fbda5b7cf5e Author: Chen Yu <[email protected]> AuthorDate: Thu, 13 Jul 2023 09:31:33 +08:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Wed, 26 Jul 2023 12:28:51 +02:00
sched/topology: Align group flags when removing degenerate domain
The flags of the child of a given scheduling domain are used to initialize the flags of its scheduling groups. When the child of a scheduling domain is degenerated, the flags of its local scheduling group need to be updated to align with the flags of its new child domain.
The flag SD_SHARE_CPUCAPACITY was aligned in
Commit bf2dc42d6beb ("sched/topology: Propagate SMT flags when removing degenerate domain"). Further generalize this alignment so other flags can be used later, such as in cluster-based task wakeup. [1]
--- kernel/sched/topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/sched/topology.c +1 -2
@@ -722,8 +722,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)if (parent->parent) { parent->parent->child = tmp; -if (tmp->flags &SD_SHARE_CPUCAPACITY ) - parent->parent->groups->flags |=SD_SHARE_CPUCAPACITY ; + parent->parent->groups->flags = tmp->flags; }/*