Skip to contentSkip to conversation

gfs2: fix timestamp handling on quota inodes

PATCH Applied Jeff Layton 3 participants 4 messages Jul 13, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2: fix timestamp handling on quota inodes

While these aren't generally visible from userland, it's best to be consistent with timestamp handling. When adjusting the quota, update the mtime and ctime like we would with a write operation on any other inode, and avoid updating the atime which should only be done for reads.

---
 fs/gfs2/quota.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Christian,

Would you mind picking this into the vfs.ctime branch, assuming the GFS2 maintainers ack it? Andreas and I had discussed this privately, and I think it makes sense as part of that series.

Thanks,
Jeff

fs/gfs2/quota.c +1 -1
index 704192b73605..aa5fd06d47bc 100644
@@ -871,7 +871,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc,
 		size = loc + sizeof(struct gfs2_quota);
 		if (size > inode->i_size)
 			i_size_write(inode, size);
-		inode->i_mtime = inode->i_atime = current_time(inode);
+		inode->i_mtime = inode_set_ctime_current(inode);
 		mark_inode_dirty(inode);
 		set_bit(QDF_REFRESH, &qd->qd_flags);
 	}
Signature · 1 line
2.41.0
#1 lore raw
Quoted 6 lines · Jeff Layton

While these aren't generally visible from userland, it's best to be consistent with timestamp handling. When adjusting the quota, update the mtime and ctime like we would with a write operation on any other inode, and avoid updating the atime which should only be done for reads.

Quoted 8 lines
---
 fs/gfs2/quota.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Christian,

Would you mind picking this into the vfs.ctime branch, assuming the GFS2 maintainers ack it? Andreas and I had discussed this privately, and I

Happy to!

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Jeff Layton

Jeff and Christian,

Quoted 10 lines · On Thu, Jul 13, 2023 at 3:52?PM Jeff Layton <[email protected]> wrote:

While these aren't generally visible from userland, it's best to be consistent with timestamp handling. When adjusting the quota, update the mtime and ctime like we would with a write operation on any other inode, and avoid updating the atime which should only be done for reads.

---
 fs/gfs2/quota.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

Christian,

Would you mind picking this into the vfs.ctime branch, assuming the GFS2 maintainers ack it? Andreas and I had discussed this privately, and I think it makes sense as part of that series.

Yes, please.

Quoted 17 lines

Thanks,
Jeff

fs/gfs2/quota.c +1 -2
index 704192b73605..aa5fd06d47bc 100644
@@ -871,7 +871,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc,
                size = loc + sizeof(struct gfs2_quota);
                if (size > inode->i_size)
                        i_size_write(inode, size);
-               inode->i_mtime = inode->i_atime = current_time(inode);
+               inode->i_mtime = inode_set_ctime_current(inode);
                mark_inode_dirty(inode);
                set_bit(QDF_REFRESH, &qd->qd_flags);
        }
--
Quoted 2 lines

2.41.0

Thanks,
Andreas

maintainer Applied
#3 lore raw
In reply to Jeff Layton
Quoted 6 lines · Jeff Layton

While these aren't generally visible from userland, it's best to be consistent with timestamp handling. When adjusting the quota, update the mtime and ctime like we would with a write operation on any other inode, and avoid updating the atime which should only be done for reads.

Applied to the vfs.ctime branch of the vfs/vfs.git tree. Patches in the vfs.ctime branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.ctime

[1/1] gfs2: fix timestamp handling on quota inodes

      https://git.kernel.org/vfs/vfs/c/ea462c3f7f48