Skip to contentSkip to conversation

manage.c: document missing KID parameter

PATCH In review Lev Stipakov 3 participants 3 messages Jul 14, 2023 – Jul 17, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 manage.c: document missing KID parameter

From: Lev Stipakov <[email protected]...>

Commit a261e173 ("Make sending plain text control message session aware") added KID parameter to "client-pending-auth" management command, but forgot to mention it in the output of management help.

Change-Id I201bdaa5fe4020d15a9dd1674aba5e0c45170731
---
 src/openvpn/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/manage.c +1 -1
index d80f9ffd..739ed40f 100644
@@ -106,7 +106,7 @@ man_help(void)
     msg(M_CLIENT, "client-auth-nt CID KID : Authenticate client-id/key-id CID/KID");
     msg(M_CLIENT, "client-deny CID KID R [CR] : Deny auth client-id/key-id CID/KID with log reason");
     msg(M_CLIENT, "                             text R and optional client reason text CR");
-    msg(M_CLIENT, "client-pending-auth CID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
+    msg(M_CLIENT, "client-pending-auth CID KID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
     msg(M_CLIENT, "                                      to the client and wait for a final client-auth/client-deny");
     msg(M_CLIENT, "client-kill CID [M]    : Kill client instance CID with message M (def=RESTART)");
     msg(M_CLIENT, "env-filter [level]     : Set env-var filter level");
Signature · 1 line
2.38.1.windows.1
Acked-by on v1 1/1
#1 lore raw

Am 14.07.23 um 13:18 schrieb Lev Stipakov:

Quoted 5 lines

From: Lev Stipakov <[email protected]...>

Commit a261e173 ("Make sending plain text control message session aware") added KID parameter to "client-pending-auth" management command, but forgot to mention it in the output of management help.

My fault.

#2 lore raw
In reply to Lev Stipakov

Since this is a pure textual change, I haven't tested this any way - and the change matches "Changes.rst" and "doc/management-notes.txt".

Your patch has been applied to the master and release/2.6 branch.

commit f5201eedd4ea55414bf8310668a3d00e7bf8ea71 (master) commit d3fe78af5dde169fcb13a6fde3b532e5d1a3a633 (release/2.6)

Author: Lev Stipakov
Date:   Fri Jul 14 14:18:02 2023 +0300
     manage.c: document missing KID parameter

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg26856.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering