clocksource: Explicitly include correct DT includes
Subsystems (6)
PATCH 1/1 clocksource: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
--- drivers/clocksource/bcm2835_timer.c | 2 +- drivers/clocksource/nomadik-mtu.c | 2 +- drivers/clocksource/sh_cmt.c | 1 - drivers/clocksource/timer-cadence-ttc.c | 1 + drivers/clocksource/timer-gxp.c | 1 + drivers/clocksource/timer-integrator-ap.c | 2 +- drivers/clocksource/timer-tegra186.c | 1 - drivers/clocksource/timer-ti-dm.c | 1 - 8 files changed, 5 insertions(+), 6 deletions(-)
drivers/clocksource/bcm2835_timer.c +1 -1
@@ -10,9 +10,9 @@#include <linux/irqreturn.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> -#include <linux/of_platform.h> #include <linux/slab.h> #include <linux/string.h> #include <linux/sched_clock.h>
drivers/clocksource/nomadik-mtu.c +1 -1
@@ -10,9 +10,9 @@#include <linux/io.h> #include <linux/clockchips.h> #include <linux/clocksource.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> -#include <linux/of_platform.h> #include <linux/clk.h> #include <linux/jiffies.h> #include <linux/delay.h>
drivers/clocksource/sh_cmt.c +0 -1
@@ -18,7 +18,6 @@#include <linux/irq.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/pm_runtime.h>
drivers/clocksource/timer-cadence-ttc.c +1 -0
@@ -13,6 +13,7 @@#include <linux/clocksource.h> #include <linux/of_address.h> #include <linux/of_irq.h> +#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/sched_clock.h> #include <linux/module.h>
drivers/clocksource/timer-gxp.c +1 -0
@@ -8,6 +8,7 @@#include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/sched_clock.h> #define TIMER0_FREQ 1000000
drivers/clocksource/timer-integrator-ap.c +1 -1
@@ -7,9 +7,9 @@#include <linux/clk.h> #include <linux/clocksource.h> +#include <linux/of.h> #include <linux/of_irq.h> #include <linux/of_address.h> -#include <linux/of_platform.h> #include <linux/clockchips.h> #include <linux/interrupt.h> #include <linux/sched_clock.h>
drivers/clocksource/timer-tegra186.c +0 -1
@@ -8,7 +8,6 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm.h> #include <linux/watchdog.h>
drivers/clocksource/timer-ti-dm.c +0 -1
@@ -27,7 +27,6 @@#include <linux/err.h> #include <linux/pm_runtime.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/platform_data/dmtimer-omap.h>
Signature · 1 line
2.40.1
Daniel Lezcano
AppliedQuoted 11 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.Signed-off-by Rob Herring <[email protected]>---
Applied, thanks
Signature · 11 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
The following commit has been merged into the timers/core branch of tip:
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 0a8b07c77ea09602a152d3604e599f95726306d0 Gitweb: https://git.kernel.org/tip/0a8b07c77ea09602a152d3604e599f95726306d0 Author: Rob Herring <[email protected]> AuthorDate: Fri, 14 Jul 2023 11:44:09 -06:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Fri, 18 Aug 2023 12:16:01 +02:00
clocksource: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
--- drivers/clocksource/bcm2835_timer.c | 2 +- drivers/clocksource/nomadik-mtu.c | 2 +- drivers/clocksource/sh_cmt.c | 1 - drivers/clocksource/timer-cadence-ttc.c | 1 + drivers/clocksource/timer-gxp.c | 1 + drivers/clocksource/timer-integrator-ap.c | 2 +- drivers/clocksource/timer-tegra186.c | 1 - drivers/clocksource/timer-ti-dm.c | 1 - 8 files changed, 5 insertions(+), 6 deletions(-)
drivers/clocksource/bcm2835_timer.c +1 -1
@@ -10,9 +10,9 @@#include <linux/irqreturn.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> -#include <linux/of_platform.h> #include <linux/slab.h> #include <linux/string.h> #include <linux/sched_clock.h>
drivers/clocksource/nomadik-mtu.c +1 -1
@@ -10,9 +10,9 @@#include <linux/io.h> #include <linux/clockchips.h> #include <linux/clocksource.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> -#include <linux/of_platform.h> #include <linux/clk.h> #include <linux/jiffies.h> #include <linux/delay.h>
drivers/clocksource/sh_cmt.c +0 -1
@@ -18,7 +18,6 @@#include <linux/irq.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/pm_runtime.h>
drivers/clocksource/timer-cadence-ttc.c +1 -0
@@ -13,6 +13,7 @@#include <linux/clocksource.h> #include <linux/of_address.h> #include <linux/of_irq.h> +#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/sched_clock.h> #include <linux/module.h>
drivers/clocksource/timer-gxp.c +1 -0
@@ -8,6 +8,7 @@#include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/sched_clock.h> #define TIMER0_FREQ 1000000
drivers/clocksource/timer-integrator-ap.c +1 -1
@@ -7,9 +7,9 @@#include <linux/clk.h> #include <linux/clocksource.h> +#include <linux/of.h> #include <linux/of_irq.h> #include <linux/of_address.h> -#include <linux/of_platform.h> #include <linux/clockchips.h> #include <linux/interrupt.h> #include <linux/sched_clock.h>
drivers/clocksource/timer-tegra186.c +0 -1
@@ -8,7 +8,6 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm.h> #include <linux/watchdog.h>
drivers/clocksource/timer-ti-dm.c +0 -1
@@ -27,7 +27,6 @@#include <linux/err.h> #include <linux/pm_runtime.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/platform_data/dmtimer-omap.h>