i3c: Explicitly include correct DT includes
PATCH 1/1 i3c: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
--- drivers/i3c/master/ast2600-i3c-master.c | 1 - drivers/i3c/master/i3c-master-cdns.c | 1 - 2 files changed, 2 deletions(-)
drivers/i3c/master/ast2600-i3c-master.c +0 -1
@@ -8,7 +8,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h>
drivers/i3c/master/i3c-master-cdns.c +0 -1
@@ -22,7 +22,6 @@#include <linux/slab.h> #include <linux/spinlock.h> #include <linux/workqueue.h> -#include <linux/of_device.h> #define DEV_ID 0x0#define DEV_ID_I3C_MASTER 0x5034
Signature · 7 lines
2.40.1 -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c
Hi Rob,
Quoted 2 lines
In order to detangle these headers and replace the implicit includes with struct declarations
This refers to replacing the implicit includes within the of/ subsystem, right?
Quoted 1 line
users need to explicitly include the correct includes.
LGTM, thanks!
Cheers,
Jeremy
Signature · 3 lines
linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c
Quoted 10 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.[...]
Applied, thanks!
[1/1] i3c: Explicitly include correct DT includes
commit: 574ca75f8d2935053872aa1b15d8ba24bfb5e51c
Best regards,
Signature · 8 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c