thermal: Explicitly include correct DT includes
Subsystems (19)
PATCH 1/1 thermal: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
--- drivers/thermal/amlogic_thermal.c | 2 -- drivers/thermal/broadcom/bcm2711_thermal.c | 2 +- drivers/thermal/broadcom/brcmstb_thermal.c | 2 +- drivers/thermal/hisi_thermal.c | 2 +- drivers/thermal/imx8mm_thermal.c | 1 - drivers/thermal/imx_sc_thermal.c | 1 - drivers/thermal/imx_thermal.c | 2 +- drivers/thermal/k3_bandgap.c | 2 +- drivers/thermal/k3_j72xx_bandgap.c | 2 +- drivers/thermal/mediatek/auxadc_thermal.c | 1 - drivers/thermal/mediatek/lvts_thermal.c | 2 +- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 1 - drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - drivers/thermal/rcar_gen3_thermal.c | 2 +- drivers/thermal/rcar_thermal.c | 2 +- drivers/thermal/rzg2l_thermal.c | 2 +- drivers/thermal/samsung/exynos_tmu.c | 2 +- drivers/thermal/sprd_thermal.c | 2 +- drivers/thermal/st/stm_thermal.c | 2 -- drivers/thermal/sun8i_thermal.c | 2 +- drivers/thermal/tegra/tegra30-tsensor.c | 2 +- drivers/thermal/thermal_of.c | 3 +-- drivers/thermal/uniphier_thermal.c | 1 - 23 files changed, 15 insertions(+), 26 deletions(-)
drivers/thermal/amlogic_thermal.c +0 -2
@@ -22,8 +22,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h>
drivers/thermal/broadcom/bcm2711_thermal.c +1 -1
@@ -15,8 +15,8 @@#include <linux/kernel.h> #include <linux/mfd/syscon.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_device.h> #include <linux/regmap.h> #include <linux/thermal.h>
drivers/thermal/broadcom/brcmstb_thermal.c +1 -1
@@ -17,8 +17,8 @@#include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_device.h> #include <linux/thermal.h> #define AVS_TMON_STATUS 0x00
drivers/thermal/hisi_thermal.c +1 -1
@@ -13,9 +13,9 @@#include <linux/delay.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/io.h> -#include <linux/of_device.h> #include <linux/thermal.h> #define HI6220_TEMP0_LAG (0x0)
drivers/thermal/imx8mm_thermal.c +0 -1
@@ -12,7 +12,6 @@#include <linux/module.h> #include <linux/nvmem-consumer.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h>
drivers/thermal/imx_sc_thermal.c +0 -1
@@ -8,7 +8,6 @@#include <linux/firmware/imx/sci.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h>
drivers/thermal/imx_thermal.c +1 -1
@@ -11,7 +11,7 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> +#include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> #include <linux/nvmem-consumer.h>
drivers/thermal/k3_bandgap.c +1 -1
@@ -11,7 +11,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/thermal.h> #include <linux/types.h>
drivers/thermal/k3_j72xx_bandgap.c +1 -1
@@ -10,10 +10,10 @@#include <linux/module.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/err.h> #include <linux/types.h> -#include <linux/of_platform.h> #include <linux/io.h> #include <linux/thermal.h> #include <linux/of.h>
drivers/thermal/mediatek/auxadc_thermal.c +0 -1
@@ -15,7 +15,6 @@#include <linux/nvmem-consumer.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/io.h>
drivers/thermal/mediatek/lvts_thermal.c +1 -1
@@ -13,7 +13,7 @@#include <linux/iopoll.h> #include <linux/kernel.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/reset.h> #include <linux/thermal.h>
drivers/thermal/qcom/qcom-spmi-adc-tm5.c +0 -1
@@ -14,7 +14,6 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h>
drivers/thermal/qcom/qcom-spmi-temp-alarm.c +0 -1
@@ -10,7 +10,6 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h>
drivers/thermal/rcar_gen3_thermal.c +1 -1
@@ -11,7 +11,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/thermal.h>
drivers/thermal/rcar_thermal.c +1 -1
@@ -11,7 +11,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/reboot.h>
drivers/thermal/rzg2l_thermal.c +1 -1
@@ -9,8 +9,8 @@#include <linux/io.h> #include <linux/iopoll.h> #include <linux/math.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/reset.h>
drivers/thermal/samsung/exynos_tmu.c +1 -1
@@ -15,7 +15,7 @@#include <linux/io.h> #include <linux/interrupt.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/platform_device.h>
drivers/thermal/sprd_thermal.c +1 -1
@@ -6,7 +6,7 @@#include <linux/iopoll.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h>
drivers/thermal/st/stm_thermal.c +0 -2
@@ -14,8 +14,6 @@#include <linux/iopoll.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/thermal.h>
drivers/thermal/sun8i_thermal.c +1 -1
@@ -14,7 +14,7 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/reset.h>
drivers/thermal/tegra/tegra30-tsensor.c +1 -1
@@ -18,7 +18,7 @@#include <linux/iopoll.h> #include <linux/math.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm.h> #include <linux/reset.h>
drivers/thermal/thermal_of.c +1 -2
@@ -10,8 +10,7 @@#include <linux/err.h> #include <linux/export.h> -#include <linux/of_device.h> -#include <linux/of_platform.h> +#include <linux/of.h> #include <linux/slab.h> #include <linux/thermal.h> #include <linux/types.h>
drivers/thermal/uniphier_thermal.c +0 -1
@@ -12,7 +12,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h>
Signature · 1 line
2.40.1
Quoted 11 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.Signed-off-by Rob Herring <[email protected]>
or please let me know if you want me to pick this up.
Thanks!
Quoted 331 lines
--- drivers/thermal/amlogic_thermal.c | 2 -- drivers/thermal/broadcom/bcm2711_thermal.c | 2 +- drivers/thermal/broadcom/brcmstb_thermal.c | 2 +- drivers/thermal/hisi_thermal.c | 2 +- drivers/thermal/imx8mm_thermal.c | 1 - drivers/thermal/imx_sc_thermal.c | 1 - drivers/thermal/imx_thermal.c | 2 +- drivers/thermal/k3_bandgap.c | 2 +- drivers/thermal/k3_j72xx_bandgap.c | 2 +- drivers/thermal/mediatek/auxadc_thermal.c | 1 - drivers/thermal/mediatek/lvts_thermal.c | 2 +- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 1 - drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - drivers/thermal/rcar_gen3_thermal.c | 2 +- drivers/thermal/rcar_thermal.c | 2 +- drivers/thermal/rzg2l_thermal.c | 2 +- drivers/thermal/samsung/exynos_tmu.c | 2 +- drivers/thermal/sprd_thermal.c | 2 +- drivers/thermal/st/stm_thermal.c | 2 -- drivers/thermal/sun8i_thermal.c | 2 +- drivers/thermal/tegra/tegra30-tsensor.c | 2 +- drivers/thermal/thermal_of.c | 3 +-- drivers/thermal/uniphier_thermal.c | 1 - 23 files changed, 15 insertions(+), 26 deletions(-)drivers/thermal/amlogic_thermal.c +0
-2@@ -22,8 +22,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/broadcom/bcm2711_thermal.c +1
-1@@ -15,8 +15,8 @@#include <linux/kernel.h> #include <linux/mfd/syscon.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/broadcom/brcmstb_thermal.c +1
-1@@ -17,8 +17,8 @@#include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_device.h> #include <linux/thermal.h> #define AVS_TMON_STATUS 0x00drivers/thermal/hisi_thermal.c +1
-1@@ -13,9 +13,9 @@#include <linux/delay.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/io.h> -#include <linux/of_device.h> #include <linux/thermal.h> #define HI6220_TEMP0_LAG (0x0)drivers/thermal/imx8mm_thermal.c +0
-1@@ -12,7 +12,6 @@#include <linux/module.h> #include <linux/nvmem-consumer.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h> drivers/thermal/imx_sc_thermal.c +0
-1@@ -8,7 +8,6 @@#include <linux/firmware/imx/sci.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h> drivers/thermal/imx_thermal.c +1
-1@@ -11,7 +11,7 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> +#include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> #include <linux/nvmem-consumer.h> drivers/thermal/k3_bandgap.c +1
-1@@ -11,7 +11,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/thermal.h> #include <linux/types.h> drivers/thermal/k3_j72xx_bandgap.c +1
-1@@ -10,10 +10,10 @@#include <linux/module.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/err.h> #include <linux/types.h> -#include <linux/of_platform.h> #include <linux/io.h> #include <linux/thermal.h> #include <linux/of.h> drivers/thermal/mediatek/auxadc_thermal.c +0
-1@@ -15,7 +15,6 @@#include <linux/nvmem-consumer.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/io.h> drivers/thermal/mediatek/lvts_thermal.c +1
-1@@ -13,7 +13,7 @@#include <linux/iopoll.h> #include <linux/kernel.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/reset.h> #include <linux/thermal.h> drivers/thermal/qcom/qcom-spmi-adc-tm5.c +0
-1@@ -14,7 +14,6 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/qcom/qcom-spmi-temp-alarm.c +0
-1@@ -10,7 +10,6 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/rcar_gen3_thermal.c +1
-1@@ -11,7 +11,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/thermal.h> drivers/thermal/rcar_thermal.c +1
-1@@ -11,7 +11,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/reboot.h> drivers/thermal/rzg2l_thermal.c +1
-1@@ -9,8 +9,8 @@#include <linux/io.h> #include <linux/iopoll.h> #include <linux/math.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/reset.h> drivers/thermal/samsung/exynos_tmu.c +1
-1@@ -15,7 +15,7 @@#include <linux/io.h> #include <linux/interrupt.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/platform_device.h> drivers/thermal/sprd_thermal.c +1
-1@@ -6,7 +6,7 @@#include <linux/iopoll.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h> drivers/thermal/st/stm_thermal.c +0
-2@@ -14,8 +14,6 @@#include <linux/iopoll.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/thermal.h> drivers/thermal/sun8i_thermal.c +1
-1@@ -14,7 +14,7 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/reset.h> drivers/thermal/tegra/tegra30-tsensor.c +1
-1@@ -18,7 +18,7 @@#include <linux/iopoll.h> #include <linux/math.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm.h> #include <linux/reset.h> drivers/thermal/thermal_of.c +1
-2@@ -10,8 +10,7 @@#include <linux/err.h> #include <linux/export.h> -#include <linux/of_device.h> -#include <linux/of_platform.h> +#include <linux/of.h> #include <linux/slab.h> #include <linux/thermal.h> #include <linux/types.h> drivers/thermal/uniphier_thermal.c +0
-2@@ -12,7 +12,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> --2.40.1
Quoted 12 lines · Rafael J. Wysocki
Quoted 10 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 5 lines
Quoted 1 line
Signed-off-by Rob Herring <[email protected]>or please let me know if you want me to pick this up.
Single patch in your subsystem with no dependencies. Please pick it up.
Rob
Quoted 57 lines
-----Original Message-----
From: Rob Herring <[email protected]>
Sent: Friday, July 14, 2023 11:20 PM
To: Guillaume La Roque <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Amit Kucheria <[email protected]>; Zhang Rui <[email protected]>; Florian Fainelli <[email protected]>; Broadcom internal kernel review list <bcm- [email protected]>; Markus Mayer <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Pengutronix Kernel Team <[email protected]>; Fabio Estevam <[email protected]>; NXP Linux Team <[email protected]>; Andy Gross <[email protected]>; Bjorn Andersson <[email protected]>; Konrad Dybcio <[email protected]>; Thara Gopinath <[email protected]>; Niklas Söderlund <[email protected]>; Bartlomiej Zolnierkiewicz <[email protected]>; Krzysztof Kozlowski <[email protected]>; Alim Akhtar <[email protected]>; Orson Zhai <[email protected]>; Baolin Wang <[email protected]>; Chunyan Zhang <[email protected]>; Maxime Coquelin <[email protected]>; Alexandre Torgue <[email protected]>; Vasily Khoruzhick <[email protected]>; Yangtao Li <[email protected]>; Chen-Yu Tsai <[email protected]>; Jernej Skrabec <[email protected]>; Samuel Holland <[email protected]>; Thierry Reding <[email protected]>; Jonathan Hunter <[email protected]>; Kunihiko Hayashi <[email protected]>; Masami Hiramatsu <[email protected]>; Matthias Brugger <[email protected]>; AngeloGioacchino Del Regno <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; linux-rpi- [email protected]; [email protected]; linux-arm- [email protected]; [email protected]; linux-samsung- [email protected]; [email protected]; linux- [email protected]; [email protected]; linux- [email protected]
Subject: [PATCH] thermal: Explicitly include correct DT includesThe DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.Signed-off-by Rob Herring <[email protected]>--- drivers/thermal/amlogic_thermal.c | 2 -- drivers/thermal/broadcom/bcm2711_thermal.c | 2 +- drivers/thermal/broadcom/brcmstb_thermal.c | 2 +- drivers/thermal/hisi_thermal.c | 2 +- drivers/thermal/imx8mm_thermal.c | 1 - drivers/thermal/imx_sc_thermal.c | 1 - drivers/thermal/imx_thermal.c | 2 +- drivers/thermal/k3_bandgap.c | 2 +- drivers/thermal/k3_j72xx_bandgap.c | 2 +-
Quoted 8 lines
drivers/thermal/mediatek/auxadc_thermal.c | 1 - drivers/thermal/mediatek/lvts_thermal.c | 2 +- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 1 - drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - drivers/thermal/rcar_gen3_thermal.c | 2 +- drivers/thermal/rcar_thermal.c | 2 +- drivers/thermal/rzg2l_thermal.c | 2 +- drivers/thermal/samsung/exynos_tmu.c | 2 +-
For Samsung/ Exynos
Quoted 327 lines
drivers/thermal/sprd_thermal.c | 2 +- drivers/thermal/st/stm_thermal.c | 2 -- drivers/thermal/sun8i_thermal.c | 2 +- drivers/thermal/tegra/tegra30-tsensor.c | 2 +- drivers/thermal/thermal_of.c | 3 +-- drivers/thermal/uniphier_thermal.c | 1 - 23 files changed, 15 insertions(+), 26 deletions(-)drivers/thermal/amlogic_thermal.c +0
-2@@ -22,8 +22,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/broadcom/bcm2711_thermal.c +1
-1@@ -15,8 +15,8 @@#include <linux/kernel.h> #include <linux/mfd/syscon.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/broadcom/brcmstb_thermal.c +1
-1@@ -17,8 +17,8 @@#include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_device.h> #include <linux/thermal.h> #define AVS_TMON_STATUS 0x00drivers/thermal/hisi_thermal.c +1
-1@@ -13,9 +13,9 @@#include <linux/delay.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/io.h> -#include <linux/of_device.h> #include <linux/thermal.h> #define HI6220_TEMP0_LAG (0x0)drivers/thermal/imx8mm_thermal.c +0
-1@@ -12,7 +12,6 @@#include <linux/module.h> #include <linux/nvmem-consumer.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h> drivers/thermal/imx_sc_thermal.c +0
-1@@ -8,7 +8,6 @@#include <linux/firmware/imx/sci.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h> drivers/thermal/imx_thermal.c +1
-1@@ -11,7 +11,7 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> +#include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> #include <linux/nvmem-consumer.h> drivers/thermal/k3_bandgap.c index renamed from drivers/thermal/k3_bandgap.c +0
-0
1c3e590157ec..68f59b3735d3100644drivers/thermal/k3_bandgap.c +1
-1@@ -11,7 +11,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_platform.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/thermal.h> #include <linux/types.h> drivers/thermal/k3_j72xx_bandgap.c +1
-1@@ -10,10 +10,10 @@#include <linux/module.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/err.h> #include <linux/types.h> -#include <linux/of_platform.h> #include <linux/io.h> #include <linux/thermal.h> #include <linux/of.h> drivers/thermal/mediatek/auxadc_thermal.c +0
-1@@ -15,7 +15,6 @@#include <linux/nvmem-consumer.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/io.h> drivers/thermal/mediatek/lvts_thermal.c +1
-1@@ -13,7 +13,7 @@#include <linux/iopoll.h> #include <linux/kernel.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/reset.h> #include <linux/thermal.h> drivers/thermal/qcom/qcom-spmi-adc-tm5.c +0
-1@@ -14,7 +14,6 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/qcom/qcom-spmi-temp-alarm.c +0
-1@@ -10,7 +10,6 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> drivers/thermal/rcar_gen3_thermal.c +1
-1@@ -11,7 +11,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/thermal.h> drivers/thermal/rcar_thermal.c +1
-1@@ -11,7 +11,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/reboot.h> drivers/thermal/rzg2l_thermal.c +1
-1@@ -9,8 +9,8 @@#include <linux/io.h> #include <linux/iopoll.h> #include <linux/math.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/reset.h> drivers/thermal/samsung/exynos_tmu.c +1
-1@@ -15,7 +15,7 @@#include <linux/io.h> #include <linux/interrupt.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/platform_device.h> drivers/thermal/sprd_thermal.c +1
-1@@ -6,7 +6,7 @@#include <linux/iopoll.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/thermal.h> drivers/thermal/st/stm_thermal.c +0
-2@@ -14,8 +14,6 @@#include <linux/iopoll.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/thermal.h> drivers/thermal/sun8i_thermal.c +1
-1@@ -14,7 +14,7 @@#include <linux/interrupt.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/reset.h> drivers/thermal/tegra/tegra30-tsensor.c +1
-1@@ -18,7 +18,7 @@#include <linux/iopoll.h> #include <linux/math.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm.h> #include <linux/reset.h> drivers/thermal/thermal_of.c index renamed from drivers/thermal/thermal_of.c +0
-0
6fb14e521197..c36c7d235cba100644drivers/thermal/thermal_of.c +1
-2@@ -10,8 +10,7 @@#include <linux/err.h> #include <linux/export.h> -#include <linux/of_device.h> -#include <linux/of_platform.h> +#include <linux/of.h> #include <linux/slab.h> #include <linux/thermal.h> #include <linux/types.h> drivers/thermal/uniphier_thermal.c +0
-2@@ -12,7 +12,6 @@#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/thermal.h> --2.40.1
Rafael J. Wysocki
maintainerQuoted 14 lines · Rob Herring
Quoted 12 lines · Rafael J. Wysocki
Quoted 10 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Rob Herring <[email protected]>or please let me know if you want me to pick this up.
Single patch in your subsystem with no dependencies. Please pick it up.
Done, thanks!
Quoted 18 lines · Rafael J. Wysocki
Quoted 16 lines · Rob Herring
Quoted 14 lines · Rafael J. Wysocki
Quoted 11 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
or please let me know if you want me to pick this up.
Single patch in your subsystem with no dependencies. Please pick it up.
Done, thanks!
I'm not seeing this in linux-next.
Rob
Rafael J. Wysocki
maintainerQuoted 22 lines · Rob Herring
Quoted 20 lines · Rafael J. Wysocki
Quoted 18 lines · Rob Herring
Quoted 16 lines · Rafael J. Wysocki
Quoted 11 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
or please let me know if you want me to pick this up.
Single patch in your subsystem with no dependencies. Please pick it up.
Done, thanks!
I'm not seeing this in linux-next.
f6a756e8fb12 thermal: Explicitly include correct DT includes
It's there in my linux-next branch (and in my thermal branch) and it should be there in linux-next too.
Quoted 9 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 5 lines
Signed-off-by Rob Herring <[email protected]>--- drivers/thermal/amlogic_thermal.c | 2 -- drivers/thermal/broadcom/bcm2711_thermal.c | 2 +- drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-
Signature · 1 line
Florian