vhost: disable VHOST_OPS_DEBUG by default
PATCH 1/1 vhost: disable VHOST_OPS_DEBUG by default
This commit disables VHOST_OPS_DEBUG by default These information are ususally only required in development environment
--- hw/virtio/vhost.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
hw/virtio/vhost.c +6 -1
@@ -29,7 +29,9 @@#include "trace.h" /* enabled until disconnected backend stabilizes */ -#define _VHOST_DEBUG 1 + +/* uncomment macro _VHOST_DEBUG to enable VHOST_OPS_DEBUG */ +/* #define _VHOST_DEBUG 1 */ #ifdef _VHOST_DEBUG#define VHOST_OPS_DEBUG (retval, fmt, ...) \
@@ -1318,7 +1320,10 @@ static void vhost_virtqueue_error_notifier(EventNotifier *n) struct vhost_virtqueue *vq = container_of(n, struct vhost_virtqueue, error_notifier);struct vhost_dev *dev = vq->dev; + +#ifdef _VHOST_DEBUGint index = vq - dev->vqs; +#endif if (event_notifier_test_and_clear (n) && dev->vdev) { VHOST_OPS_DEBUG(-EINVAL, "vhost vring error in virtqueue %d",
Signature · 1 line
2.39.3
Hi,
Quoted 14 lines · Zhu Lingshan
This commit disables
VHOST_OPS_DEBUGby default These information are ususally only required in development environmentSigned-off-by Zhu Lingshan <[email protected]>--- hw/virtio/vhost.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)hw/virtio/vhost.c +0
-0
hw/virtio/vhost.c line 34
Quoted 7 lines
hw/virtio/vhost.c +3
-1@@ -29,7 +29,9 @@#include "trace.h" /* enabled until disconnected backend stabilizes */ -#define _VHOST_DEBUG 1 + +/* uncomment macro _VHOST_DEBUG to enable VHOST_OPS_DEBUG */ +/* #define _VHOST_DEBUG 1 */
Since you are looking at this, it would be more useful to convert VHOST_OPS_DEBUG() to trace events (see for example commit 163b8663b8 and other "Convert DPRINTF() debug macro to trace events" commits).
Regards,
Phil.
Quoted 12 lines · Philippe Mathieu-Daudé
Hi,
Quoted 9 lines · Zhu Lingshan
This commit disables
VHOST_OPS_DEBUGby default These information are ususally only required in development environmentSigned-off-by Zhu Lingshan <[email protected]>---
hw/virtio/vhost.c| 7 ++++++-1 file changed, 6 insertions(+), 1 deletion(-)
Quoted 16 lines
hw/virtio/vhost.c line 33
Quoted 11 lines
hw/virtio/vhost.c +3
-1@@ -29,7 +29,9 @@ #include "trace.h" /* enabled until disconnected backend stabilizes */ -#define _VHOST_DEBUG 1 + +/* uncomment macro _VHOST_DEBUG to enable VHOST_OPS_DEBUG */ +/* #define _VHOST_DEBUG 1 */ Since you are looking at this, it would be more useful to convert
VHOST_OPS_DEBUG()to trace events (see for example commit163b8663b8and other "ConvertDPRINTF()debug macro to trace events" commits).
Thanks Phil, I will look into this
Quoted 5 lines
Regards,
Phil.