Skip to contentSkip to conversation

ARM: keystone: Drop unused includes

PATCH Applied Rob Herring 2 participants 5 messages Jul 17, 2023 – Aug 23, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: keystone: Drop unused includes

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h (for now) which is needed.

---
 arch/arm/mach-keystone/keystone.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-keystone/keystone.c +1 -3
index 68039aad3014..e0ca26182e0b 100644
@@ -7,12 +7,10 @@
  *	Santosh Shilimkar <[email protected]>
  */
 #include <linux/io.h>
-#include <linux/of.h>
 #include <linux/dma-map-ops.h>
 #include <linux/init.h>
-#include <linux/of_platform.h>
-#include <linux/of_address.h>
 #include <linux/memblock.h>
+#include <linux/platform_device.h>
 
 #include <asm/setup.h>
 #include <asm/mach/map.h>
Signature · 1 line
2.40.1
maintainer Applied
#1 lore raw

Hi Rob Herring,

Quoted 6 lines · Rob Herring

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h (for now) which is needed.

I have applied the following to branch ti-keystone-next on [1]. Thank you!

[1/1] ARM: keystone: Drop unused includes

      commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#2 lore raw
Quoted 11 lines · Nishanth Menon

Hi Rob Herring,

Quoted 6 lines · Rob Herring

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h (for now) which is needed.

Quoted 5 lines

I have applied the following to branch ti-keystone-next on [1]. Thank you!

[1/1] ARM: keystone: Drop unused includes

      commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

Did you really? Doesn't look like this is in linux-next.

Rob

maintainer
#3 lore raw
Quoted 12 lines · Rob Herring
Quoted 11 lines · Nishanth Menon

Hi Rob Herring,

Quoted 6 lines · Rob Herring

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h (for now) which is needed.

Quoted 7 lines
Quoted 5 lines

I have applied the following to branch ti-keystone-next on [1]. Thank you!

[1/1] ARM: keystone: Drop unused includes

      commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

Did you really? Doesn't look like this is in linux-next.

Seems to have been there for a while?

https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next

https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/

$ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a
next-20230801
next-20230802
next-20230804
next-20230807
next-20230808
next-20230809
next-20230816
next-20230817
next-20230818
next-20230821
next-20230822
ti-keystone-soc-for-v6.6

Did I miss something?

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#4 lore raw
Quoted 43 lines · Nishanth Menon
Quoted 12 lines · Rob Herring
Quoted 11 lines · Nishanth Menon

Hi Rob Herring,

Quoted 6 lines · Rob Herring

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h (for now) which is needed.

Quoted 7 lines
Quoted 5 lines

I have applied the following to branch ti-keystone-next on [1]. Thank you!

[1/1] ARM: keystone: Drop unused includes

      commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

Did you really? Doesn't look like this is in linux-next.

Seems to have been there for a while?

https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next

https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/

$ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a
next-20230801
next-20230802
next-20230804
next-20230807
next-20230808
next-20230809
next-20230816
next-20230817
next-20230818
next-20230821
next-20230822
ti-keystone-soc-for-v6.6
Quoted 1 line

Did I miss something?

Sorry, I sent the davinci changes also with 'keystone' in the subject by mistake and confused myself...

Rob