dt-bindings: add vendor-prefixes and bindings for pcd8544 displays
Subsystems (3)
PATCH 1/2 dt-bindings: add vendor-prefixes and bindings for pcd8544 displays
Signed-off-by Viktar Simanenka <[email protected]>
--- .../bindings/display/philips,pcd8544.yaml | 89 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + 2 files changed, 91 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +89 -0
@@ -0,0 +1,89 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Philips PCD8544 LCD Display Controller + +maintainers: + - Viktar Simanenka <[email protected]> + +description: | + Philips PCD8544 LCD Display Controller with SPI control bus. + Monochrome 84x48 LCD displays, such as Nokia 5110/3310 LCDs. + May contain backlight LED. + +allOf: + - $ref: panel/panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + oneOf: + - enum: + - philips,pcd8544 + + dc-gpios: + maxItems: 1 + description: Data/Command selection pin (D/CX) + + reset-gpios: + maxItems: 1 + description: Display Reset pin (RST) + + philips,inverted: + type: boolean + description: Display color inversion + + philips,voltage-op: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 127 + description: Display liquid crystal operation voltage + + philips,bias: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 7 + description: Display bias voltage system value + + philips,temperature-coeff: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3 + description: Display temperature compensation coefficient + +required: + - compatible + - reg + - dc-gpios + - reset-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + + display@0 { + compatible = "philips,pcd8544"; + spi-max-frequency = <8000000>; + reg = <0>; + + dc-gpios = <&pio 0 3 GPIO_ACTIVE_HIGH>; /* DC=PA3 */ + reset-gpios = <&pio 0 1 GPIO_ACTIVE_HIGH>; /* RESET=PA1 */ + backlight = <&backlight>; + + philips,inverted; + philips,voltage-op = <0>; + philips,bias = <4>; + philips,temperature-coeff = <0>; + }; + }; + +...
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1037,6 +1037,8 @@ patternProperties: description: Pervasive Displays, Inc. "^phicomm,.*": description: PHICOMM Co., Ltd. + "^philips,.*": + description: Koninklijke Philips N.V. "^phytec,.*": description: PHYTEC Messtechnik GmbH "^picochip,.*":
Signature · 1 line
2.34.1
PATCH 2/2 drm/tiny: add display driver for philips pcd8544 display controller
Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.
Signed-off-by Viktar Simanenka <[email protected]>
--- drivers/gpu/drm/tiny/Kconfig | 11 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/pcd8544.c | 506 +++++++++++++++++++++++++++++++++ 3 files changed, 518 insertions(+) create mode 100644 drivers/gpu/drm/tiny/pcd8544.c
drivers/gpu/drm/tiny/Kconfig +11 -0
@@ -172,6 +172,17 @@ config TINYDRM_MI0283QT DRM driver for the Multi-Inno MI0283QT display panel If M is selected the module will be called mi0283qt. +config TINYDRM_PCD8544 + tristate "DRM support for PCD8544 displays" + depends on DRM && SPI + select DRM_KMS_HELPER + select DRM_GEM_DMA_HELPER + select BACKLIGHT_CLASS_DEVICE + help + DRM driver for PCD8544 (Nokia 5110/3310) 84x48 LCD displays. + + If M is selected the module will be called pcd8544. + config TINYDRM_REPAPER tristate "DRM support for Pervasive Displays RePaper panels (V231)" depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +1 -0
@@ -13,6 +13,7 @@ obj-$(CONFIG_TINYDRM_ILI9225) += ili9225.o obj-$(CONFIG_TINYDRM_ILI9341) += ili9341.o obj-$(CONFIG_TINYDRM_ILI9486) += ili9486.o obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o +obj-$(CONFIG_TINYDRM_PCD8544) += pcd8544.o obj-$(CONFIG_TINYDRM_REPAPER) += repaper.o obj-$(CONFIG_TINYDRM_ST7586) += st7586.o obj-$(CONFIG_TINYDRM_ST7735R) += st7735r.o
drivers/gpu/drm/tiny/pcd8544.c new file +506 -0
506 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH 2/2] drm/tiny: add display driver for philips pcd8544 display controller
Quoted 5 lines · Viktar Simanenka
Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.
Signed-off-by Viktar Simanenka <[email protected]>---
No changelog, same version, so nothing improved here?
Best regards,
Krzysztof
Quoted 1 line · Viktar Simanenka
Signed-off-by Viktar Simanenka <[email protected]>
Missing commit msg, missing changelog, missing versioning - I already asked for the last two things.
Quoted 25 lines
--- .../bindings/display/philips,pcd8544.yaml | 89 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + 2 files changed, 91 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yamlDocumentation/devicetree/bindings/display/philips,pcd8544.yaml new file +13
-0@@ -0,0 +1,89 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Philips PCD8544 LCD Display Controller + +maintainers: + - Viktar Simanenka <[email protected]> + +description: | + Philips PCD8544 LCD Display Controller with SPI control bus.
Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 23
Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10
-0+ Monochrome 84x48 LCD displays, such as Nokia 5110/3310 LCDs. + May contain backlight LED. + +allOf: + - $ref: panel/panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + oneOf:
That's not oneOf.
Quoted 4 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +4
-0+ - enum: + - philips,pcd8544 + + dc-gpios:
Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 37
Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10
-0+ maxItems: 1 + description: Data/Command selection pin (D/CX) + + reset-gpios: + maxItems: 1 + description: Display Reset pin (RST) + + philips,inverted: + type: boolean + description: Display color inversion
Not much improved here. What is it?
Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 43
Quoted 6 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +6
-0+ + philips,voltage-op: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 127 + description: Display liquid crystal operation voltage
Voltage is in microvolts (or other *volts). Use proper unit suffix.
Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 49
Quoted 6 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +6
-0+ + philips,bias: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 7 + description: Display bias voltage system value
In which units? Voltage is in microvolts.
Quoted 17 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +17
-0+ + philips,temperature-coeff: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3 + description: Display temperature compensation coefficient + +required: + - compatible + - reg + - dc-gpios + - reset-gpios + +unevaluatedProperties: false + +examples: + - |
Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 76
Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10
-0+ #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + + display@0 { + compatible = "philips,pcd8544"; + spi-max-frequency = <8000000>; + reg = <0>;
reg is always after compatible.
Quoted 18 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +13
-0+ + dc-gpios = <&pio 0 3 GPIO_ACTIVE_HIGH>; /* DC=PA3 */ + reset-gpios = <&pio 0 1 GPIO_ACTIVE_HIGH>; /* RESET=PA1 */ + backlight = <&backlight>; + + philips,inverted; + philips,voltage-op = <0>; + philips,bias = <4>; + philips,temperature-coeff = <0>; + }; + }; + +...Documentation/devicetree/bindings/vendor-prefixes.yaml +0
-0
Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 1041
Quoted 5 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +2
-0@@ -1037,6 +1037,8 @@ patternProperties: description: Pervasive Displays, Inc. "^phicomm,.*": description: PHICOMM Co., Ltd. + "^philips,.*": + description: Koninklijke Philips N.V.
Isn't this Philips Semiconductors? That's what datasheet is saying.
Best regards,
Krzysztof