Skip to contentSkip to conversation

syscalls/pipe08: Remove the test

PATCH In review Avinesh Kumar 3 participants 5 messages Jul 19, 2023 – Aug 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls/pipe08: Remove the test

This test scenario of verifying SIGPIPE signal is being covered in syscalls/write05.c test.

---
 runtest/syscalls                          |   1 -
 testcases/kernel/syscalls/pipe/.gitignore |   1 -
 testcases/kernel/syscalls/pipe/pipe08.c   | 137 ----------------------
 3 files changed, 139 deletions(-)
 delete mode 100644 testcases/kernel/syscalls/pipe/pipe08.c
runtest/syscalls +0 -1
index b29151186..baae0dbe9 100644
@@ -983,7 +983,6 @@ pipe04 pipe04
 pipe05 pipe05
 pipe06 pipe06
 pipe07 pipe07
-pipe08 pipe08
 pipe09 pipe09
 pipe10 pipe10
 pipe11 pipe11
testcases/kernel/syscalls/pipe/.gitignore +0 -1
index 774d73205..fc0ee705f 100644
@@ -5,7 +5,6 @@
 /pipe05
 /pipe06
 /pipe07
-/pipe08
 /pipe09
 /pipe10
 /pipe11
testcases/kernel/syscalls/pipe/pipe08.c deleted +0 -137

137 lines not on this page · raw message

Signature · 5 lines
2.41.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi Avinesh,

Quoted 2 lines

This test scenario of verifying SIGPIPE signal is being covered in syscalls/write05.c test.

Good catch. I'm just waiting for ack of others.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
In reply to Avinesh Kumar

Hi!

Quoted 2 lines

This test scenario of verifying SIGPIPE signal is being covered in syscalls/write05.c test.

Hmm, this one is actually hard to figure out. Indeed the write test implmenents the SIGPIPE case, however it would make more sense to have the SIGPIPE test in syscalls/pipe/ directory instead. I guess that any kernel developer that would like to use LTP for testing changes in pipe() implementation would rather want to have the test under pipe/ directory.

Maybe we should keep the pipe08 test and remove the case from the write05 test instead? Or should we keep both?

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi Cyril, Petr,

Quoted 12 lines · IST Cyril Hrubis

Hi!

Quoted 2 lines

This test scenario of verifying SIGPIPE signal is being covered in syscalls/write05.c test.

Hmm, this one is actually hard to figure out. Indeed the write test implmenents the SIGPIPE case, however it would make more sense to have the SIGPIPE test in syscalls/pipe/ directory instead. I guess that any kernel developer that would like to use LTP for testing changes in pipe() implementation would rather want to have the test under pipe/ directory.

Quoted 2 lines

Maybe we should keep the pipe08 test and remove the case from the write05 test instead? Or should we keep both?

Thank you for your feedback. Now I too think we can keep both, but you guys can decide. Please let me know, I can send the patch for pipe08 to convert to new API if we decide to keep it.

--
Regards,
Avinesh

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

Hi!

Quoted 7 lines
Quoted 7 lines

Hmm, this one is actually hard to figure out. Indeed the write test implmenents the SIGPIPE case, however it would make more sense to have the SIGPIPE test in syscalls/pipe/ directory instead. I guess that any kernel developer that would like to use LTP for testing changes in pipe() implementation would rather want to have the test under pipe/ directory.

Quoted 6 lines
Quoted 2 lines

Maybe we should keep the pipe08 test and remove the case from the write05 test instead? Or should we keep both?

Thank you for your feedback. Now I too think we can keep both, but you guys can decide. Please let me know, I can send the patch for pipe08 to convert to new API if we decide to keep it.

I would wote for converting the test into the new API.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp