drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER
Subsystems (3)
PATCH 1/1 drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER
From: Arnd Bergmann <[email protected]>
The newly added driver only builds when DRM_DISPLAY_DP_HELPER is enabled:
x86_64-linux-ld: drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable':
panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack'
Select both CONFIG_DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to ensure the helper function is always available.
--- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/Kconfig +2 -0
@@ -798,6 +798,8 @@ config DRM_PANEL_VISIONOX_R66451 depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE + select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for Visionox R66451 1080x2340 AMOLED DSI panel.
Signature · 1 line
2.39.2
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The newly added driver only builds when
DRM_DISPLAY_DP_HELPERis enabled:x86_64-linux-ld:
drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable':
panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack'Select both
CONFIG_DRM_DISPLAY_DP_HELPERandCONFIG_DRM_DISPLAY_HELPERto ensure the helper function is always available.
Hi Arnd,
Thanks for catching this -- hadn't seen this issue due to DRM_MSM selecting both configs already.
Thanks,
Jessica Zhang
Quoted 23 lines
Fixes a6dfab2738fc2 ("drm/panel: Add driver for Visionox r66451 panel")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/panel/Kconfig +2
-0@@ -798,6 +798,8 @@ config DRM_PANEL_VISIONOX_R66451 depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE + select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for Visionox R66451 1080x2340 AMOLED DSI panel.Signature · 1 line
2.39.2
Hi,
Quoted 9 lines · Arnd Bergmann
The newly added driver only builds when
DRM_DISPLAY_DP_HELPERis enabled:x86_64-linux-ld:
drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable':
panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack'Select both
CONFIG_DRM_DISPLAY_DP_HELPERandCONFIG_DRM_DISPLAY_HELPERto ensure the helper function is always available.[...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a1865d3b98c97d25cbfbba4318180f5cfe8ec22d
Signature · 1 line
Neil
Hi,
Quoted 9 lines · Arnd Bergmann
The newly added driver only builds when
DRM_DISPLAY_DP_HELPERis enabled:x86_64-linux-ld:
drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable':
panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack'Select both
CONFIG_DRM_DISPLAY_DP_HELPERandCONFIG_DRM_DISPLAY_HELPERto ensure the helper function is always available.[...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a1865d3b98c97d25cbfbba4318180f5cfe8ec22d
Signature · 1 line
Neil