gpio: lp873x: remove unnecessary call to platform_set_drvdata()
PATCH 1/1 gpio: lp873x: remove unnecessary call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/gpio/gpio-lp873x.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpio/gpio-lp873x.c +0 -2
@@ -140,8 +140,6 @@ static int lp873x_gpio_probe(struct platform_device *pdev)if (!gpio)return -ENOMEM ; -platform_set_drvdata (pdev, gpio); - gpio->lp873 =dev_get_drvdata (pdev->dev.parent); gpio->chip = template_chip; gpio->chip.parent = gpio->lp873->dev;
Signature · 1 line
2.34.1
Quoted 4 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Wrong version of the patch. Use -v<X>, where <X> is a number.
Quoted 3 lines
Reviewed-by Alexandru Ardelean <[email protected]>Signed-off-by Andrei Coardos <[email protected]>---
There is no changelog. What has been changed? What's the difference to v1 if this is assumed v2?
Signature · 2 lines
With Best Regards, Andy Shevchenko