driver core: Move dev_err_probe() to where it belogs
PATCH 1/1 driver core: Move dev_err_probe() to where it belogs
dev_err_probe() belongs to the printing API, hence move the definition from device.h to dev_printk.h.
There is no change to the callers at all, since:
1) implementation is located in the same core.c;
2) dev_printk.h is guaranteed to be included by device.h.
Signed-off-by Andy Shevchenko <[email protected]>
--- include/linux/dev_printk.h | 2 ++ include/linux/device.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/dev_printk.h +2 -0
@@ -274,4 +274,6 @@ do { \ WARN_ONCE(condition, "%s %s: " format, \ dev_driver_string(dev), dev_name(dev), ## arg) +__printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); +#endif /* _DEVICE_PRINTK_H_ */
include/linux/device.h +0 -2
@@ -1241,8 +1241,6 @@ void device_link_remove(void *consumer, struct device *supplier);void device_links_supplier_sync_state_pause (void );void device_links_supplier_sync_state_resume (void ); -__printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); -/* Create alias, so I can be autoloaded. */ #define MODULE_ALIAS_CHARDEV (major,minor) \ MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor))
Signature · 1 line
2.40.0.1.gaa8946217a0b
Hi Andi,
Quoted 8 lines · Andy Shevchenko
dev_err_probe()belongs to the printing API, hence move the definition fromdevice.htodev_printk.h.There is no change to the callers at all, since:
1) implementation is located in the samecore.c;
2)dev_printk.his guaranteed to be included bydevice.h.Signed-off-by Andy Shevchenko <[email protected]>
yes! I think that's right!
Reviewed-by Andi Shyti <[email protected]>
Andi