Skip to contentSkip to conversation

webkitgtk: disable DEBUG_BUILD

PATCH In review [email protected] 2 participants 3 messages Jul 24, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webkitgtk: disable DEBUG_BUILD

From: Kai Kang <[email protected]>

It fails to build webkitgtk with DEBUG_BUILD:

Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:140:1:
error: inlining failed in call to 'always_inline' 'pas_generic_large_free_heap_try_allocate_test_allocation_candidate':
indirect function call with a yet undetermined callee
| pas_generic_large_free_heap_try_allocate_test_allocation_candidate( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So disable DEBUG_BUILD for it.

---
 meta/recipes-sato/webkit/webkitgtk_2.38.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.38.6.bb +3 -0
index 5e8adf50fc..e6d817cb62 100644
@@ -42,6 +42,9 @@ DEPENDS += " \
           gettext-native \
           "
 
+# webkitgtk fails to build with DEBUG_BUILD enabled
+DEBUG_BUILD = "0"
+
 PACKAGECONFIG_SOUP ?= "soup3"
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd wayland x11', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'webgl opengl', '', d)} \
Signature · 1 line
2.34.1
#1 lore raw

Does this happen on master? If so, does this need an upstream bug report, or maybe a better fix?

Alex

Quoted 45 lines · Kai Kang

From: Kai Kang <[email protected]>

It fails to build webkitgtk with DEBUG_BUILD:

Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:140:1:
error: inlining failed in call to 'always_inline' 'pas_generic_large_free_heap_try_allocate_test_allocation_candidate':
indirect function call with a yet undetermined callee
| pas_generic_large_free_heap_try_allocate_test_allocation_candidate( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So disable DEBUG_BUILD for it.

---
 meta/recipes-sato/webkit/webkitgtk_2.38.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.38.6.bb +3 -1
index 5e8adf50fc..e6d817cb62 100644
@@ -42,6 +42,9 @@ DEPENDS += " \
           gettext-native \
           "
 
+# webkitgtk fails to build with DEBUG_BUILD enabled
+DEBUG_BUILD = "0"
+
 PACKAGECONFIG_SOUP ?= "soup3"
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd wayland x11', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'webgl opengl', '', d)} \
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184778): https://lists.openembedded.org/g/openembedded-core/message/184778
Mute This Topic: https://lists.openembedded.org/mt/100324919/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 2 lines · Alexander Kanavin

Does this happen on master? If so, does this need an upstream bug report, or maybe a better fix?

Yes, if fails through webkitgtk 2.38.x to 2.40.x. It needs many replacement that replace 'PAS_ALWAYS_INLINE' with 'inline' and I'm not sure that is a good fix. I'll discuss with upstream about it.

Regards,
Kai

Quoted 48 lines

Alex

Quoted 44 lines · Kai Kang

From: Kai Kang <[email protected]>

It fails to build webkitgtk with DEBUG_BUILD:

Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:140:1:
error: inlining failed in call to 'always_inline' 'pas_generic_large_free_heap_try_allocate_test_allocation_candidate':

   indirect function call with a yet undetermined callee
   | pas_generic_large_free_heap_try_allocate_test_allocation_candidate(
   | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So disable DEBUG_BUILD for it.

---
  meta/recipes-sato/webkit/webkitgtk_2.38.6.bb | 3 +++
  1 file changed, 3 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.38.6.bb +3 -1
index 5e8adf50fc..e6d817cb62 100644
@@ -42,6 +42,9 @@ DEPENDS += " \
            gettext-native \
            "
 
+# webkitgtk fails to build with DEBUG_BUILD enabled
+DEBUG_BUILD = "0"
+
  PACKAGECONFIG_SOUP ?= "soup3"
  PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd wayland x11', d)} \
                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'webgl opengl', '', d)} \
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184778): https://lists.openembedded.org/g/openembedded-core/message/184778
Mute This Topic: https://lists.openembedded.org/mt/100324919/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Kai Kang
Wind River Linux