Skip to contentSkip to conversation

drm/panel: ld9040: add backlight Kconfig dependency

PATCH Applied Arnd Bergmann 3 participants 3 messages Jul 24, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: ld9040: add backlight Kconfig dependency

From: Arnd Bergmann <[email protected]>

The driver now uses the backlight interface, which breaks when that is disabled:

ld.lld: error: undefined symbol: devm_backlight_device_register

Enforce the necessary Kconfig dependency to avoid this.

Fixes c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/Kconfig +1 -0
index e8c9f4613a4b4..b097b2507ac5b 100644
@@ -300,6 +300,7 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
 config DRM_PANEL_SAMSUNG_LD9040
 	tristate "Samsung LD9040 RGB/SPI panel"
 	depends on OF && SPI
+	depends on BACKLIGHT_CLASS_DEVICE
 	select VIDEOMODE_HELPERS
 
 config DRM_PANEL_LG_LB035Q02
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The driver now uses the backlight interface, which breaks when that is disabled:

ld.lld: error: undefined symbol: devm_backlight_device_register

Enforce the necessary Kconfig dependency to avoid this.

Fixes c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")

I expect that someone else with drm-misc rights apply the patch.

Sam

#2 lore raw

Hi,

Le lundi 24 juillet 2023 à 19:11 +0200, Sam Ravnborg a écrit :

Quoted 8 lines · Arnd Bergmann
Quoted 7 lines

From: Arnd Bergmann <[email protected]>

The driver now uses the backlight interface, which breaks when that is disabled:

ld.lld: error: undefined symbol: devm_backlight_device_register

Quoted 8 lines
Quoted 5 lines

Enforce the necessary Kconfig dependency to avoid this.

Fixes c2268daa65fb4 ("drm/panel: ld9040: Register a backlight

device")

I expect that someone else with drm-misc rights apply the patch.

Pushed to drm-misc-next.

Thanks,
-Paul