Skip to contentSkip to conversation

Documentation: core-api: Drop :export: for int_log.h

PATCH In review Andy Shevchenko 3 participants 11 messages Jul 25, 2023 – Jul 26, 2023 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Documentation: core-api: Drop :export: for int_log.h

The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() might appear. Otherwise kernel-doc may not produce anything out of this file.

Fixes f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")

---
v2: added tags (Randy, Jonathan), assumed to go via ASoC tree

 Documentation/core-api/kernel-api.rst | 1 -
 1 file changed, 1 deletion(-)
Documentation/core-api/kernel-api.rst +0 -1
index a526fbe06f86..ae92a2571388 100644
@@ -166,7 +166,6 @@ Integer log and power Functions
 -------------------------------
 
 .. kernel-doc:: include/linux/int_log.h
-   :export:
 
 .. kernel-doc:: lib/math/int_pow.c
    :export:
Signature · 1 line
2.40.0.1.gaa8946217a0b
maintainer
#1 lore raw
Quoted 19 lines · Andy Shevchenko

The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() might appear. Otherwise kernel-doc may not produce anything out of this file.

Fixes f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")

---
v2: added tags (Randy, Jonathan), assumed to go via ASoC tree

 Documentation/core-api/kernel-api.rst | 1 -
 1 file changed, 1 deletion(-)
Documentation/core-api/kernel-api.rst +0 -0
index a526fbe06f86..ae92a2571388 100644

Documentation/core-api/kernel-api.rst Integer log and power Functions · line 169

Quoted 5 lines
Documentation/core-api/kernel-api.rst +0 -1
@@ -166,7 +166,6 @@ Integer log and power Functions
 -------------------------------
 
 .. kernel-doc:: include/linux/int_log.h
-   :export:
 

So I still can't take this patch for the reasons described before. It looks like Mark took the patch that added the problem, so perhaps he should be a recipient of this one too? I'll add him to the CC...

jon

#2 lore raw
Quoted 8 lines · Jonathan Corbet
Quoted 2 lines · Andy Shevchenko

---
v2: added tags (Randy, Jonathan), assumed to go via ASoC tree

So I still can't take this patch for the reasons described before. It looks like Mark took the patch that added the problem, so perhaps he should be a recipient of this one too?

That's what have been assumed above.

Quoted 1 line

I'll add him to the CC...

Oh, I missed Cc'ing him...

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
In reply to Jonathan Corbet
Quoted 9 lines · Jonathan Corbet
Quoted 3 lines · Andy Shevchenko

The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() might appear. Otherwise kernel-doc may not produce anything out of this file.

So I still can't take this patch for the reasons described before. It looks like Mark took the patch that added the problem, so perhaps he should be a recipient of this one too? I'll add him to the CC...

Is this the same patch I applied yesterday or a different one?

#4 lore raw
Quoted 7 lines · Mark Brown
Quoted 5 lines · Jonathan Corbet
Quoted 3 lines · Andy Shevchenko

The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() might appear. Otherwise kernel-doc may not produce anything out of this file.

Quoted 5 lines
Quoted 3 lines

So I still can't take this patch for the reasons described before. It looks like Mark took the patch that added the problem, so perhaps he should be a recipient of this one too? I'll add him to the CC...

Is this the same patch I applied yesterday or a different one?

Hmm...
I do not see anything like this patch in your current ASoC for-next (nor in for-6.6). Did I look into wrong branch?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 1 line · Mark Brown

Is this the same patch I applied yesterday or a different one?

Hmm...
I do not see anything like this patch in your current ASoC for-next (nor in for-6.6). Did I look into wrong branch?

There was some random patch you just sent me the message ID for in the replies to something from Stephen which I'm fairly sure I queued, perhaps it was a different thing or git thought it was a noop when it was applied?

#6 lore raw
Quoted 5 lines · Mark Brown
Quoted 3 lines · Andy Shevchenko
Quoted 1 line · Mark Brown

Is this the same patch I applied yesterday or a different one?

Quoted 8 lines
Quoted 3 lines

Hmm...
I do not see anything like this patch in your current ASoC for-next (nor in for-6.6). Did I look into wrong branch?

There was some random patch you just sent me the message ID for in the replies to something from Stephen which I'm fairly sure I queued, perhaps it was a different thing or git thought it was a noop when it was applied?

The first version is here [1].
Then it was a discussion about Linux Next build issues [2].

In the discussion I mentioned:

The [email protected] had been sent.

which is exactly what [1] is.

I have no idea how it can be a noop, but the patch is missing as far as I can tell.

This thread is v2 of what was in [1].

[1]: https://lore.kernel.org/linux-doc/[email protected]/
[2]: https://lore.kernel.org/linux-next/[email protected]/T/#u

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw
Quoted 16 lines · Andy Shevchenko
Quoted 4 lines · Mark Brown

There was some random patch you just sent me the message ID for in the replies to something from Stephen which I'm fairly sure I queued, perhaps it was a different thing or git thought it was a noop when it was applied?

The first version is here [1].
Then it was a discussion about Linux Next build issues [2].

In the discussion I mentioned:

The [email protected] had been sent.

which is exactly what [1] is.

Quoted 7 lines

I have no idea how it can be a noop, but the patch is missing as far as I can tell.

This thread is v2 of what was in [1].

[1]: https://lore.kernel.org/linux-doc/[email protected]/
[2]: https://lore.kernel.org/linux-next/[email protected]/T/#u

So there's two versions of the patch and for some reason v1 was mentioned yesterday but there's also a v2 version?

#8 lore raw
Quoted 20 lines · Mark Brown
Quoted 18 lines · Andy Shevchenko
Quoted 4 lines · Mark Brown

There was some random patch you just sent me the message ID for in the replies to something from Stephen which I'm fairly sure I queued, perhaps it was a different thing or git thought it was a noop when it was applied?

The first version is here [1].
Then it was a discussion about Linux Next build issues [2].

In the discussion I mentioned:

The [email protected] had been sent.

which is exactly what [1] is.

I have no idea how it can be a noop, but the patch is missing as far as I can tell.

Quoted 7 lines
Quoted 4 lines

This thread is v2 of what was in [1].

[1]: https://lore.kernel.org/linux-doc/[email protected]/
[2]: https://lore.kernel.org/linux-next/[email protected]/T/#u

So there's two versions of the patch and for some reason v1 was mentioned yesterday but there's also a v2 version?

Yes, and I forgot to initially Cc you for v2.

If you are using b4, you can take Message ID of this message and I am sure it capable to retrieve v2 of the patch. Or I can resend with you in Cc list.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#9 lore raw
In reply to Andy Shevchenko
Quoted 5 lines · Andy Shevchenko

The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() might appear. Otherwise kernel-doc may not produce anything out of this file.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] Documentation: core-api: Drop :export: for int_log.h

      commit: 5bdeb6f5c7b94f653183f08eca8a08022b2efac6

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark