Skip to contentSkip to conversation

smb: switch to use kmemdup_nul() helper

PATCH In review Yang Yingliang 2 participants 2 messages Jul 25, 2023 – Jul 26, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smb: switch to use kmemdup_nul() helper

Use kmemdup_nul() helper instead of open-coding to simplify the code.

---
 fs/smb/server/asn1.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/smb/server/asn1.c +1 -3
index cc6384f79675..4a4b2b03ff33 100644
@@ -214,12 +214,10 @@ static int ksmbd_neg_token_alloc(void *context, size_t hdrlen,
 {
 	struct ksmbd_conn *conn = context;
 
-	conn->mechToken = kmalloc(vlen + 1, GFP_KERNEL);
+	conn->mechToken = kmemdup_nul(value, vlen, GFP_KERNEL);
 	if (!conn->mechToken)
 		return -ENOMEM;
 
-	memcpy(conn->mechToken, value, vlen);
-	conn->mechToken[vlen] = '\0';
 	return 0;
 }
 
Signature · 1 line
2.25.1