Skip to contentSkip to conversation

hwmon: (hs3001) Fix unused variable compiler warning

PATCH Superseded [email protected] 3 participants 5 messages Jul 26, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (hs3001) Fix unused variable compiler warning

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

---

---
 drivers/hwmon/hs3001.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hwmon/hs3001.c +0 -1
index 17c3455922eb..9972f6bbb22a 100644
@@ -193,7 +193,6 @@ static int hs3001_probe(struct i2c_client *client)
 	struct hs3001_data *data;
 	struct device *hwmon_dev;
 	struct device *dev = &client->dev;
-	int ret;
 
 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
 		return -EOPNOTSUPP;
Signature · 1 line
2.41.0
#1 lore raw
Quoted 7 lines · On 26/07/2023 13:36, [email protected] wrote:

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

No blank lines between the tags.

Quoted 1 line

Was the original patch actually merged? I don't see it in next.

Best regards,
Krzysztof

#2 lore raw
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · On 26/07/2023 13:36, [email protected] wrote:

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

Quoted 8 lines
Quoted 3 lines

No blank lines between the tags.

Quoted 1 line

Was the original patch actually merged? I don't see it in next.

Ah, I see Guenter's response.

Best regards,
Krzysztof

#3 lore raw

PATCH v2 1/1 hwmon: (hs3001) Fix unused variable compiler warning

In reply to Krzysztof Kozlowski

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

---
v2: Delete blank line between tags in commit message.

---
 drivers/hwmon/hs3001.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hwmon/hs3001.c +0 -1
index 17c3455922eb..9972f6bbb22a 100644
@@ -193,7 +193,6 @@ static int hs3001_probe(struct i2c_client *client)
 	struct hs3001_data *data;
 	struct device *hwmon_dev;
 	struct device *dev = &client->dev;
-	int ret;
 
 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
 		return -EOPNOTSUPP;
Signature · 1 line
2.41.0
maintainer Applied
#4 lore raw
Quoted 7 lines · On Wed, Jul 26, 2023 at 03:06:02PM +0200, [email protected] wrote:

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

Applied.

Thanks,
Guenter

Quoted 18 lines

---
v2: Delete blank line between tags in commit message.

---
 drivers/hwmon/hs3001.c | 1 -
 1 file changed, 1 deletion(-)
drivers/hwmon/hs3001.c +0 -1
index 17c3455922eb..9972f6bbb22a 100644
@@ -193,7 +193,6 @@ static int hs3001_probe(struct i2c_client *client)
 	struct hs3001_data *data;
 	struct device *hwmon_dev;
 	struct device *dev = &client->dev;
-	int ret;
 
 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
 		return -EOPNOTSUPP;