Skip to contentSkip to conversation

ata: pata_ns87415: mark ns87560_tf_read static

PATCH Applied Arnd Bergmann 2 participants 2 messages Jul 26, 2023 libata

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ata: pata_ns87415: mark ns87560_tf_read static

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)

There are no other references to this, so just make it static.

Fixes c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")

---
v2: fix changelog text

---
 drivers/ata/pata_ns87415.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_ns87415.c +1 -1
index d60e1f69d7b02..c697219a61a2d 100644
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
  *	LOCKING:
  *	Inherited from caller.
  */
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
 {
 	struct ata_ioports *ioaddr = &ap->ioaddr;
 
Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

Quoted 8 lines

drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)

There are no other references to this, so just make it static.

Fixes c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")

Applied to for-6.5-fixes. Thanks !

Signature · 2 lines
Damien Le Moal
Western Digital Research