FAILED: patch "[PATCH] ext4: fix to check return value of freeze_bdev() in" failed to apply to 5.4-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y
git checkout FETCH_HEAD
git cherry-pick -x c4d13222afd8a64bf11bc7ec68645496ee8b54b9
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2023072652-selector-hangover-e9ed@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^..
Possible dependencies:
c4d13222afd8 ("ext4: fix to check return value of freeze_bdev() in ext4_shutdown()")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From c4d13222afd8a64bf11bc7ec68645496ee8b54b9 Mon Sep 17 00:00:00 2001
From: Chao Yu <[email protected]>
Date: Tue, 6 Jun 2023 15:32:03 +0800
Subject: [PATCH] ext4: fix to check return value of freeze_bdev() in
ext4_shutdown()
freeze_bdev() can fail due to a lot of reasons, it needs to check its reason before later process.
fs/ext4/ioctl.c +4 -1
@@ -797,6 +797,7 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg) {struct ext4_sb_info *sbi =EXT4_SB (sb);__u32 flags; +int ret;if (!capable (CAP_SYS_ADMIN ))return -EPERM ;
@@ -815,7 +816,9 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg)switch (flags) {case EXT4_GOING_FLAGS_DEFAULT : -freeze_bdev (sb->s_bdev); + ret =freeze_bdev (sb->s_bdev); +if (ret) +return ret;set_bit (EXT4_FLAGS_SHUTDOWN , &sbi->s_ext4_flags);thaw_bdev (sb->s_bdev);break ;