hw/i2c: Fix bitbang_i2c_data trace event
PATCH 1/1 hw/i2c: Fix bitbang_i2c_data trace event
The clock and data values were logged swapped. Correct the trace event text to match what is logged. Also fix a typo in a comment nearby.
Signed-off-by BALATON Zoltan <[email protected]>
---
By the way, get_maintainer.pl does not find a maintainer for bitbang_i2c.c, should it be added somewhere with the rest of hw/i2c?
hw/i2c/bitbang_i2c.c | 2 +- hw/i2c/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i2c/bitbang_i2c.c +1 -1
@@ -70,7 +70,7 @@ static int bitbang_i2c_ret(bitbang_i2c_interface *i2c, int level)return level & i2c->last_data; } -/* Leave device data pin unodified. */ +/* Leave device data pin unmodified. */ static int bitbang_i2c_nop (bitbang_i2c_interface *i2c) {return bitbang_i2c_ret (i2c, i2c->device_out);
hw/i2c/trace-events +1 -1
@@ -5,7 +5,7 @@ bitbang_i2c_state(const char *old_state, const char *new_state) "state %s -> %s" bitbang_i2c_addr(uint8_t addr) "Address 0x%02x" bitbang_i2c_send(uint8_t byte) "TX byte 0x%02x" bitbang_i2c_recv(uint8_t byte) "RX byte 0x%02x" -bitbang_i2c_data(unsigned dat, unsigned clk, unsigned old_out, unsigned new_out) "dat %u clk %u out %u -> %u" +bitbang_i2c_data(unsigned clk, unsigned dat, unsigned old_out, unsigned new_out) "clk %u dat %u out %u -> %u" # core.c
Signature · 1 line
2.30.9