selftests:connector: Fix input argument error paths to skip
Subsystems (3)
Shuah Khan
maintainerPATCH RESEND v2 1/1 selftests:connector: Fix input argument error paths to skip
Fix input argument parsing paths to skip from their error legs. This fix helps to avoid false test failure reports without running the test.
---
v2: Removed root check based on Anjali's review comments. Add netdev to RESEND
tools/testing/selftests/connector/proc_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/connector/proc_filter.c +2 -2
@@ -248,7 +248,7 @@ int main(int argc, char *argv[])if (argc >2 ) {printf ("Expected 0(assume no-filter) or 1 argument(-f)\n" ); -exit (1 ); +exit (KSFT_SKIP ); }if (argc ==2 ) {
@@ -256,7 +256,7 @@ int main(int argc, char *argv[]) filter =1 ; }else {printf ("Valid option : -f (for filter feature)\n" ); -exit (1 ); +exit (KSFT_SKIP ); } }
Signature · 1 line
2.39.2
Shuah Khan
maintainerQuoted 26 lines · Shuah Khan
Fix input argument parsing paths to skip from their error legs. This fix helps to avoid false test failure reports without running the test.
Signed-off-by Shuah Khan <[email protected]>---
v2: Removed root check based on Anjali's review comments. Add netdev to RESENDtools/testing/selftests/connector/proc_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/connector/proc_filter.c +1
-1@@ -248,7 +248,7 @@ int main(int argc, char *argv[])if (argc >2 ) {printf ("Expected 0(assume no-filter) or 1 argument(-f)\n" ); -exit (1 ); +exit (KSFT_SKIP ); }if (argc ==2 ) {
tools/testing/selftests/connector/proc_filter.c int main(int argc, char *argv[]) · line 262
Quoted 8 lines
tools/testing/selftests/connector/proc_filter.c +1
-1@@ -256,7 +256,7 @@ int main(int argc, char *argv[]) filter =1 ; }else {printf ("Valid option : -f (for filter feature)\n" ); -exit (1 ); +exit (KSFT_SKIP ); } }
Hi Jakub,
I sent v2 for patch 3 in the series. Do you want me to send the entire series again with this revised 3rd patch.
thanks,
-- Shuah
Jakub Kicinski
maintainerQuoted 2 lines · On Mon, 31 Jul 2023 14:23:45 -0600 Shuah Khan wrote:
I sent v2 for patch 3 in the series. Do you want me to send the entire series again with this revised 3rd patch.
I think it's all good. The build bot couldn't parse the partial series but the patches are pretty trivial, so low risk of breakage.
Anjali, it would be good to get your Review / Ack tag on this patch, since you're the author.
Quoted 9 lines · Shuah Khan
Fix input argument parsing paths to skip from their error legs. This fix helps to avoid false test failure reports without running the test.
Signed-off-by Shuah Khan <[email protected]>
Quoted 32 lines
---
v2: Removed root check based on Anjali's review comments. Add netdev to RESEND
tools/testing/selftests/connector/proc_filter.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/connector/proc_filter.c +2
-2@@ -248,7 +248,7 @@ int main(int argc, char *argv[])if (argc >2 ) {printf ("Expected 0(assume no-filter) or 1 argument(-f)\n" ); -exit (1 ); +exit (KSFT_SKIP ); }if (argc ==2 ) {@@ -256,7 +256,7 @@ int main(int argc, char *argv[]) filter =1 ; }else {printf ("Valid option : -f (for filter feature)\n" ); -exit (1 ); +exit (KSFT_SKIP ); } }Signature · 1 line
2.39.2
Quoted 13 lines · Jakub Kicinski
Quoted 2 lines · On Mon, 31 Jul 2023 14:23:45 -0600 Shuah Khan wrote:
I sent v2 for patch 3 in the series. Do you want me to send the entire series again with this revised 3rd patch.
I think it's all good. The build bot couldn't parse the partial series but the patches are pretty trivial, so low risk of breakage.
Anjali, it would be good to get your Review / Ack tag on this patch, since you're the author.
Yes done.
Anjali
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Fri, 28 Jul 2023 18:24:03 -0600 you wrote:
Fix input argument parsing paths to skip from their error legs. This fix helps to avoid false test failure reports without running the test.
Signed-off-by Shuah Khan <[email protected]>---
v2: Removed root check based on Anjali's review comments. Add netdev to RESEND[...]
Here is the summary with links:
- [RESEND,v2] selftests:connector: Fix input argument error paths to skip
https://git.kernel.org/netdev/net-next/c/04786c0659db
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html