Skip to contentSkip to conversation

mips: dts: ralink: reorder MT7621 clocks in Ethernet block

PATCH In review Rafał Miłecki 4 participants 5 messages Jul 29, 2023 – Aug 1, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mips: dts: ralink: reorder MT7621 clocks in Ethernet block

From: Rafał Miłecki <[email protected]>

Use order as specified in the binding (first "ethif" then "fe").

This fixes:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml

Fixes 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/mips/boot/dts/ralink/mt7621.dtsi +3 -3
index 7caed0d14f11..73035d4f4cc1 100644
@@ -300,9 +300,9 @@ ethernet: ethernet@1e100000 {
 		compatible = "mediatek,mt7621-eth";
 		reg = <0x1e100000 0x10000>;
 
-		clocks = <&sysc MT7621_CLK_FE>,
-			 <&sysc MT7621_CLK_ETH>;
-		clock-names = "fe", "ethif";
+		clocks = <&sysc MT7621_CLK_ETH>,
+			 <&sysc MT7621_CLK_FE>;
+		clock-names = "ethif", "fe";
 
 		#address-cells = <1>;
 		#size-cells = <0>;
Signature · 1 line
2.35.3
#1 lore raw
Quoted 4 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Use order as specified in the binding (first "ethif" then "fe").

Quoted 8 lines

This fixes:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml

Fixes 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")

I'm not sure if I should agree with this patch. The relevant parts of the schema for mediatek,mt7621-eth were added way later than the existing bindings on mt7621.dtsi. Why don't we address this on the schema along with a bunch of other issues the patch for mediatek,mt7621-eth brought?

Arınç

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Rafał Miłecki

Il 29/07/23 13:04, Rafał Miłecki ha scritto:

Quoted 4 lines

From: Rafał Miłecki <[email protected]>

Use order as specified in the binding (first "ethif" then "fe").

Quoted 8 lines

This fixes:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml

Fixes 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Rafał Miłecki
Quoted 11 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Use order as specified in the binding (first "ethif" then "fe").

This fixes:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml

Quoted 6 lines
Fixes 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Thanks,
Sergio Paracuellos

#2 lore raw
In reply to Arınç ÜNAL

I haven't received anything arguing with this so my answer is still no.

Also, this patch changes the lines introduced with b2f471a26721 ("staging: mt7621-dts: make use of new 'mt7621-clk'").

Arınç

Quoted 17 lines · Arınç ÜNAL
Quoted 4 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Use order as specified in the binding (first "ethif" then "fe").

Quoted 8 lines

This fixes:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml

Fixes 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")

I'm not sure if I should agree with this patch. The relevant parts of the schema for mediatek,mt7621-eth were added way later than the existing bindings on mt7621.dtsi. Why don't we address this on the schema along with a bunch of other issues the patch for mediatek,mt7621-eth brought?

Arınç