Skip to contentSkip to conversation

s390/ptrace: add missing linux/const.h include

PATCH In review Heiko Carstens 2 participants 3 messages Jul 31, 2023 – Aug 1, 2023 s390

lore
Share & tools
lore

Heiko Carstens

author maintainer
#0 lore raw

PATCH 1/1 s390/ptrace: add missing linux/const.h include

Adrian Reber reported the following CRIU build bug after commit b8af5999779d ("s390/ptrace: make all psw related defines also available for asm"):

compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)

  523 |         if (psw->mask & PSW_MASK_RI) {
      |                         ^~~~~~~~~~~

Add the missing linux/const.h include to fix this.

Fixes b8af5999779d ("s390/ptrace: make all psw related defines also available for asm")
---
 arch/s390/include/uapi/asm/ptrace.h | 2 ++
 1 file changed, 2 insertions(+)
arch/s390/include/uapi/asm/ptrace.h +2 -0
index f0fe3bcc78a8..bb0826024bb9 100644
@@ -8,6 +8,8 @@
 #ifndef _UAPI_S390_PTRACE_H
 #define _UAPI_S390_PTRACE_H
 
+#include <linux/const.h>
+
 /*
  * Offsets in the user_regs_struct. They are used for the ptrace
  * system call and in entry.S
Signature · 1 line
2.39.2
#1 lore raw
Quoted 10 lines · Heiko Carstens

Adrian Reber reported the following CRIU build bug after commit b8af5999779d ("s390/ptrace: make all psw related defines also available for asm"):

compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)

  523 |         if (psw->mask & PSW_MASK_RI) {
      |                         ^~~~~~~~~~~

Add the missing linux/const.h include to fix this.

Thanks. That fixes the build failure for me.

Adrian

Quoted 25 lines
Fixes b8af5999779d ("s390/ptrace: make all psw related defines also available for asm")
---
 arch/s390/include/uapi/asm/ptrace.h | 2 ++
 1 file changed, 2 insertions(+)
arch/s390/include/uapi/asm/ptrace.h +2 -0
index f0fe3bcc78a8..bb0826024bb9 100644
@@ -8,6 +8,8 @@
 #ifndef _UAPI_S390_PTRACE_H
 #define _UAPI_S390_PTRACE_H
 
+#include <linux/const.h>
+
 /*
  * Offsets in the user_regs_struct. They are used for the ptrace
  * system call and in entry.S
Signature · 1 line
2.39.2
author maintainer
#2 lore raw
Quoted 5 lines · Adrian Reber
Quoted 4 lines · Heiko Carstens

Adrian Reber reported the following CRIU build bug after commit b8af5999779d ("s390/ptrace: make all psw related defines also available for asm"):

Quoted 8 lines
Quoted 6 lines

compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)

  523 |         if (psw->mask & PSW_MASK_RI) {
      |                         ^~~~~~~~~~~

Add the missing linux/const.h include to fix this.

Thanks. That fixes the build failure for me.

Thanks for verifying. This should make it into rc5.