Skip to contentSkip to conversation

gpio: timberdale: remove unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Aug 1, 2023 – Aug 3, 2023 GPIO

lore
Share & tools
lore

Andrei Coardos

author
#0 lore raw

PATCH 1/1 gpio: timberdale: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/gpio/gpio-timberdale.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-timberdale.c +0 -2
index de14949a3fe5..bbd9e9191199 100644
@@ -256,8 +256,6 @@ static int timbgpio_probe(struct platform_device *pdev)
 	if (err)
 		return err;
 
-	platform_set_drvdata(pdev, tgpio);
-
 	/* make sure to disable interrupts */
 	iowrite32(0x0, tgpio->membase + TGPIO_IER);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 26 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/gpio/gpio-timberdale.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-timberdale.c +0 -3
index de14949a3fe5..bbd9e9191199 100644
@@ -256,8 +256,6 @@ static int timbgpio_probe(struct platform_device *pdev)
        if (err)
                return err;
 
-       platform_set_drvdata(pdev, tgpio);
-
        /* make sure to disable interrupts */
        iowrite32(0x0, tgpio->membase + TGPIO_IER);
 
--
Quoted 2 lines

2.34.1

Applied, thanks!

Bart