gpio: sifive: remove unneeded call to platform_set_drvdata()
Subsystems (3)
PATCH 1/1 gpio: sifive: remove unneeded call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/gpio/gpio-sifive.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpio/gpio-sifive.c +0 -1
@@ -259,7 +259,6 @@ static int sifive_gpio_probe(struct platform_device *pdev) girq->child_to_parent_hwirq = sifive_gpio_child_to_parent_hwirq; girq->handler = handle_bad_irq; girq->default_type =IRQ_TYPE_NONE ; -platform_set_drvdata (pdev, priv);return gpiochip_add_data (&chip->gc, chip); }
Signature · 7 lines
2.34.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 4 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 25 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Reviewed-by Alexandru Ardelean <[email protected]>Signed-off-by Andrei Coardos <[email protected]>--- drivers/gpio/gpio-sifive.c | 1 - 1 file changed, 1 deletion(-)drivers/gpio/gpio-sifive.c +0
-2@@ -259,7 +259,6 @@ static int sifive_gpio_probe(struct platform_device *pdev) girq->child_to_parent_hwirq = sifive_gpio_child_to_parent_hwirq; girq->handler = handle_bad_irq; girq->default_type =IRQ_TYPE_NONE ; -platform_set_drvdata (pdev, priv);return gpiochip_add_data (&chip->gc, chip); } --
Quoted 2 lines
2.34.1
This patch does not correspond with the code upstream. Please verify.
Bart
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv