Skip to contentSkip to conversation

Rebranding dom0less to hyperlaunch part 1

PATCH Superseded Daniel P. Smith 3 participants 9 messages Aug 1, 2023 – Aug 3, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Rebranding dom0less to hyperlaunch part 1

This is the first series of the proposal put forth on moving to have dom0less folded under and thus rebranded as a part of hyperlaunch. As laid out in the proposal, the series updates the hyperlaunch device tree documentation and applies the general refactoring of FDT parsing to make core logic common.

Daniel P. Smith (2):
docs: update hyperlaunch device tree
fdt: make fdt handling reusable across arch

 MAINTAINERS                                   |  11 +
 .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++--------
 xen/arch/arm/bootfdt.c                        | 141 +----
 xen/common/Kconfig                            |   4 +
 xen/common/Makefile                           |   3 +-
 xen/common/fdt.c                              | 153 +++++
 xen/include/xen/device_tree.h                 |  50 +-
 xen/include/xen/fdt.h                         |  79 +++
 8 files changed, 551 insertions(+), 456 deletions(-)
 create mode 100644 xen/common/fdt.c
 create mode 100644 xen/include/xen/fdt.h
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/2 docs: update hyperlaunch device tree

With on going development of hyperlaunch, changes to the device tree definitions has been necessary. This commit updates the specification for all current changes along with changes expected to be made in finalizing the capability.

This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places this documentation under its purview. It also reserves the path xen/common/domain-builder for the hyperlaunch domain builder code base.

---
 MAINTAINERS                                   |   9 +
 .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++--------
 2 files changed, 309 insertions(+), 266 deletions(-)
MAINTAINERS +9 -0
index d8a02a6c19..694412a961 100644
@@ -332,6 +332,15 @@ M:	Nick Rosbrook <[email protected]>
 S:	Maintained
 F:	tools/golang
 
+HYPERLAUNCH
+M:	Daniel P. Smith <[email protected]>
+M:	Christopher Clark <[email protected]>
+W:	https://wiki.xenproject.org/wiki/Hyperlaunch
+S:	Supported
+F:	docs/design/launch/hyperlaunch.rst
+F:	docs/design/launch/hyperlaunch-devicetree.rst
+F:	xen/common/domain-builder/
+
 HYPFS
 M:	Juergen Gross <[email protected]>
 S:	Supported
docs/designs/launch/hyperlaunch-devicetree.rst +300 -266

641 lines not on this page · raw message

Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 fdt: make fdt handling reusable across arch

In reply to Daniel P. Smith

This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch.

---
 MAINTAINERS                   |   2 +
 xen/arch/arm/bootfdt.c        | 141 +------------------------------
 xen/common/Kconfig            |   4 +
 xen/common/Makefile           |   3 +-
 xen/common/fdt.c              | 153 ++++++++++++++++++++++++++++++++++
 xen/include/xen/device_tree.h |  50 +----------
 xen/include/xen/fdt.h         |  79 ++++++++++++++++++
 7 files changed, 242 insertions(+), 190 deletions(-)
 create mode 100644 xen/common/fdt.c
 create mode 100644 xen/include/xen/fdt.h
MAINTAINERS +2 -0
index 694412a961..b7fc3ed805 100644
@@ -303,7 +303,9 @@ F:	xen/common/libfdt/
 F:	xen/common/device_tree.c
 F:	xen/include/xen/libfdt/
 F:	xen/include/xen/device_tree.h
+F:	include/xen/fdt.h
 F:	xen/drivers/passthrough/device_tree.c
+F:	common/fdt.c
 
 ECLAIR
 R:	Simone Ballarin <[email protected]>
xen/arch/arm/bootfdt.c +1 -140

157 lines not on this page · raw message

xen/common/Kconfig +4 -0
index 0d248ab941..e2fdb3cbc3 100644
@@ -38,8 +38,12 @@ config HAS_ALTERNATIVE
 config HAS_COMPAT
 	bool
 
+config CORE_DEVICE_TREE
+	bool
+
 config HAS_DEVICE_TREE
 	bool
+	select CORE_DEVICE_TREE
 
 config HAS_EX_TABLE
 	bool
xen/common/Makefile +2 -1
index 46049eac35..fd3769e1c6 100644
@@ -11,6 +11,7 @@ obj-y += domain.o
 obj-y += event_2l.o
 obj-y += event_channel.o
 obj-y += event_fifo.o
+obj-$(CONFIG_CORE_DEVICE_TREE) += fdt.o
 obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o
 obj-$(CONFIG_GRANT_TABLE) += grant_table.o
 obj-y += guestcopy.o
@@ -75,7 +76,7 @@ obj-y += sched/
 obj-$(CONFIG_UBSAN) += ubsan/
 
 obj-$(CONFIG_NEEDS_LIBELF) += libelf/
-obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/
+obj-$(CONFIG_CORE_DEVICE_TREE) += libfdt/
 
 CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(objtree)/)$(KCONFIG_CONFIG)
 $(obj)/config.gz: $(CONF_FILE)
xen/common/fdt.c new file +153 -0

153 lines not on this page · raw message

xen/include/xen/device_tree.h +1 -49

87 lines not on this page · raw message

xen/include/xen/fdt.h new file +79 -0

79 lines not on this page · raw message

Signature · 1 line
2.20.1
#3 lore raw

RE: [PATCH 2/2] fdt: make fdt handling reusable across arch

Hi Daniel,

Quoted 55 lines

-----Original Message-----
Subject: [PATCH 2/2] fdt: make fdt handling reusable across arch

This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch.

---
 MAINTAINERS                   |   2 +
 xen/arch/arm/bootfdt.c        | 141 +------------------------------
 xen/common/Kconfig            |   4 +
 xen/common/Makefile           |   3 +-
 xen/common/fdt.c              | 153 ++++++++++++++++++++++++++++++++++
 xen/include/xen/device_tree.h |  50 +----------
 xen/include/xen/fdt.h         |  79 ++++++++++++++++++
 7 files changed, 242 insertions(+), 190 deletions(-)
 create mode 100644 xen/common/fdt.c
 create mode 100644 xen/include/xen/fdt.h
xen/common/fdt.c new file +34 -0
+void __init device_tree_get_reg(
+    const __be32 **cell, uint32_t address_cells, uint32_t size_cells,
+    paddr_t *start, paddr_t *size)
+{
+    uint64_t dt_start, dt_size;
+
+    /*
+     * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit.
+     * Thus, there is an implicit cast from uint64_t to paddr_t.
+     */
+    dt_start = dt_next_cell(address_cells, cell);
+    dt_size = dt_next_cell(size_cells, cell);
+
+    if ( dt_start != (paddr_t)dt_start )
+    {
+        printk("Physical address greater than max width supported\n");
+        WARN();
+    }
+
+    if ( dt_size != (paddr_t)dt_size )
+    {
+        printk("Physical size greater than max width supported\n");
+        WARN();
+    }
+
+    /*
+     * Xen will truncate the address/size if it is greater than the maximum
+     * supported width and it will give an appropriate warning.
+     */
+    *start = dt_start;
+    *size = dt_size;
+}
+
+u32 __init device_tree_get_u32(

xen/common/fdt.c line 95

Quoted 10 lines
xen/common/fdt.c new file +10 -0
+    const void *fdt, int node, const char *prop_name, u32 dflt)
+{
+    const struct fdt_property *prop;
+
+    prop = fdt_get_property(fdt, node, prop_name, NULL);
+    if ( !prop || prop->len < sizeof(u32) )
+        return dflt;
+
+    return fdt32_to_cpu(*(uint32_t*)prop->data);
+}

When I tested this patch by our internal CI (I applied this patch on top of today's staging:
c2026b88b5 xen/arm/IRQ: uniform irq_set_affinity() with x86 version), there are some build errors as below:

aarch64-linux-gnu-gcc -MMD -MP -MF ./.asm-offsets.s.d -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O2 -fomit-frame-pointer -nostdinc -fno-builtin -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla -pipe -D__XEN__ -include /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/config.h -mcpu=generic -mgeneral-regs-only -mno-outline-atomics -I./include -I./arch/arm/include -I/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include -I/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include -fno-pie -fno-stack-protector -fno-exceptions -fno-asynchronous-unwind-tables -Wnested-externs -S -g0 -o asm-offsets.s.new -MQ asm-offsets.s /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:13:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setup.h:162:6: error: redundant redeclaration of 'device_tree_get_reg' [-Werror=redundant-decls]
162 | void device_tree_get_reg(const __be32 **cell, uint32_t address_cells,

      |      ^~~~~~~~~~~~~~~~~~~

In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/device_tree.h:17,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/smp.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/smp.h:4,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/rwlock.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/sched.h:7,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:9:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:64:13: note: previous declaration of 'device_tree_get_reg' with type 'void(const __be32 **, u32, u32, u64 *, u64 *)' {aka 'void(const unsigned int **, unsigned int, unsigned int, long unsigned int *, long unsigned int *)'}
64 | void __init device_tree_get_reg(

      |             ^~~~~~~~~~~~~~~~~~~
In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:13:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setup.h:165:5: error: redundant redeclaration of 'device_tree_get_u32' [-Werror=redundant-decls]
  165 | u32 device_tree_get_u32(const void *fdt, int node,
      |     ^~~~~~~~~~~~~~~~~~~

In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/device_tree.h:17,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/smp.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/smp.h:4,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/rwlock.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/sched.h:7,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:9:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:68:12: note: previous declaration of 'device_tree_get_u32' with type 'u32(const void *, int, const char *, u32)' {aka 'unsigned int(const void *, int, const char *, unsigned int)'}
68 | u32 __init device_tree_get_u32(

      |            ^~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors
make[2]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/./build.mk:45: asm-offsets.s] Error 1 make[1]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/Makefile:597: xen] Error 2 make[1]: Leaving directory '/jenkins/workspace/ais-xenbits-xen/build/xen-fvp-base'
make: *** [Makefile:183: __sub-make] Error 2
make: Leaving directory '/jenkins/workspace/ais-xenbits-xen/layers/xen/xen'

The staging itself passed the CI check. Did I miss some context to make this patch works? Could you please provide some hints? Thanks in advance!

Kind regards,
Henry

#4 lore raw

Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

Quoted 1 line · Henry Wang

Hi Daniel,

Hey Henry!

Quoted 105 lines
Quoted 55 lines

-----Original Message-----
Subject: [PATCH 2/2] fdt: make fdt handling reusable across arch

This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch.

---
  MAINTAINERS                   |   2 +
  xen/arch/arm/bootfdt.c        | 141 +------------------------------
  xen/common/Kconfig            |   4 +
  xen/common/Makefile           |   3 +-
  xen/common/fdt.c              | 153 ++++++++++++++++++++++++++++++++++
  xen/include/xen/device_tree.h |  50 +----------
  xen/include/xen/fdt.h         |  79 ++++++++++++++++++
  7 files changed, 242 insertions(+), 190 deletions(-)

create mode 100644 xen/common/fdt.c
create mode 100644 xen/include/xen/fdt.h

xen/common/fdt.c new file +34 -0
+void __init device_tree_get_reg(
+    const __be32 **cell, uint32_t address_cells, uint32_t size_cells,
+    paddr_t *start, paddr_t *size)
+{
+    uint64_t dt_start, dt_size;
+
+    /*
+     * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit.
+     * Thus, there is an implicit cast from uint64_t to paddr_t.
+     */
+    dt_start = dt_next_cell(address_cells, cell);
+    dt_size = dt_next_cell(size_cells, cell);
+
+    if ( dt_start != (paddr_t)dt_start )
+    {
+        printk("Physical address greater than max width supported\n");
+        WARN();
+    }
+
+    if ( dt_size != (paddr_t)dt_size )
+    {
+        printk("Physical size greater than max width supported\n");
+        WARN();
+    }
+
+    /*
+     * Xen will truncate the address/size if it is greater than the maximum
+     * supported width and it will give an appropriate warning.
+     */
+    *start = dt_start;
+    *size = dt_size;
+}
+
+u32 __init device_tree_get_u32(

xen/common/fdt.c line 95

Quoted 10 lines
xen/common/fdt.c new file +10 -0
+    const void *fdt, int node, const char *prop_name, u32 dflt)
+{
+    const struct fdt_property *prop;
+
+    prop = fdt_get_property(fdt, node, prop_name, NULL);
+    if ( !prop || prop->len < sizeof(u32) )
+        return dflt;
+
+    return fdt32_to_cpu(*(uint32_t*)prop->data);
+}

When I tested this patch by our internal CI (I applied this patch on top of today's staging:
c2026b88b5 xen/arm/IRQ: uniform irq_set_affinity() with x86 version), there are some build errors as below:

aarch64-linux-gnu-gcc -MMD -MP -MF ./.asm-offsets.s.d -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O2 -fomit-frame-pointer -nostdinc -fno-builtin -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla -pipe -D__XEN__ -include /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/config.h -mcpu=generic -mgeneral-regs-only -mno-outline-atomics -I./include -I./arch/arm/include -I/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include -I/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include -fno-pie -fno-stack-protector -fno-exceptions -fno-asynchronous-unwind-tables -Wnested-externs -S -g0 -o asm-offsets.s.new -MQ asm-offsets.s /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:13:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setup.h:162:6: error: redundant redeclaration of 'device_tree_get_reg' [-Werror=redundant-decls]
162 | void device_tree_get_reg(const __be32 **cell, uint32_t address_cells,

       |      ^~~~~~~~~~~~~~~~~~~

In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/device_tree.h:17,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/smp.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/smp.h:4,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/rwlock.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/sched.h:7,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:9:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:64:13: note: previous declaration of 'device_tree_get_reg' with type 'void(const __be32 **, u32, u32, u64 *, u64 *)' {aka 'void(const unsigned int **, unsigned int, unsigned int, long unsigned int *, long unsigned int *)'}

    64 | void __init device_tree_get_reg(
       |             ^~~~~~~~~~~~~~~~~~~
In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:13:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setup.h:165:5: error: redundant redeclaration of 'device_tree_get_u32' [-Werror=redundant-decls]
   165 | u32 device_tree_get_u32(const void *fdt, int node,
       |     ^~~~~~~~~~~~~~~~~~~

In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/device_tree.h:17,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/smp.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/smp.h:4,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/rwlock.h:6,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/sched.h:7,
from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:9:
/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:68:12: note: previous declaration of 'device_tree_get_u32' with type 'u32(const void *, int, const char *, u32)' {aka 'unsigned int(const void *, int, const char *, unsigned int)'}

    68 | u32 __init device_tree_get_u32(
       |            ^~~~~~~~~~~~~~~~~~~

cc1: all warnings being treated as errors
make[2]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/./build.mk:45: asm-offsets.s] Error 1 make[1]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/Makefile:597: xen] Error 2 make[1]: Leaving directory '/jenkins/workspace/ais-xenbits-xen/build/xen-fvp-base'
make: *** [Makefile:183: __sub-make] Error 2
make: Leaving directory '/jenkins/workspace/ais-xenbits-xen/layers/xen/xen'

Quoted 2 lines

The staging itself passed the CI check. Did I miss some context to make this patch works? Could you please provide some hints? Thanks in advance!

Nope you are correct, I now need to go back and look if I sent patches out of the wrong branch or if I really did miss cleaning up the original declarations in the Arm tree. I fairly confident I made sure gitlab-ci passed before I cut the patches for sending, but since I had three different series in flight, I may have gotten jumbled. Apologies for the unnecessary churn here.

V/r,
Daniel P. Smith

#5 lore raw

RE: [PATCH 2/2] fdt: make fdt handling reusable across arch

Hi Daniel,

Quoted 6 lines

-----Original Message-----
Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

Quoted 2 lines

make: *** [Makefile:183: __sub-make] Error 2
make: Leaving directory '/jenkins/workspace/ais-xenbits-

xen/layers/xen/xen'

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

The staging itself passed the CI check. Did I miss some context to make this patch works? Could you please provide some hints? Thanks in advance!

Nope you are correct, I now need to go back and look if I sent patches out of the wrong branch or if I really did miss cleaning up the original declarations in the Arm tree. I fairly confident I made sure gitlab-ci passed before I cut the patches for sending,

I think so, as I saw something related to the Gitlab-CI runners discussion in IRC yesterday.

Quoted 3 lines

but since I had three
different series in flight, I may have gotten jumbled. Apologies for the unnecessary churn here.

No problem at all, I am more than happy to do the test for your v2 series once it is in the mailing list :))

Kind regards,
Henry

Quoted 3 lines

V/r,
Daniel P. Smith

#6 lore raw

Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

Quoted 19 lines · Henry Wang

Hi Daniel,

Quoted 6 lines

-----Original Message-----
Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

Quoted 2 lines

make: *** [Makefile:183: __sub-make] Error 2
make: Leaving directory '/jenkins/workspace/ais-xenbits-

xen/layers/xen/xen'

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

The staging itself passed the CI check. Did I miss some context to make this patch works? Could you please provide some hints? Thanks in advance!

Nope you are correct, I now need to go back and look if I sent patches out of the wrong branch or if I really did miss cleaning up the original declarations in the Arm tree. I fairly confident I made sure gitlab-ci passed before I cut the patches for sending,

I think so, as I saw something related to the Gitlab-CI runners discussion in IRC yesterday.

Quoted 6 lines
Quoted 3 lines

but since I had three
different series in flight, I may have gotten jumbled. Apologies for the unnecessary churn here.

No problem at all, I am more than happy to do the test for your v2 series once it is in the mailing list :))

Great! Thank you!

v/r,
dps

#7 lore raw

Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

In reply to Daniel P. Smith
Quoted 6 lines · Daniel P. Smith

This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch.

Quoted 11 lines
---
 MAINTAINERS                   |   2 +
 xen/arch/arm/bootfdt.c        | 141 +------------------------------
 xen/common/Kconfig            |   4 +
 xen/common/Makefile           |   3 +-
 xen/common/fdt.c              | 153 ++++++++++++++++++++++++++++++++++
 xen/include/xen/device_tree.h |  50 +----------
 xen/include/xen/fdt.h         |  79 ++++++++++++++++++
 7 files changed, 242 insertions(+), 190 deletions(-)
 create mode 100644 xen/common/fdt.c
 create mode 100644 xen/include/xen/fdt.h

The filename here ...

MAINTAINERS F: xen/common/libfdt/ · line 308

Quoted 9 lines
MAINTAINERS +2 -0
@@ -303,7 +303,9 @@ F:	xen/common/libfdt/
 F:	xen/common/device_tree.c
 F:	xen/include/xen/libfdt/
 F:	xen/include/xen/device_tree.h
+F:	include/xen/fdt.h
 F:	xen/drivers/passthrough/device_tree.c
+F:	common/fdt.c

... don't match the additions here. Also please insert in alphabetically sorted order, ignoring the previously misplaced final entry (entries), unless you want to take the opportunity and get things properly sorted again in this section.

Jan

#8 lore raw

Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

Quoted 21 lines · Jan Beulich
Quoted 15 lines · Daniel P. Smith

This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch.

---
  MAINTAINERS                   |   2 +
  xen/arch/arm/bootfdt.c        | 141 +------------------------------
  xen/common/Kconfig            |   4 +
  xen/common/Makefile           |   3 +-
  xen/common/fdt.c              | 153 ++++++++++++++++++++++++++++++++++
  xen/include/xen/device_tree.h |  50 +----------
  xen/include/xen/fdt.h         |  79 ++++++++++++++++++
  7 files changed, 242 insertions(+), 190 deletions(-)
Quoted 2 lines

create mode 100644 xen/common/fdt.c
create mode 100644 xen/include/xen/fdt.h

The filename here ...

Quoted 14 lines

MAINTAINERS F: xen/common/libfdt/ · line 308

Quoted 9 lines
MAINTAINERS +2 -0
@@ -303,7 +303,9 @@ F:	xen/common/libfdt/
  F:	xen/common/device_tree.c
  F:	xen/include/xen/libfdt/
  F:	xen/include/xen/device_tree.h
+F:	include/xen/fdt.h
  F:	xen/drivers/passthrough/device_tree.c
+F:	common/fdt.c

... don't match the additions here. Also please insert in alphabetically sorted order, ignoring the previously misplaced final entry (entries), unless you want to take the opportunity and get things properly sorted again in this section.

Ack, will fix along with ensuring they are properly sorted.

v/r,
dps