Skip to contentSkip to conversation

i3c/master: cmd_v1: Fix the exit criteria for the daa procedure

PATCH Applied Billy Tsai 2 participants 2 messages Aug 2, 2023 – Aug 10, 2023 I3C

lore
Share & tools
lore

Billy Tsai

author
#0 lore raw

PATCH 1/1 i3c/master: cmd_v1: Fix the exit criteria for the daa procedure

The exit criteria for the DAA should check if the data length is equal to 1, instead of checking if the response status is equal to 1.

---
 drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +1 -1
index d97c3175e0e2..6a781f89b0e4 100644
@@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
 			break;
 		}
 		if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
-		    RESP_STATUS(xfer[0].response) == 1) {
+		    RESP_DATA_LENGTH(xfer->response) == 1) {
 			ret = 0;  /* no more devices to be assigned */
 			break;
 		}
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 4 lines · Billy Tsai

The exit criteria for the DAA should check if the data length is equal to 1, instead of checking if the response status is equal to 1.

Applied, thanks!

[1/1] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure

      commit: cbf871e6d8ce23dd4d458d8b7ab9d4a267e7bc03

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com