Skip to contentSkip to conversation

reset: bcm6345: remove unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 2 participants 3 messages Aug 3, 2023 – Aug 8, 2023 Reset controller framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: bcm6345: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/reset/reset-bcm6345.c | 2 --
 1 file changed, 2 deletions(-)
drivers/reset/reset-bcm6345.c +0 -2
index ac6c7ad1deda..aa9353439e70 100644
@@ -102,8 +102,6 @@ static int bcm6345_reset_probe(struct platform_device *pdev)
 	if (!bcm6345_reset)
 		return -ENOMEM;
 
-	platform_set_drvdata(pdev, bcm6345_reset);
-
 	bcm6345_reset->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(bcm6345_reset->base))
 		return PTR_ERR(bcm6345_reset->base);
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 7 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Thank you, applied to reset/next.

regards
Philipp

maintainer Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 7 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Thank you, applied to reset/next.

regards
Philipp