Skip to contentSkip to conversation

automation: add missing "needs"

PATCH In review Stefano Stabellini 2 participants 3 messages Aug 4, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 automation: add missing "needs"

From: Stefano Stabellini <[email protected]>

The test artifacts export jobs don't need prerequisites, so we should specify "needs" with an empty array for them. That way, they are not going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete before continuing.

---
 automation/gitlab-ci/build.yaml | 1 +
 1 file changed, 1 insertion(+)
automation/gitlab-ci/build.yaml +1 -0
index f01e2c32bb..af64a53ead 100644
@@ -268,6 +268,7 @@
 
 .test-jobs-artifact-common:
   stage: build
+  needs: []
   except: !reference [.test-jobs-common, except]
 
 # Arm test artifacts
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Stefano Stabellini

From: Stefano Stabellini <[email protected]>

The test artifacts export jobs don't need prerequisites, so we should specify "needs" with an empty array for them. That way, they are not going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete before continuing.

Looking at the whole pipeline, I can see that now only ECLAIR jobs do not specify needs. Shouldn't we also add "needs: []" for them?

~Michal

#2 lore raw
Quoted 5 lines · Michal Orzel
Quoted 4 lines · Stefano Stabellini

From: Stefano Stabellini <[email protected]>

Quoted 7 lines
Quoted 6 lines

The test artifacts export jobs don't need prerequisites, so we should specify "needs" with an empty array for them. That way, they are not going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete before continuing.

Thanks!

Quoted 2 lines

Looking at the whole pipeline, I can see that now only ECLAIR jobs do not specify needs. Shouldn't we also add "needs: []" for them?

Yes it could be good for consistency and future-proofness, but technically it is not required now because the ECLAIR jobs come first.