drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:264 mlx5_devcom_send_event() warn: variable dereferenced before IS_ERR check 'devcom' (see line 259)
kernel test robot
build botBCC: [email protected]
CC: [email protected]
CC: Linux Memory Management List <[email protected]>
TO: Roi Dayan <[email protected]>
CC: Saeed Mahameed <[email protected]>
CC: Eli Cohen <[email protected]>
CC: Shay Drory <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: fb4327106e5250ee360d0d8b056c1eef7eeb9a98 commit: 88d162b479815f5d6b6a4ff5fdb07aec9dc6280c [4511/6910] net/mlx5: Devcom, Infrastructure changes
:::::: branch date: 22 hours ago
:::::: commit date: 7 days ago
config: x86_64-randconfig-m001-20230803 (https://download.01.org/0day-ci/archive/20230804/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230804/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:264 mlx5_devcom_send_event() warn: variable dereferenced before IS_ERR check 'devcom' (see line 259)
vim +/devcom +264 drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c
fadd59fc50d010 Aviv Heller 2018-12-04 254
88d162b479815f Roi Dayan 2023-05-04 255 int mlx5_devcom_send_event(struct mlx5_devcom_comp_dev *devcom,
e2a82bf8a42816 Shay Drory 2023-02-06 256 int event, int rollback_event,
fadd59fc50d010 Aviv Heller 2018-12-04 257 void *event_data)
fadd59fc50d010 Aviv Heller 2018-12-04 258 {
88d162b479815f Roi Dayan 2023-05-04 @259 struct mlx5_devcom_comp *comp = devcom->comp;
88d162b479815f Roi Dayan 2023-05-04 260 struct mlx5_devcom_comp_dev *pos;
88d162b479815f Roi Dayan 2023-05-04 261 int err = 0;
88d162b479815f Roi Dayan 2023-05-04 262 void *data;
fadd59fc50d010 Aviv Heller 2018-12-04 263
fadd59fc50d010 Aviv Heller 2018-12-04 @264 if (IS_ERR_OR_NULL(devcom))
88d162b479815f Roi Dayan 2023-05-04 265 return -ENODEV;
fadd59fc50d010 Aviv Heller 2018-12-04 266
fadd59fc50d010 Aviv Heller 2018-12-04 267 down_write(&comp->sem);
88d162b479815f Roi Dayan 2023-05-04 268 list_for_each_entry(pos, &comp->comp_dev_list_head, list) {
88d162b479815f Roi Dayan 2023-05-04 269 data = rcu_dereference_protected(pos->data, lockdep_is_held(&comp->sem));
691c041bf20899 Vlad Buslov 2023-03-31 270
88d162b479815f Roi Dayan 2023-05-04 271 if (pos != devcom && data) {
691c041bf20899 Vlad Buslov 2023-03-31 272 err = comp->handler(event, data, event_data);
e2a82bf8a42816 Shay Drory 2023-02-06 273 if (err)
e2a82bf8a42816 Shay Drory 2023-02-06 274 goto rollback;
e2a82bf8a42816 Shay Drory 2023-02-06 275 }
fadd59fc50d010 Aviv Heller 2018-12-04 276 }
e2a82bf8a42816 Shay Drory 2023-02-06 277
e2a82bf8a42816 Shay Drory 2023-02-06 278 up_write(&comp->sem);
e2a82bf8a42816 Shay Drory 2023-02-06 279 return 0;
e2a82bf8a42816 Shay Drory 2023-02-06 280
e2a82bf8a42816 Shay Drory 2023-02-06 281 rollback:
88d162b479815f Roi Dayan 2023-05-04 282 if (list_entry_is_head(pos, &comp->comp_dev_list_head, list))
88d162b479815f Roi Dayan 2023-05-04 283 goto out;
88d162b479815f Roi Dayan 2023-05-04 284 pos = list_prev_entry(pos, list);
88d162b479815f Roi Dayan 2023-05-04 285 list_for_each_entry_from_reverse(pos, &comp->comp_dev_list_head, list) {
88d162b479815f Roi Dayan 2023-05-04 286 data = rcu_dereference_protected(pos->data, lockdep_is_held(&comp->sem));
e2a82bf8a42816 Shay Drory 2023-02-06 287
88d162b479815f Roi Dayan 2023-05-04 288 if (pos != devcom && data)
e2a82bf8a42816 Shay Drory 2023-02-06 289 comp->handler(rollback_event, data, event_data);
691c041bf20899 Vlad Buslov 2023-03-31 290 }
88d162b479815f Roi Dayan 2023-05-04 291 out:
fadd59fc50d010 Aviv Heller 2018-12-04 292 up_write(&comp->sem);
fadd59fc50d010 Aviv Heller 2018-12-04 293 return err;
fadd59fc50d010 Aviv Heller 2018-12-04 294 }
fadd59fc50d010 Aviv Heller 2018-12-04 295 :::::: The code at line 264 was first introduced by commit
:::::: fadd59fc50d010145f251db583c7ccef37393d19 net/mlx5: Introduce inter-device communication mechanism
:::::: TO: Aviv Heller <[email protected]>
:::::: CC: Saeed Mahameed <[email protected]>
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki