Skip to contentSkip to conversation

hwrng: xgene: Add explicit io.h include

PATCH In review Rob Herring 2 participants 2 messages Aug 4, 2023 – Aug 5, 2023

Subsystems (2)
Crypto API Hardware random number generator core
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 hwrng: xgene: Add explicit io.h include

Commit 0788257aeebe ("hwrng: Explicitly include correct DT includes") removed an implicit include of io.h. On most architectures, there's still an implicit include of it, but not on s390. Enabling COMPILE_TEST in commit 1ce1cd8208ad ("hwrng: Enable COMPILE_TEST for more drivers") exposed this.

Fixes 0788257aeebe ("hwrng: Explicitly include correct DT includes")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Signed-off-by Rob Herring <[email protected]>
---
 drivers/char/hw_random/xgene-rng.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/hw_random/xgene-rng.c +1 -0
index c25bb169563d..99f4e86ac3e9 100644
@@ -14,6 +14,7 @@
 #include <linux/hw_random.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.40.1
maintainer
#1 lore raw
Quoted 6 lines · Rob Herring

Commit 0788257aeebe ("hwrng: Explicitly include correct DT includes") removed an implicit include of io.h. On most architectures, there's still an implicit include of it, but not on s390. Enabling COMPILE_TEST in commit 1ce1cd8208ad ("hwrng: Enable COMPILE_TEST for more drivers") exposed this.

Quoted 7 lines
Fixes 0788257aeebe ("hwrng: Explicitly include correct DT includes")
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Signed-off-by Rob Herring <[email protected]>
---
 drivers/char/hw_random/xgene-rng.c | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt