xfs: skip fragmentation tests when alwayscow mode is enabled, part 2
PATCH 1/1 xfs: skip fragmentation tests when alwayscow mode is enabled, part 2
From: Darrick J. Wong <[email protected]>
If the always_cow debugging flag is enabled, all file writes turn into copy writes. This dramatically ramps up fragmentation in the filesystem (intentionally!) so there's no point in complaining about fragmentation.
I missed these two in the original commit because readahead for md5sum would create large folios at the start of the file. This resulted in the fdatatasync after the random writes issuing writeback for the whole large folio, which reduced file fragmentation to the point where this test started passing.
With Ritesh's patchset implementing sub-folio dirty tracking, this test goes back to failing due to high fragmentation (as it did before large folios) so we need to mask these off too.
--- tests/xfs/180 | 1 + tests/xfs/208 | 1 + 2 files changed, 2 insertions(+)
tests/xfs/180 +1 -0
@@ -23,6 +23,7 @@ _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fiemap" _require_xfs_io_command "cowextsize" +_require_no_xfs_always_cow echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1
tests/xfs/208 +1 -0
@@ -26,6 +26,7 @@ _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fiemap" _require_xfs_io_command "cowextsize" +_require_no_xfs_always_cow echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1
Quoted 12 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If the
always_cowdebugging flag is enabled, all file writes turn into copy writes. This dramatically ramps up fragmentation in the filesystem (intentionally!) so there's no point in complaining about fragmentation.I missed these two in the original commit because readahead for md5sum would create large folios at the start of the file. This resulted in the fdatatasync after the random writes issuing writeback for the whole large folio, which reduced file fragmentation to the point where this test started passing.
Quoted 6 lines
With Ritesh's patchset implementing sub-folio dirty tracking, this test goes back to failing due to high fragmentation (as it did before large folios) so we need to mask these off too.
Signed-off-by Darrick J. Wong <[email protected]>---
Good to me, this patch is simple enough and no risk, will be inserted into the release directly tomorrow.
Quoted 29 lines
tests/xfs/180 | 1 + tests/xfs/208 | 1 + 2 files changed, 2 insertions(+)tests/xfs/180 +1
-0@@ -23,6 +23,7 @@ _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fiemap" _require_xfs_io_command "cowextsize" +_require_no_xfs_always_cow echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1tests/xfs/208 +1
-0@@ -26,6 +26,7 @@ _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fiemap" _require_xfs_io_command "cowextsize" +_require_no_xfs_always_cow echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1