Skip to contentSkip to conversation

arm64: dts: mediatek: Fix "status" values

PATCH RESEND Applied Rob Herring 5 participants 5 messages Aug 4, 2023 – Sep 13, 2023

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH RESEND 1/1 arm64: dts: mediatek: Fix "status" values

The defined value for "status" is "disabled", not "disable".

---
Arnd, Please take this directly I guess. I think Mediatek maintainership needs some help. Maybe AngeloGioacchino should be co-maintainer as that's the only response I seem to be getting.

I think for future .dts patches I will not bother splitting them up by sub-arch because it's a pain to chase down the maintainers to apply stuff in a timely manner. /rant

 arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +2 -2
index e4605d23fdc8..86cedb0bf1a9 100644
@@ -585,11 +585,11 @@ &pwrap {
 };
 
 &sata {
-	status = "disable";
+	status = "disabled";
 };
 
 &sata_phy {
-	status = "disable";
+	status = "disabled";
 };
 
 &spi0 {
Signature · 1 line
2.40.1
#1 lore raw
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:

Quoted 11 lines · On Fri, 4 Aug 2023 16:58:13 -0600 you wrote:

The defined value for "status" is "disabled", not "disable".

---
Arnd, Please take this directly I guess. I think Mediatek maintainership needs some help. Maybe AngeloGioacchino should be co-maintainer as that's the only response I seem to be getting.

[...]

Here is the summary with links:
- [RESEND] arm64: dts: mediatek: Fix "status" values

    https://git.kernel.org/soc/soc/c/c718f36c9bc3

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#2 lore raw
In reply to Rob Herring

Il 05/08/23 00:58, Rob Herring ha scritto:

Quoted 9 lines

The defined value for "status" is "disabled", not "disable".

---
Arnd, Please take this directly I guess. I think Mediatek maintainership needs some help. Maybe AngeloGioacchino should be co-maintainer as that's the only response I seem to be getting.

Sorry but I've seen this message just now as I've been on holiday in August.

Thing is, the MediaTek scene is starting to see more and more code, bringing an obvious increase in the amount of reviews to be done and in the required efforts to maintain the MTK bits - and we will possibly (hopefully) see even more of that.

If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be proud to become one.

Cheers,
Angelo

Quoted 26 lines

I think for future .dts patches I will not bother splitting them up by sub-arch because it's a pain to chase down the maintainers to apply stuff in a timely manner. /rant

  arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +2 -2
index e4605d23fdc8..86cedb0bf1a9 100644
@@ -585,11 +585,11 @@ &pwrap {
  };
 
  &sata {
-	status = "disable";
+	status = "disabled";
  };
 
  &sata_phy {
-	status = "disable";
+	status = "disabled";
  };
 
  &spi0 {
#3 lore raw
Quoted 18 lines · AngeloGioacchino Del Regno

Il 05/08/23 00:58, Rob Herring ha scritto:

Quoted 9 lines

The defined value for "status" is "disabled", not "disable".

---
Arnd, Please take this directly I guess. I think Mediatek maintainership needs some help. Maybe AngeloGioacchino should be co-maintainer as that's the only response I seem to be getting.

Sorry but I've seen this message just now as I've been on holiday in August.

Thing is, the MediaTek scene is starting to see more and more code, bringing an obvious increase in the amount of reviews to be done and in the required efforts to maintain the MTK bits - and we will possibly (hopefully) see even more of that.

Quoted 6 lines

If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be proud to become one.

Cheers,
Angelo

I started reviewing MediaTek patches for some months now, so I'm still new. From my PoV, I'm agree with Angelo when he say the amount of patch is increasing. I support Angelo if he wants to become a co-maintainer and continue to do my best to review patches. ;)

Quoted 25 lines
Quoted 23 lines

I think for future .dts patches I will not bother splitting them up by sub-arch because it's a pain to chase down the maintainers to apply stuff in a timely manner. /rant

  arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +2 -2
index e4605d23fdc8..86cedb0bf1a9 100644
@@ -585,11 +585,11 @@ &pwrap {
   };
   &sata {
-    status = "disable";
+    status = "disabled";
   };
   &sata_phy {
-    status = "disable";
+    status = "disabled";
   };
   &spi0 {
Signature · 2 lines
Regards,
Alexandre
#4 lore raw
Quoted 29 lines · Alexandre Mergnat
Quoted 25 lines · AngeloGioacchino Del Regno

Il 05/08/23 00:58, Rob Herring ha scritto:

Quoted 10 lines

The defined value for "status" is "disabled", not "disable".

Reviewed-by AngeloGioacchino Del Regno

<[email protected]>

---
Arnd, Please take this directly I guess. I think Mediatek maintainership needs some help. Maybe AngeloGioacchino should be co-maintainer as that's the only response I seem to be getting.

Sorry but I've seen this message just now as I've been on holiday in August.

Thing is, the MediaTek scene is starting to see more and more code, bringing
an obvious increase in the amount of reviews to be done and in the required efforts to maintain the MTK bits - and we will possibly (hopefully) see even
more of that.

If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be proud to become one.

Quoted 8 lines
Quoted 3 lines

Cheers,
Angelo

I started reviewing MediaTek patches for some months now, so I'm still new. From my PoV, I'm agree with Angelo when he say the amount of patch is increasing. I support Angelo if he wants to become a co-maintainer and continue to do my best to review patches. ;)

I might not have enough time to do a lot of reviews, but if help is needed for administrative tasks like queueing patches and sending pull requests, that's something I can do.

ChenYu

Quoted 31 lines
Quoted 8 lines
Quoted 8 lines

I think for future .dts patches I will not bother splitting them up by sub-arch because it's a pain to chase down the maintainers to apply stuff in a timely manner. /rant

  arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 18 lines
Quoted 6 lines
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +0 -0
index e4605d23fdc8..86cedb0bf1a9 100644

arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts &pwrap { · line 592

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +2 -2
@@ -585,11 +585,11 @@ &pwrap {
  };
  &sata {
-    status = "disable";
+    status = "disabled";
  };
  &sata_phy {
-    status = "disable";
+    status = "disabled";
  };
  &spi0 {

--
Regards,
Alexandre