selftests: prctl: Add prctl test for PR_GET_NAME
PATCH 1/1 selftests: prctl: Add prctl test for PR_GET_NAME
This patch covers the testing of PR_GET_NAME by reading it's value from proc/self/task/pid/comm and matching it by the value returned by PR_GET_NAME.
--- .../selftests/prctl/set-process-name.c | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)
tools/testing/selftests/prctl/set-process-name.c +25 -0
@@ -47,6 +47,28 @@ int check_null_pointer(char *check_name)return res; } +int check_name (void ) +{ + +int pid; + + pid =getpid (); +FILE *fptr; +char path[50 ] = {}; +int j; + + j =snprintf (path,50 ,"/proc/self/task/%d/comm" , pid); + fptr =fopen (path,"r" ); +char name[TASK_COMM_LEN ] = {}; +int res =prctl (PR_GET_NAME , name,NULL ,NULL ,NULL ); +char output[TASK_COMM_LEN ] = {}; + +fscanf (fptr,"%s" , output); + +return !strcmp (output, name); + +} +TEST (rename_process) {EXPECT_GE (set_name (CHANGE_NAME ),0 );
@@ -57,6 +79,9 @@ TEST(rename_process) {EXPECT_GE (set_name (CHANGE_NAME ),0 );EXPECT_LT (check_null_pointer (CHANGE_NAME ),0 ); + +EXPECT_TRUE (check_name ()); + }TEST_HARNESS_MAIN
Signature · 1 line
2.34.1
Shuah Khan
maintainerQuoted 4 lines · Osama Muhammad
This patch covers the testing of
PR_GET_NAMEby reading it's value from proc/self/task/pid/comm and matching it by the value returned byPR_GET_NAME.
So the values should match? Can you elaborate that in the change log.
Quoted 11 lines
Signed-off-by Osama Muhammad <[email protected]>--- .../selftests/prctl/set-process-name.c | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)tools/testing/selftests/prctl/set-process-name.c +0
-0@@ -47,6 +47,28 @@ int check_null_pointer(char *check_name)return res;
tools/testing/selftests/prctl/set-process-name.c int check_null_pointer(char *check_name) · line 57
Quoted 10 lines
tools/testing/selftests/prctl/set-process-name.c +8
-0} +int check_name (void ) +{ + +int pid; + + pid =getpid (); +FILE *fptr; +char path[50 ] = {};
Define this and use it. Don't hard-code the size.MAX_PATH_LEN - look for other such defines.
tools/testing/selftests/prctl/set-process-name.c int check_null_pointer(char *check_name) · line 60
Quoted 3 lines
tools/testing/selftests/prctl/set-process-name.c +3
-0+int j; + + j =snprintf (path,50 ,"/proc/self/task/%d/comm" , pid);
Here - it makes it easier to maintain.
tools/testing/selftests/prctl/set-process-name.c int check_null_pointer(char *check_name) · line 64
Quoted 4 lines
tools/testing/selftests/prctl/set-process-name.c +4
-0+ fptr =fopen (path,"r" ); +char name[TASK_COMM_LEN ] = {}; +int res =prctl (PR_GET_NAME , name,NULL ,NULL ,NULL ); +char output[TASK_COMM_LEN ] = {};
Code after declarations please. It is easier to read and follow.
tools/testing/selftests/prctl/set-process-name.c int check_null_pointer(char *check_name) · line 66
Quoted 2 lines
tools/testing/selftests/prctl/set-process-name.c +2
-0+ +fscanf (fptr,"%s" , output);
Don't you want to check error return here?
tools/testing/selftests/prctl/set-process-name.c TEST(rename_process) { · line 82
Quoted 13 lines
tools/testing/selftests/prctl/set-process-name.c +6
-0+ +return !strcmp (output, name); + +} +TEST (rename_process) {EXPECT_GE (set_name (CHANGE_NAME ),0 );@@ -57,6 +79,9 @@ TEST(rename_process) {EXPECT_GE (set_name (CHANGE_NAME ),0 );EXPECT_LT (check_null_pointer (CHANGE_NAME ),0 ); +
No need to for this extra line
tools/testing/selftests/prctl/set-process-name.c TEST(rename_process) { · line 87
Quoted 5 lines
tools/testing/selftests/prctl/set-process-name.c +2
-0+EXPECT_TRUE (check_name ()); + }TEST_HARNESS_MAIN
thanks,
-- Shuah