scsi: lpfc: Do not abuse UUID APIs
Subsystems (2)
PATCH 1/1 scsi: lpfc: Do not abuse UUID APIs
The lpfc_vmid_host_uuid is not defined as uuid_t and its usage is not the same as for uuid_t operations (like exporting or importing). Hence replace call to uuid_is_null() by respective memchr_inv() without abusing casting.
--- drivers/scsi/lpfc/lpfc_els.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +2 -2
@@ -1332,7 +1332,7 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,if (phba->cfg_vmid_priority_tagging) { sp->cmn.priority_tagging =1 ;/* lpfc_vmid_host_uuid is combination of wwpn and wwnn */ -if (uuid_is_null ((uuid_t *)vport->lpfc_vmid_host_uuid)) { +if (memchr_inv (vport->lpfc_vmid_host_uuid,0 ,LPFC_COMPRESS_VMID_SIZE )) {memcpy (vport->lpfc_vmid_host_uuid, phba->wwpn,sizeof (phba->wwpn)); memcpy(&vport->lpfc_vmid_host_uuid[8], phba->wwnn,
@@ -12331,7 +12331,7 @@ lpfc_vmid_uvem(struct lpfc_vport *vport, elsiocb->vmid_tag.vmid_context = vmid_context; pcmd = (u8 *)elsiocb->cmd_dmabuf->virt; -if (uuid_is_null ((uuid_t *)vport->lpfc_vmid_host_uuid)) +if (memchr_inv (vport->lpfc_vmid_host_uuid,0 ,LPFC_COMPRESS_VMID_SIZE ))memcpy (vport->lpfc_vmid_host_uuid, vmid->host_vmid,LPFC_COMPRESS_VMID_SIZE );
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 4 lines · Andy Shevchenko
The
lpfc_vmid_host_uuidis not defined asuuid_tand its usage is not the same as foruuid_toperations (like exporting or importing). Hence replace call touuid_is_null()by respectivememchr_inv()without abusing casting.
The v2 had been issued, this patch is wrong, sorry.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Justin Tee
maintainerQuoted 7 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
The
lpfc_vmid_host_uuidis not defined asuuid_tand its usage is not the same as foruuid_toperations (like exporting or importing). Hence replace call touuid_is_null()by respectivememchr_inv()without abusing casting.
Quoted 5 lines
The v2 had been issued, this patch is wrong, sorry.
--
With Best Regards,
Andy Shevchenko
Hi Andy,
Thanks I would prefer to use sizeof instead of LPFC_COMPRESS_VMID_SIZE. Otherwise, the change looks fine to me.
drivers/scsi/lpfc/lpfc_els.c +0 -0
@@ -1331,7 +1331,8 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport,
struct lpfc_nodelist *ndlp,
if (phba->cfg_vmid_priority_tagging) {
sp->cmn.priority_tagging = 1;
/* lpfc_vmid_host_uuid is combination of wwpn and wwnn */
- if (uuid_is_null((uuid_t *)vport->lpfc_vmid_host_uuid)) {
+ if (!memchr_inv(vport->lpfc_vmid_host_uuid, 0,
+ sizeof(vport->lpfc_vmid_host_uuid))) {
memcpy(vport->lpfc_vmid_host_uuid, phba->wwpn,
sizeof(phba->wwpn));
memcpy(&vport->lpfc_vmid_host_uuid[8], phba->wwnn,
@@ -12357,7 +12358,8 @@ lpfc_vmid_uvem(struct lpfc_vport *vport,
elsiocb->vmid_tag.vmid_context = vmid_context;
pcmd = (u8 *)elsiocb->cmd_dmabuf->virt;- if (uuid_is_null((uuid_t *)vport->lpfc_vmid_host_uuid))
+ if (!memchr_inv(vport->lpfc_vmid_host_uuid, 0,
+ sizeof(vport->lpfc_vmid_host_uuid))
memcpy(vport->lpfc_vmid_host_uuid, vmid->host_vmid,
LPFC_COMPRESS_VMID_SIZE);Regards,
Justin
Signature · 11 lines
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Quoted 12 lines · Justin Tee
Signature · 11 lines
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Removed from mailbox.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Justin Tee
maintainerQuoted 16 lines · Andy Shevchenko
Quoted 4 lines · Justin Tee
--
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may containQuoted 8 lines
information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Quoted 5 lines
Removed from mailbox.
--
With Best Regards,
Andy Shevchenko
Hi Andy,
There is no need to remove from mailbox because you were the intended recipient of my previous email as well as everyone subscribed to the linux-scsi and linux-kernel mailing list (:
I still prefer sizeof(vport->lpfc_vmid_host_uuid) instead of LPFC_COMPRESS_VMID_SIZE.
Thanks,
Justin
Signature · 11 lines
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.